All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: vkuznets <vkuznets@redhat.com>,
	"lantianyu1986@gmail.com" <lantianyu1986@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"ehabkost@redhat.com" <ehabkost@redhat.com>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	Roman Kagan <rkagan@virtuozzo.com>
Subject: Re: [PATCH] target/i386/kvm: Add Hyper-V direct tlb flush support
Date: Mon, 14 Oct 2019 15:48:25 +0200	[thread overview]
Message-ID: <20191014154825.7eb5017d.cohuck@redhat.com> (raw)
In-Reply-To: <KL1P15301MB02611D1F7C54C4A599766B8D92900@KL1P15301MB0261.APCP153.PROD.OUTLOOK.COM>

On Mon, 14 Oct 2019 13:29:12 +0000
Tianyu Lan <Tianyu.Lan@microsoft.com> wrote:

> > > diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> > > index 18892d6541..923fb33a01 100644
> > > --- a/linux-headers/linux/kvm.h
> > > +++ b/linux-headers/linux/kvm.h
> > > @@ -995,6 +995,7 @@ struct kvm_ppc_resize_hpt {
> > >  #define KVM_CAP_ARM_SVE 170
> > >  #define KVM_CAP_ARM_PTRAUTH_ADDRESS 171
> > >  #define KVM_CAP_ARM_PTRAUTH_GENERIC 172
> > > +#define KVM_CAP_HYPERV_DIRECT_TLBFLUSH 174  
> >
> > I was once told that scripts/update-linux-headers.sh script is supposed
> > to be used instead of cherry-picking stuff you need (adn this would be a
> > separate patch - update linux headers to smth).
> >  
> 
> Thanks for suggestion. I just try the update-linux-headers.sh and there are a lot
> of changes which are not related with my patch. I also include these
> changes in my patch, right?

The important part is that you split out the headers update as a
separate patch.

If this change is already included in the upstream kernel, just do a
complete update via the script (mentioning the base you did the update
against.) If not, include a placeholder patch that can be replaced by a
real update when applying.

WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: "ehabkost@redhat.com" <ehabkost@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Roman Kagan <rkagan@virtuozzo.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	vkuznets <vkuznets@redhat.com>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"lantianyu1986@gmail.com" <lantianyu1986@gmail.com>
Subject: Re: [PATCH] target/i386/kvm: Add Hyper-V direct tlb flush support
Date: Mon, 14 Oct 2019 15:48:25 +0200	[thread overview]
Message-ID: <20191014154825.7eb5017d.cohuck@redhat.com> (raw)
In-Reply-To: <KL1P15301MB02611D1F7C54C4A599766B8D92900@KL1P15301MB0261.APCP153.PROD.OUTLOOK.COM>

On Mon, 14 Oct 2019 13:29:12 +0000
Tianyu Lan <Tianyu.Lan@microsoft.com> wrote:

> > > diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> > > index 18892d6541..923fb33a01 100644
> > > --- a/linux-headers/linux/kvm.h
> > > +++ b/linux-headers/linux/kvm.h
> > > @@ -995,6 +995,7 @@ struct kvm_ppc_resize_hpt {
> > >  #define KVM_CAP_ARM_SVE 170
> > >  #define KVM_CAP_ARM_PTRAUTH_ADDRESS 171
> > >  #define KVM_CAP_ARM_PTRAUTH_GENERIC 172
> > > +#define KVM_CAP_HYPERV_DIRECT_TLBFLUSH 174  
> >
> > I was once told that scripts/update-linux-headers.sh script is supposed
> > to be used instead of cherry-picking stuff you need (adn this would be a
> > separate patch - update linux headers to smth).
> >  
> 
> Thanks for suggestion. I just try the update-linux-headers.sh and there are a lot
> of changes which are not related with my patch. I also include these
> changes in my patch, right?

The important part is that you split out the headers update as a
separate patch.

If this change is already included in the upstream kernel, just do a
complete update via the script (mentioning the base you did the update
against.) If not, include a placeholder patch that can be replaced by a
real update when applying.


  reply	other threads:[~2019-10-14 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  3:41 [PATCH] target/i386/kvm: Add Hyper-V direct tlb flush support lantianyu1986
2019-10-13  8:49 ` Vitaly Kuznetsov
2019-10-13  8:49   ` Vitaly Kuznetsov
2019-10-14 13:29   ` Tianyu Lan
2019-10-14 13:48     ` Cornelia Huck [this message]
2019-10-14 13:48       ` Cornelia Huck
2019-10-14 14:26       ` Tianyu Lan
2019-10-14 14:57     ` Vitaly Kuznetsov
2019-10-14 14:57       ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014154825.7eb5017d.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=Tianyu.Lan@microsoft.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lantianyu1986@gmail.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    --cc=rth@twiddle.net \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.