From: Christoph Hellwig <hch@infradead.org>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dave Chinner <dchinner@redhat.com>,
Eric Sandeen <esandeen@redhat.com>,
Hari Bathini <hbathini@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock
Date: Tue, 15 Oct 2019 01:01:34 -0700 [thread overview]
Message-ID: <20191015080134.GC3055@infradead.org> (raw)
In-Reply-To: <20191015015620.GA14327@mypc>
On Tue, Oct 15, 2019 at 09:56:20AM +0800, Pingfan Liu wrote:
> Agree. For the consistency of the whole fs, we need grub to be aware of
> log. While this patch just assumes that files accessed by grub are
> known, and the consistency is forced only on these files.
> > get by freezing and unfreezing the file system using the FIFREEZE and
> > FITHAW ioctls. And if my memory is serving me correctly Dave has been
> freeze will block any further modification to the fs. That is different
> from my patch, which does not have such limitation.
So you freeze and immediately unfreeze.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: linux-xfs@vger.kernel.org, Eric Sandeen <esandeen@redhat.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <dchinner@redhat.com>,
linuxppc-dev@lists.ozlabs.org,
Hari Bathini <hbathini@linux.ibm.com>
Subject: Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock
Date: Tue, 15 Oct 2019 01:01:34 -0700 [thread overview]
Message-ID: <20191015080134.GC3055@infradead.org> (raw)
In-Reply-To: <20191015015620.GA14327@mypc>
On Tue, Oct 15, 2019 at 09:56:20AM +0800, Pingfan Liu wrote:
> Agree. For the consistency of the whole fs, we need grub to be aware of
> log. While this patch just assumes that files accessed by grub are
> known, and the consistency is forced only on these files.
> > get by freezing and unfreezing the file system using the FIFREEZE and
> > FITHAW ioctls. And if my memory is serving me correctly Dave has been
> freeze will block any further modification to the fs. That is different
> from my patch, which does not have such limitation.
So you freeze and immediately unfreeze.
next prev parent reply other threads:[~2019-10-15 8:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 14:37 [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock Pingfan Liu
2019-10-13 14:37 ` Pingfan Liu
2019-10-13 16:34 ` Darrick J. Wong
2019-10-13 16:34 ` Darrick J. Wong
2019-10-14 8:33 ` Pingfan Liu
2019-10-14 8:33 ` Pingfan Liu
2019-10-14 9:43 ` Jan Kara
2019-10-14 9:43 ` Jan Kara
2019-10-14 13:23 ` Eric Sandeen
2019-10-14 13:23 ` Eric Sandeen
2019-10-14 20:03 ` Jan Kara
2019-10-14 20:03 ` Jan Kara
2019-10-14 20:09 ` Eric Sandeen
2019-10-14 20:09 ` Eric Sandeen
2019-10-15 8:01 ` Christoph Hellwig
2019-10-15 8:01 ` Christoph Hellwig
2019-10-15 13:10 ` Theodore Y. Ts'o
2019-10-15 13:10 ` Theodore Y. Ts'o
2019-10-15 16:18 ` Darrick J. Wong
2019-10-15 16:18 ` Darrick J. Wong
2019-10-15 2:20 ` Pingfan Liu
2019-10-15 2:20 ` Pingfan Liu
2019-10-15 2:12 ` Pingfan Liu
2019-10-15 2:12 ` Pingfan Liu
2019-10-14 8:40 ` Christoph Hellwig
2019-10-14 8:40 ` Christoph Hellwig
2019-10-15 1:56 ` Pingfan Liu
2019-10-15 1:56 ` Pingfan Liu
2019-10-15 8:01 ` Christoph Hellwig [this message]
2019-10-15 8:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015080134.GC3055@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=esandeen@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=kernelfans@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.