From: kbuild test robot <lkp@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
kbuild-all@lists.01.org, Jonas Karlman <jonas@kwiboo.se>,
David Airlie <airlied@linux.ie>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()
Date: Tue, 15 Oct 2019 11:58:32 +0800 [thread overview]
Message-ID: <201910151131.hWS2XSgE%lkp@intel.com> (raw)
In-Reply-To: <20191014184320.GA161094@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 3234 bytes --]
Hi Dmitry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc3 next-20191014]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/drm-bridge-ti-tfp410-switch-to-using-fwnode_gpiod_get_index/20191015-024641
config: nds32-allmodconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/bridge/ti-tfp410.c: In function 'tfp410_get_connector_properties':
drivers/gpu/drm/bridge/ti-tfp410.c:287:13: error: implicit declaration of function 'fwnode_gpiod_get_index'; did you mean 'devm_gpiod_get_index'? [-Werror=implicit-function-declaration]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^~~~~~~~~~~~~~~~~~~~~~
devm_gpiod_get_index
>> drivers/gpu/drm/bridge/ti-tfp410.c:287:11: warning: assignment to 'struct gpio_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^
cc1: some warnings being treated as errors
vim +287 drivers/gpu/drm/bridge/ti-tfp410.c
271
272 static int tfp410_get_connector_properties(struct tfp410 *dvi)
273 {
274 struct device_node *connector_node, *ddc_phandle;
275 int ret = 0;
276
277 /* port@1 is the connector node */
278 connector_node = of_graph_get_remote_node(dvi->dev->of_node, 1, -1);
279 if (!connector_node)
280 return -ENODEV;
281
282 if (of_device_is_compatible(connector_node, "hdmi-connector"))
283 dvi->connector_type = DRM_MODE_CONNECTOR_HDMIA;
284 else
285 dvi->connector_type = DRM_MODE_CONNECTOR_DVID;
286
> 287 dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
288 "hpd", 0, GPIOD_IN, "hpd");
289 if (IS_ERR(dvi->hpd)) {
290 ret = PTR_ERR(dvi->hpd);
291 dvi->hpd = NULL;
292 if (ret == -ENOENT)
293 ret = 0;
294 else
295 goto fail;
296 }
297
298 ddc_phandle = of_parse_phandle(connector_node, "ddc-i2c-bus", 0);
299 if (!ddc_phandle)
300 goto fail;
301
302 dvi->ddc = of_get_i2c_adapter_by_node(ddc_phandle);
303 if (dvi->ddc)
304 dev_info(dvi->dev, "Connector's ddc i2c bus found\n");
305 else
306 ret = -EPROBE_DEFER;
307
308 of_node_put(ddc_phandle);
309
310 fail:
311 of_node_put(connector_node);
312 return ret;
313 }
314
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52991 bytes --]
[-- Attachment #3: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()
Date: Tue, 15 Oct 2019 11:58:32 +0800 [thread overview]
Message-ID: <201910151131.hWS2XSgE%lkp@intel.com> (raw)
In-Reply-To: <20191014184320.GA161094@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 3320 bytes --]
Hi Dmitry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc3 next-20191014]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/drm-bridge-ti-tfp410-switch-to-using-fwnode_gpiod_get_index/20191015-024641
config: nds32-allmodconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/bridge/ti-tfp410.c: In function 'tfp410_get_connector_properties':
drivers/gpu/drm/bridge/ti-tfp410.c:287:13: error: implicit declaration of function 'fwnode_gpiod_get_index'; did you mean 'devm_gpiod_get_index'? [-Werror=implicit-function-declaration]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^~~~~~~~~~~~~~~~~~~~~~
devm_gpiod_get_index
>> drivers/gpu/drm/bridge/ti-tfp410.c:287:11: warning: assignment to 'struct gpio_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^
cc1: some warnings being treated as errors
vim +287 drivers/gpu/drm/bridge/ti-tfp410.c
271
272 static int tfp410_get_connector_properties(struct tfp410 *dvi)
273 {
274 struct device_node *connector_node, *ddc_phandle;
275 int ret = 0;
276
277 /* port(a)1 is the connector node */
278 connector_node = of_graph_get_remote_node(dvi->dev->of_node, 1, -1);
279 if (!connector_node)
280 return -ENODEV;
281
282 if (of_device_is_compatible(connector_node, "hdmi-connector"))
283 dvi->connector_type = DRM_MODE_CONNECTOR_HDMIA;
284 else
285 dvi->connector_type = DRM_MODE_CONNECTOR_DVID;
286
> 287 dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
288 "hpd", 0, GPIOD_IN, "hpd");
289 if (IS_ERR(dvi->hpd)) {
290 ret = PTR_ERR(dvi->hpd);
291 dvi->hpd = NULL;
292 if (ret == -ENOENT)
293 ret = 0;
294 else
295 goto fail;
296 }
297
298 ddc_phandle = of_parse_phandle(connector_node, "ddc-i2c-bus", 0);
299 if (!ddc_phandle)
300 goto fail;
301
302 dvi->ddc = of_get_i2c_adapter_by_node(ddc_phandle);
303 if (dvi->ddc)
304 dev_info(dvi->dev, "Connector's ddc i2c bus found\n");
305 else
306 ret = -EPROBE_DEFER;
307
308 of_node_put(ddc_phandle);
309
310 fail:
311 of_node_put(connector_node);
312 return ret;
313 }
314
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52991 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: kbuild-all@lists.01.org, Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Linus Walleij <linus.walleij@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()
Date: Tue, 15 Oct 2019 11:58:32 +0800 [thread overview]
Message-ID: <201910151131.hWS2XSgE%lkp@intel.com> (raw)
In-Reply-To: <20191014184320.GA161094@dtor-ws>
[-- Attachment #1: Type: text/plain, Size: 3234 bytes --]
Hi Dmitry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc3 next-20191014]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/drm-bridge-ti-tfp410-switch-to-using-fwnode_gpiod_get_index/20191015-024641
config: nds32-allmodconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/bridge/ti-tfp410.c: In function 'tfp410_get_connector_properties':
drivers/gpu/drm/bridge/ti-tfp410.c:287:13: error: implicit declaration of function 'fwnode_gpiod_get_index'; did you mean 'devm_gpiod_get_index'? [-Werror=implicit-function-declaration]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^~~~~~~~~~~~~~~~~~~~~~
devm_gpiod_get_index
>> drivers/gpu/drm/bridge/ti-tfp410.c:287:11: warning: assignment to 'struct gpio_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^
cc1: some warnings being treated as errors
vim +287 drivers/gpu/drm/bridge/ti-tfp410.c
271
272 static int tfp410_get_connector_properties(struct tfp410 *dvi)
273 {
274 struct device_node *connector_node, *ddc_phandle;
275 int ret = 0;
276
277 /* port@1 is the connector node */
278 connector_node = of_graph_get_remote_node(dvi->dev->of_node, 1, -1);
279 if (!connector_node)
280 return -ENODEV;
281
282 if (of_device_is_compatible(connector_node, "hdmi-connector"))
283 dvi->connector_type = DRM_MODE_CONNECTOR_HDMIA;
284 else
285 dvi->connector_type = DRM_MODE_CONNECTOR_DVID;
286
> 287 dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
288 "hpd", 0, GPIOD_IN, "hpd");
289 if (IS_ERR(dvi->hpd)) {
290 ret = PTR_ERR(dvi->hpd);
291 dvi->hpd = NULL;
292 if (ret == -ENOENT)
293 ret = 0;
294 else
295 goto fail;
296 }
297
298 ddc_phandle = of_parse_phandle(connector_node, "ddc-i2c-bus", 0);
299 if (!ddc_phandle)
300 goto fail;
301
302 dvi->ddc = of_get_i2c_adapter_by_node(ddc_phandle);
303 if (dvi->ddc)
304 dev_info(dvi->dev, "Connector's ddc i2c bus found\n");
305 else
306 ret = -EPROBE_DEFER;
307
308 of_node_put(ddc_phandle);
309
310 fail:
311 of_node_put(connector_node);
312 return ret;
313 }
314
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52991 bytes --]
next prev parent reply other threads:[~2019-10-15 3:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:43 [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() Dmitry Torokhov
2019-10-14 20:59 ` kbuild test robot
2019-10-14 20:59 ` kbuild test robot
2019-10-15 3:58 ` kbuild test robot [this message]
2019-10-15 3:58 ` kbuild test robot
2019-10-15 3:58 ` kbuild test robot
2019-11-05 0:40 ` Dmitry Torokhov
2019-11-05 0:40 ` Dmitry Torokhov
2019-11-05 15:29 ` Linus Walleij
2019-11-05 15:29 ` Linus Walleij
2019-11-05 15:41 ` Daniel Vetter
2019-11-05 15:41 ` Daniel Vetter
2019-11-05 19:53 ` Laurent Pinchart
2019-11-05 19:53 ` Laurent Pinchart
2019-11-06 9:51 ` Daniel Vetter
2019-11-06 9:51 ` Daniel Vetter
2019-11-13 13:52 ` Linus Walleij
2019-11-13 13:52 ` Linus Walleij
2019-11-13 17:25 ` Daniel Vetter
2019-11-13 17:25 ` Daniel Vetter
2019-11-13 13:49 ` Linus Walleij
2019-11-13 13:49 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910151131.hWS2XSgE%lkp@intel.com \
--to=lkp@intel.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.