All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jian-Hong Pan <jian-hong@endlessm.com>
Cc: David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux@endlessm.com
Subject: Re: [PATCH] drm/i915/hdmi: enable resolution 3840x2160 for type 1 HDMI
Date: Wed, 16 Oct 2019 13:33:06 +0300	[thread overview]
Message-ID: <20191016103306.GL1208@intel.com> (raw)
In-Reply-To: <20191016095757.4919-1-jian-hong@endlessm.com>

On Wed, Oct 16, 2019 at 05:57:58PM +0800, Jian-Hong Pan wrote:
> Type 1 HDMI may be version 1.3 or upper, which supports higher max TMDS
> clock for higher resolutions,

Spec says "Type 1 adaptors can support DVI or HDMI up to a 165MHz TMDS clock rate."

And I've definitely seen HDMI dongles that can't deal with
eg. 1080p 12bpc @225MHz. We don't want users with black screens
out of the box, so NAK.

If you want to "overclock" your hardware you can do so by setting up
the modeline manually.

> like 3840x2160. This patch sets max TMDS
> clock according to the chip, if the adapter is type 1 HDMI.
> 
> Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=112018
> Fixes: b1ba124d8e95 ("drm/i915: Respect DP++ adaptor TMDS clock limit")
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index e02f0faecf02..74e4426ffcad 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2454,6 +2454,7 @@ intel_hdmi_dp_dual_mode_detect(struct drm_connector *connector, bool has_edid)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
>  	struct intel_hdmi *hdmi = intel_attached_hdmi(connector);
> +	struct intel_encoder *encoder = &hdmi_to_dig_port(hdmi)->base;
>  	enum port port = hdmi_to_dig_port(hdmi)->base.port;
>  	struct i2c_adapter *adapter =
>  		intel_gmbus_get_adapter(dev_priv, hdmi->ddc_bus);
> @@ -2488,8 +2489,16 @@ intel_hdmi_dp_dual_mode_detect(struct drm_connector *connector, bool has_edid)
>  		return;
>  
>  	hdmi->dp_dual_mode.type = type;
> -	hdmi->dp_dual_mode.max_tmds_clock =
> -		drm_dp_dual_mode_max_tmds_clock(type, adapter);
> +	/* Type 1 HDMI may be version 1.3 or upper, which supports higher max
> +	 * TMDS clock for higher resolutions, like 3840x2160. So, set it
> +	 * according to the chip, if the adapter is type 1 HDMI.
> +	 */
> +	if (type == DRM_DP_DUAL_MODE_TYPE1_HDMI)
> +		hdmi->dp_dual_mode.max_tmds_clock =
> +			intel_hdmi_source_max_tmds_clock(encoder);
> +	else
> +		hdmi->dp_dual_mode.max_tmds_clock =
> +			drm_dp_dual_mode_max_tmds_clock(type, adapter);
>  
>  	DRM_DEBUG_KMS("DP dual mode adaptor (%s) detected (max TMDS clock: %d kHz)\n",
>  		      drm_dp_get_dual_mode_type_name(type),
> -- 
> 2.23.0

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jian-Hong Pan <jian-hong@endlessm.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Ramalingam C <ramalingam.c@intel.com>,
	Uma Shankar <uma.shankar@intel.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, linux@endlessm.com
Subject: Re: [PATCH] drm/i915/hdmi: enable resolution 3840x2160 for type 1 HDMI
Date: Wed, 16 Oct 2019 13:33:06 +0300	[thread overview]
Message-ID: <20191016103306.GL1208@intel.com> (raw)
In-Reply-To: <20191016095757.4919-1-jian-hong@endlessm.com>

On Wed, Oct 16, 2019 at 05:57:58PM +0800, Jian-Hong Pan wrote:
> Type 1 HDMI may be version 1.3 or upper, which supports higher max TMDS
> clock for higher resolutions,

Spec says "Type 1 adaptors can support DVI or HDMI up to a 165MHz TMDS clock rate."

And I've definitely seen HDMI dongles that can't deal with
eg. 1080p 12bpc @225MHz. We don't want users with black screens
out of the box, so NAK.

If you want to "overclock" your hardware you can do so by setting up
the modeline manually.

> like 3840x2160. This patch sets max TMDS
> clock according to the chip, if the adapter is type 1 HDMI.
> 
> Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=112018
> Fixes: b1ba124d8e95 ("drm/i915: Respect DP++ adaptor TMDS clock limit")
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> ---
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index e02f0faecf02..74e4426ffcad 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -2454,6 +2454,7 @@ intel_hdmi_dp_dual_mode_detect(struct drm_connector *connector, bool has_edid)
>  {
>  	struct drm_i915_private *dev_priv = to_i915(connector->dev);
>  	struct intel_hdmi *hdmi = intel_attached_hdmi(connector);
> +	struct intel_encoder *encoder = &hdmi_to_dig_port(hdmi)->base;
>  	enum port port = hdmi_to_dig_port(hdmi)->base.port;
>  	struct i2c_adapter *adapter =
>  		intel_gmbus_get_adapter(dev_priv, hdmi->ddc_bus);
> @@ -2488,8 +2489,16 @@ intel_hdmi_dp_dual_mode_detect(struct drm_connector *connector, bool has_edid)
>  		return;
>  
>  	hdmi->dp_dual_mode.type = type;
> -	hdmi->dp_dual_mode.max_tmds_clock =
> -		drm_dp_dual_mode_max_tmds_clock(type, adapter);
> +	/* Type 1 HDMI may be version 1.3 or upper, which supports higher max
> +	 * TMDS clock for higher resolutions, like 3840x2160. So, set it
> +	 * according to the chip, if the adapter is type 1 HDMI.
> +	 */
> +	if (type == DRM_DP_DUAL_MODE_TYPE1_HDMI)
> +		hdmi->dp_dual_mode.max_tmds_clock =
> +			intel_hdmi_source_max_tmds_clock(encoder);
> +	else
> +		hdmi->dp_dual_mode.max_tmds_clock =
> +			drm_dp_dual_mode_max_tmds_clock(type, adapter);
>  
>  	DRM_DEBUG_KMS("DP dual mode adaptor (%s) detected (max TMDS clock: %d kHz)\n",
>  		      drm_dp_get_dual_mode_type_name(type),
> -- 
> 2.23.0

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2019-10-16 10:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16  9:57 [PATCH] drm/i915/hdmi: enable resolution 3840x2160 for type 1 HDMI Jian-Hong Pan
2019-10-16 10:33 ` Ville Syrjälä [this message]
2019-10-16 10:33   ` Ville Syrjälä
2019-10-17  1:06 ` ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016103306.GL1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jian-hong@endlessm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.