All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Eiderman <sameid@google.com>
To: qemu-devel@nongnu.org
Cc: arbel.moshe@oracle.com, karl.heubaum@oracle.com,
	kevin@koconnor.net,  kraxel@redhat.com, kwolf@redhat.com,
	liran.alon@oracle.com,  qemu-block@nongnu.org, sameid@google.com,
	seabios@seabios.org,  lersek@redhat.com, philmd@redhat.com,
	jsnow@redhat.com,  Sam Eiderman <shmuel.eiderman@oracle.com>
Subject: [PATCH v8 2/8] block: Support providing LCHS from user
Date: Wed, 16 Oct 2019 19:41:39 +0300	[thread overview]
Message-ID: <20191016164145.115898-4-sameid@google.com> (raw)
In-Reply-To: <20191016164145.115898-1-sameid@google.com>

From: Sam Eiderman <shmuel.eiderman@oracle.com>

Add logical geometry variables to BlockConf.

A user can now supply "lcyls", "lheads" & "lsecs" for any HD device
that supports CHS ("cyls", "heads", "secs").

These devices include:
    * ide-hd
    * scsi-hd
    * virtio-blk-pci

In future commits we will use the provided LCHS and pass it to the BIOS
through fw_cfg to be supplied using INT13 routines.

Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com>
Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
Signed-off-by: Sam Eiderman <sameid@google.com>
---
 include/hw/block/block.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/hw/block/block.h b/include/hw/block/block.h
index fd55a30bca..d7246f3862 100644
--- a/include/hw/block/block.h
+++ b/include/hw/block/block.h
@@ -26,6 +26,7 @@ typedef struct BlockConf {
     uint32_t discard_granularity;
     /* geometry, not all devices use this */
     uint32_t cyls, heads, secs;
+    uint32_t lcyls, lheads, lsecs;
     OnOffAuto wce;
     bool share_rw;
     BlockdevOnError rerror;
@@ -65,7 +66,10 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf)
 #define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf)                      \
     DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0),                  \
     DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0),                \
-    DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
+    DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0),                  \
+    DEFINE_PROP_UINT32("lcyls", _state, _conf.lcyls, 0),                \
+    DEFINE_PROP_UINT32("lheads", _state, _conf.lheads, 0),              \
+    DEFINE_PROP_UINT32("lsecs", _state, _conf.lsecs, 0)
 
 #define DEFINE_BLOCK_ERROR_PROPERTIES(_state, _conf)                    \
     DEFINE_PROP_BLOCKDEV_ON_ERROR("rerror", _state, _conf.rerror,       \
-- 
2.23.0.700.g56cf767bdb-goog



  parent reply	other threads:[~2019-10-16 16:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 16:41 [PATCH v8 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman
2019-10-16 16:41 ` [PATCH v8 1/8] block: Refactor macros - fix tabbing Sam Eiderman
2019-10-16 16:41 ` [PATCH v8 1/1] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-10-16 16:41 ` Sam Eiderman [this message]
2019-10-22 10:20   ` [PATCH v8 2/8] block: Support providing LCHS from user Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 3/8] bootdevice: Add interface to gather LCHS Sam Eiderman
2019-10-22 10:22   ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman
2019-10-22 10:23   ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman
2019-10-22 10:30   ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman
2019-10-22 10:32   ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman
2019-10-22 10:35   ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-10-16 20:13 ` [PATCH v8 0/8] Add Qemu to SeaBIOS LCHS interface no-reply
2019-10-21 21:02 ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016164145.115898-4-sameid@google.com \
    --to=sameid@google.com \
    --cc=arbel.moshe@oracle.com \
    --cc=jsnow@redhat.com \
    --cc=karl.heubaum@oracle.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=liran.alon@oracle.com \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=seabios@seabios.org \
    --cc=shmuel.eiderman@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.