From: Sam Eiderman <sameid@google.com>
To: qemu-devel@nongnu.org
Cc: arbel.moshe@oracle.com, karl.heubaum@oracle.com,
kevin@koconnor.net, kraxel@redhat.com, kwolf@redhat.com,
liran.alon@oracle.com, qemu-block@nongnu.org, sameid@google.com,
seabios@seabios.org, lersek@redhat.com, philmd@redhat.com,
jsnow@redhat.com, Sam Eiderman <shmuel.eiderman@oracle.com>
Subject: [PATCH v8 3/8] bootdevice: Add interface to gather LCHS
Date: Wed, 16 Oct 2019 19:41:40 +0300 [thread overview]
Message-ID: <20191016164145.115898-5-sameid@google.com> (raw)
In-Reply-To: <20191016164145.115898-1-sameid@google.com>
From: Sam Eiderman <shmuel.eiderman@oracle.com>
Add an interface to provide direct logical CHS values for boot devices.
We will use this interface in the next commits.
Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com>
Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
Signed-off-by: Sam Eiderman <sameid@google.com>
---
bootdevice.c | 55 +++++++++++++++++++++++++++++++++++++++++
include/sysemu/sysemu.h | 3 +++
2 files changed, 58 insertions(+)
diff --git a/bootdevice.c b/bootdevice.c
index 1d225202f9..bc5e1c2de4 100644
--- a/bootdevice.c
+++ b/bootdevice.c
@@ -343,3 +343,58 @@ void device_add_bootindex_property(Object *obj, int32_t *bootindex,
/* initialize devices' bootindex property to -1 */
object_property_set_int(obj, -1, name, NULL);
}
+
+typedef struct FWLCHSEntry FWLCHSEntry;
+
+struct FWLCHSEntry {
+ QTAILQ_ENTRY(FWLCHSEntry) link;
+ DeviceState *dev;
+ char *suffix;
+ uint32_t lcyls;
+ uint32_t lheads;
+ uint32_t lsecs;
+};
+
+static QTAILQ_HEAD(, FWLCHSEntry) fw_lchs =
+ QTAILQ_HEAD_INITIALIZER(fw_lchs);
+
+void add_boot_device_lchs(DeviceState *dev, const char *suffix,
+ uint32_t lcyls, uint32_t lheads, uint32_t lsecs)
+{
+ FWLCHSEntry *node;
+
+ if (!lcyls && !lheads && !lsecs) {
+ return;
+ }
+
+ assert(dev != NULL || suffix != NULL);
+
+ node = g_malloc0(sizeof(FWLCHSEntry));
+ node->suffix = g_strdup(suffix);
+ node->dev = dev;
+ node->lcyls = lcyls;
+ node->lheads = lheads;
+ node->lsecs = lsecs;
+
+ QTAILQ_INSERT_TAIL(&fw_lchs, node, link);
+}
+
+void del_boot_device_lchs(DeviceState *dev, const char *suffix)
+{
+ FWLCHSEntry *i;
+
+ if (dev == NULL) {
+ return;
+ }
+
+ QTAILQ_FOREACH(i, &fw_lchs, link) {
+ if ((!suffix || !g_strcmp0(i->suffix, suffix)) &&
+ i->dev == dev) {
+ QTAILQ_REMOVE(&fw_lchs, i, link);
+ g_free(i->suffix);
+ g_free(i);
+
+ break;
+ }
+ }
+}
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 44f18eb739..5bc5c79cbc 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -103,6 +103,9 @@ void device_add_bootindex_property(Object *obj, int32_t *bootindex,
DeviceState *dev, Error **errp);
void restore_boot_order(void *opaque);
void validate_bootdevices(const char *devices, Error **errp);
+void add_boot_device_lchs(DeviceState *dev, const char *suffix,
+ uint32_t lcyls, uint32_t lheads, uint32_t lsecs);
+void del_boot_device_lchs(DeviceState *dev, const char *suffix);
/* handler to set the boot_device order for a specific type of MachineClass */
typedef void QEMUBootSetHandler(void *opaque, const char *boot_order,
--
2.23.0.700.g56cf767bdb-goog
next prev parent reply other threads:[~2019-10-16 16:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 16:41 [PATCH v8 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman
2019-10-16 16:41 ` [PATCH v8 1/8] block: Refactor macros - fix tabbing Sam Eiderman
2019-10-16 16:41 ` [PATCH v8 1/1] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-10-16 16:41 ` [PATCH v8 2/8] block: Support providing LCHS from user Sam Eiderman
2019-10-22 10:20 ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` Sam Eiderman [this message]
2019-10-22 10:22 ` [PATCH v8 3/8] bootdevice: Add interface to gather LCHS Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman
2019-10-22 10:23 ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman
2019-10-22 10:30 ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman
2019-10-22 10:32 ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman
2019-10-22 10:35 ` Philippe Mathieu-Daudé
2019-10-16 16:41 ` [PATCH v8 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-10-16 20:13 ` [PATCH v8 0/8] Add Qemu to SeaBIOS LCHS interface no-reply
2019-10-21 21:02 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016164145.115898-5-sameid@google.com \
--to=sameid@google.com \
--cc=arbel.moshe@oracle.com \
--cc=jsnow@redhat.com \
--cc=karl.heubaum@oracle.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=liran.alon@oracle.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=shmuel.eiderman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.