* [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl
@ 2019-10-16 21:30 Petr Vorel
2019-10-17 9:15 ` Cyril Hrubis
2019-10-17 10:02 ` Jan Stancek
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2019-10-16 21:30 UTC (permalink / raw)
To: ltp
From: Petr Vorel <pvorel@suse.cz>
musl defines loff_t in <fcntl.h> (already included) and guard it under _GNU_SOURCE.
NOTE: glibc and others define it in <sys/types.h>
Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
testcases/kernel/syscalls/setxattr/setxattr03.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/syscalls/setxattr/setxattr03.c b/testcases/kernel/syscalls/setxattr/setxattr03.c
index bb511d5ba..58ee0f880 100644
--- a/testcases/kernel/syscalls/setxattr/setxattr03.c
+++ b/testcases/kernel/syscalls/setxattr/setxattr03.c
@@ -13,6 +13,7 @@
* -1 and set errno to EPERM
*/
+#define _GNU_SOURCE
#include "config.h"
#include <sys/ioctl.h>
#include <sys/types.h>
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl
2019-10-16 21:30 [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl Petr Vorel
@ 2019-10-17 9:15 ` Cyril Hrubis
2019-10-17 20:16 ` Petr Vorel
2019-10-17 10:02 ` Jan Stancek
1 sibling, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2019-10-17 9:15 UTC (permalink / raw)
To: ltp
Hi!
> musl defines loff_t in <fcntl.h> (already included) and guard it under _GNU_SOURCE.
> NOTE: glibc and others define it in <sys/types.h>
I would say that this is obvious enough to go in without a review, acked
nevertheless.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl
2019-10-17 9:15 ` Cyril Hrubis
@ 2019-10-17 20:16 ` Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2019-10-17 20:16 UTC (permalink / raw)
To: ltp
Hi Cyril, Jan,
> Hi!
> > musl defines loff_t in <fcntl.h> (already included) and guard it under _GNU_SOURCE.
> > NOTE: glibc and others define it in <sys/types.h>
> I would say that this is obvious enough to go in without a review, acked
> nevertheless.
Thanks for review, pushed.
Sorry for taking your time with obvious fix, next time I'll push it.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl
2019-10-16 21:30 [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl Petr Vorel
2019-10-17 9:15 ` Cyril Hrubis
@ 2019-10-17 10:02 ` Jan Stancek
1 sibling, 0 replies; 4+ messages in thread
From: Jan Stancek @ 2019-10-17 10:02 UTC (permalink / raw)
To: ltp
----- Original Message -----
> From: Petr Vorel <pvorel@suse.cz>
>
> musl defines loff_t in <fcntl.h> (already included) and guard it under
> _GNU_SOURCE.
> NOTE: glibc and others define it in <sys/types.h>
>
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
ACK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-17 20:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-16 21:30 [LTP] [PATCH 1/1] setxattr03: define _GNU_SOURCE to fix build on musl Petr Vorel
2019-10-17 9:15 ` Cyril Hrubis
2019-10-17 20:16 ` Petr Vorel
2019-10-17 10:02 ` Jan Stancek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.