From: Kamal Heib <kamalheib1@gmail.com>
To: linux-rdma@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Lijun Ou <oulijun@huawei.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Michal Kalderon <mkalderon@marvell.com>,
Kamal Heib <kamalheib1@gmail.com>
Subject: [PATCH for-next v3 1/4] RDMA/core: Fix return code when modify_port isn't supported
Date: Fri, 18 Oct 2019 12:41:12 +0300 [thread overview]
Message-ID: <20191018094115.13167-2-kamalheib1@gmail.com> (raw)
In-Reply-To: <20191018094115.13167-1-kamalheib1@gmail.com>
Improving return code from ib_modify_port() by doing the following:
1- Use "-EOPNOTSUPP" instead "-ENOSYS" which is the proper return code.
2- Avoid confusion by return "-EOPNOTSUPP" when modify_port() isn't
supplied by the provider and the protocol is IB, otherwise return
success to avoid failure of the ib_modify_port() in CM layer.
Fixes: 61e0962d5221 ("IB: Avoid ib_modify_port() failure for RoCE devices")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/core/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index a667636f74bf..626ac18dd3a7 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -2397,7 +2397,7 @@ int ib_modify_port(struct ib_device *device,
port_modify_mask,
port_modify);
else
- rc = rdma_protocol_roce(device, port_num) ? 0 : -ENOSYS;
+ rc = rdma_protocol_ib(device, port_num) ? -EOPNOTSUPP : 0;
return rc;
}
EXPORT_SYMBOL(ib_modify_port);
--
2.20.1
next prev parent reply other threads:[~2019-10-18 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:41 [PATCH for-next v3 0/4] RDMA: modify_port improvements Kamal Heib
2019-10-18 9:41 ` Kamal Heib [this message]
2019-10-18 20:01 ` [PATCH for-next v3 1/4] RDMA/core: Fix return code when modify_port isn't supported Michal Kalderon
2019-10-22 19:20 ` Jason Gunthorpe
2019-10-22 20:21 ` Kamal Heib
2019-10-23 14:40 ` Jason Gunthorpe
2019-10-18 9:41 ` [PATCH for-next v3 2/4] RDMA/hns: Remove unsupported modify_port callback Kamal Heib
2019-10-18 9:41 ` [PATCH for-next v3 3/4] RDMA/ocrdma: " Kamal Heib
2019-10-18 9:41 ` [PATCH for-next v3 4/4] RDMA/qedr: " Kamal Heib
2019-10-18 20:00 ` Michal Kalderon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018094115.13167-2-kamalheib1@gmail.com \
--to=kamalheib1@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=oulijun@huawei.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.