From: Kamal Heib <kamalheib1@gmail.com>
To: linux-rdma@vger.kernel.org
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Lijun Ou <oulijun@huawei.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Michal Kalderon <mkalderon@marvell.com>,
Kamal Heib <kamalheib1@gmail.com>
Subject: [PATCH for-next v3 2/4] RDMA/hns: Remove unsupported modify_port callback
Date: Fri, 18 Oct 2019 12:41:13 +0300 [thread overview]
Message-ID: <20191018094115.13167-3-kamalheib1@gmail.com> (raw)
In-Reply-To: <20191018094115.13167-1-kamalheib1@gmail.com>
There is no need to return always zero for function which is not
supported.
Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
drivers/infiniband/hw/hns/hns_roce_main.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index b5d196c119ee..b241f74a7e3b 100644
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -301,12 +301,6 @@ static int hns_roce_modify_device(struct ib_device *ib_dev, int mask,
return 0;
}
-static int hns_roce_modify_port(struct ib_device *ib_dev, u8 port_num, int mask,
- struct ib_port_modify *props)
-{
- return 0;
-}
-
static int hns_roce_alloc_ucontext(struct ib_ucontext *uctx,
struct ib_udata *udata)
{
@@ -438,7 +432,6 @@ static const struct ib_device_ops hns_roce_dev_ops = {
.get_port_immutable = hns_roce_port_immutable,
.mmap = hns_roce_mmap,
.modify_device = hns_roce_modify_device,
- .modify_port = hns_roce_modify_port,
.modify_qp = hns_roce_modify_qp,
.query_ah = hns_roce_query_ah,
.query_device = hns_roce_query_device,
--
2.20.1
next prev parent reply other threads:[~2019-10-18 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 9:41 [PATCH for-next v3 0/4] RDMA: modify_port improvements Kamal Heib
2019-10-18 9:41 ` [PATCH for-next v3 1/4] RDMA/core: Fix return code when modify_port isn't supported Kamal Heib
2019-10-18 20:01 ` Michal Kalderon
2019-10-22 19:20 ` Jason Gunthorpe
2019-10-22 20:21 ` Kamal Heib
2019-10-23 14:40 ` Jason Gunthorpe
2019-10-18 9:41 ` Kamal Heib [this message]
2019-10-18 9:41 ` [PATCH for-next v3 3/4] RDMA/ocrdma: Remove unsupported modify_port callback Kamal Heib
2019-10-18 9:41 ` [PATCH for-next v3 4/4] RDMA/qedr: " Kamal Heib
2019-10-18 20:00 ` Michal Kalderon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018094115.13167-3-kamalheib1@gmail.com \
--to=kamalheib1@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=oulijun@huawei.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.