* [PATCH] drm: include <drm/drm_cache.h> for 'drm_need_swiotlb'
@ 2019-10-17 11:08 Ben Dooks (Codethink)
2019-10-18 18:45 ` Ville Syrjälä
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-17 11:08 UTC (permalink / raw)
To: linux-kernel; +Cc: David Airlie, Ben Dooks (Codethink), dri-devel, Sean Paul
The drm_need_swiotlb is declared in <drm/drm_cache.h>
which should be included in drivers/gpu/drm/drm_memory.c
to silence the following warning:
drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_memory.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
index 0bec6dbb0142..2d8615baeadc 100644
--- a/drivers/gpu/drm/drm_memory.c
+++ b/drivers/gpu/drm/drm_memory.c
@@ -41,6 +41,7 @@
#include <drm/drm_agpsupport.h>
#include <drm/drm_device.h>
+#include <drm/drm_cache.h>
#include "drm_legacy.h"
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: include <drm/drm_cache.h> for 'drm_need_swiotlb'
2019-10-17 11:08 [PATCH] drm: include <drm/drm_cache.h> for 'drm_need_swiotlb' Ben Dooks (Codethink)
@ 2019-10-18 18:45 ` Ville Syrjälä
0 siblings, 0 replies; 2+ messages in thread
From: Ville Syrjälä @ 2019-10-18 18:45 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: linux-kernel, David Airlie, Sean Paul, dri-devel
On Thu, Oct 17, 2019 at 12:08:46PM +0100, Ben Dooks (Codethink) wrote:
> The drm_need_swiotlb is declared in <drm/drm_cache.h>
> which should be included in drivers/gpu/drm/drm_memory.c
> to silence the following warning:
>
> drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not declared. Should it be static?
IIRC I silenced that already, so you're probably working on
some old tree. For the latest stuff use:
git://anongit.freedesktop.org/drm-tip drm-tip
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/drm_memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index 0bec6dbb0142..2d8615baeadc 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -41,6 +41,7 @@
>
> #include <drm/drm_agpsupport.h>
> #include <drm/drm_device.h>
> +#include <drm/drm_cache.h>
>
> #include "drm_legacy.h"
>
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-18 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-17 11:08 [PATCH] drm: include <drm/drm_cache.h> for 'drm_need_swiotlb' Ben Dooks (Codethink)
2019-10-18 18:45 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.