From: Jiri Pirko <jiri@resnulli.us>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.
Date: Sat, 19 Oct 2019 23:02:02 +0200 [thread overview]
Message-ID: <20191019210202.GN2185@nanopsycho> (raw)
In-Reply-To: <20191019192750.GB25148@lunn.ch>
Sat, Oct 19, 2019 at 09:27:50PM CEST, andrew@lunn.ch wrote:
>> >+address_translation_unit_hash [DEVICE, DRIVER-SPECIFIC]
>>
>> This is quite verbose. Can't you name this just "atu_hash" and be
>> aligned with the function names and MV88E6XXX_DEVLINK_PARAM_ID_ATU_HASH
>> and others?
>
>Hi Jiri
>
>I would use ATU_hash, but not atu_hash, sorry.
That, I don't understand at all :/
The devlink param namespace is full of abbreviations. For example:
iwarp_cmt
gre_ver_check
enable_sriov
ignore_ari
msix_vec_per_pf_max
msix_vec_per_pf_min
fw_load_policy
reset_dev_on_drv_probe
acl_region_rehash_interval
enable_64b_cqe_eqe
enable_4k_uar
Why your thing is special?
Could you please follow the rest of the existing params?
>
>Hopefully somebody will implement bash command completion, making it
>easier.
>
> Andrew
next prev parent reply other threads:[~2019-10-19 21:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 18:51 [PATCH net-next v4 0/2] mv88e6xxx: Allow config of ATU hash algorithm Andrew Lunn
2019-10-19 18:52 ` [PATCH net-next v4 1/2] net: dsa: Add support for devlink device parameters Andrew Lunn
2019-10-19 19:14 ` Jiri Pirko
2019-10-19 19:20 ` Vivien Didelot
2019-10-19 18:52 ` [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm Andrew Lunn
2019-10-19 19:16 ` Jiri Pirko
2019-10-19 19:27 ` Andrew Lunn
2019-10-19 21:02 ` Jiri Pirko [this message]
2019-10-19 21:12 ` Andrew Lunn
2019-10-20 5:54 ` Jiri Pirko
2019-10-20 6:02 ` Jiri Pirko
2019-10-20 17:31 ` Andrew Lunn
2019-10-21 7:57 ` Jiri Pirko
2019-10-19 19:20 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019210202.GN2185@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.