From: Jiri Pirko <jiri@resnulli.us>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.
Date: Sun, 20 Oct 2019 08:02:46 +0200 [thread overview]
Message-ID: <20191020060246.GP2185@nanopsycho> (raw)
In-Reply-To: <20191020055459.GO2185@nanopsycho>
Sun, Oct 20, 2019 at 07:54:59AM CEST, jiri@resnulli.us wrote:
>Sat, Oct 19, 2019 at 11:12:34PM CEST, andrew@lunn.ch wrote:
>>> Could you please follow the rest of the existing params?
>>
>>Why are params special? Devlink resources can and do have upper case
>>characters. So we get into inconsistencies within devlink,
>>particularly if there is a link between a parameter and a resources.
>
>Well, only for netdevsim. Spectrum*.c resources follow the same format.
>I believe that the same format should apply on resources as well.
>
Plus reporters, dpipes follow the same format too. I'm going to send
patches to enforce the format there too.
>
>>
>>And i will soon be adding a resource, and it will be upper case, since
>>that is allowed. And it will be related to the ATU.
>>
>> Andrew
>>
>>
next prev parent reply other threads:[~2019-10-20 6:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 18:51 [PATCH net-next v4 0/2] mv88e6xxx: Allow config of ATU hash algorithm Andrew Lunn
2019-10-19 18:52 ` [PATCH net-next v4 1/2] net: dsa: Add support for devlink device parameters Andrew Lunn
2019-10-19 19:14 ` Jiri Pirko
2019-10-19 19:20 ` Vivien Didelot
2019-10-19 18:52 ` [PATCH net-next v4 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm Andrew Lunn
2019-10-19 19:16 ` Jiri Pirko
2019-10-19 19:27 ` Andrew Lunn
2019-10-19 21:02 ` Jiri Pirko
2019-10-19 21:12 ` Andrew Lunn
2019-10-20 5:54 ` Jiri Pirko
2019-10-20 6:02 ` Jiri Pirko [this message]
2019-10-20 17:31 ` Andrew Lunn
2019-10-21 7:57 ` Jiri Pirko
2019-10-19 19:20 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191020060246.GP2185@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.