From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
Date: Mon, 21 Oct 2019 05:44:14 +0200 [thread overview]
Message-ID: <20191021034414.GA11888@lst.de> (raw)
In-Reply-To: <20191021034004.11063-2-damien.lemoal@wdc.com>
On Mon, Oct 21, 2019 at 12:40:03PM +0900, Damien Le Moal wrote:
> Rename nvme_block_nr() to nvme_sect_to_lba() and use SECTOR_SHIFT
> instead of its hard coded value 9. Also add a comment to decribe this
> helper.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr()
Date: Mon, 21 Oct 2019 05:44:14 +0200 [thread overview]
Message-ID: <20191021034414.GA11888@lst.de> (raw)
In-Reply-To: <20191021034004.11063-2-damien.lemoal@wdc.com>
On Mon, Oct 21, 2019 at 12:40:03PM +0900, Damien Le Moal wrote:
> Rename nvme_block_nr() to nvme_sect_to_lba() and use SECTOR_SHIFT
> instead of its hard coded value 9. Also add a comment to decribe this
> helper.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-21 3:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 3:40 [PATCH 0/2 v2] Small cleanups Damien Le Moal
2019-10-21 3:40 ` Damien Le Moal
2019-10-21 3:40 ` [PATCH 1/2 v2] nvme: Cleanup and rename nvme_block_nr() Damien Le Moal
2019-10-21 3:40 ` Damien Le Moal
2019-10-21 3:44 ` Christoph Hellwig [this message]
2019-10-21 3:44 ` Christoph Hellwig
2019-10-21 3:44 ` Christoph Hellwig
2019-10-21 3:44 ` Christoph Hellwig
2019-10-21 7:14 ` Johannes Thumshirn
2019-10-21 7:14 ` Johannes Thumshirn
2019-10-21 3:40 ` [PATCH 2/2 v2] nvme: Introduce nvme_lba_to_sect() Damien Le Moal
2019-10-21 3:40 ` Damien Le Moal
2019-10-21 3:44 ` Christoph Hellwig
2019-10-21 3:44 ` Christoph Hellwig
2019-10-21 7:14 ` Johannes Thumshirn
2019-10-21 7:14 ` Johannes Thumshirn
2019-10-21 13:55 ` [PATCH 0/2 v2] Small cleanups Keith Busch
2019-10-21 13:55 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021034414.GA11888@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.