All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Yunfeng Ye <yeyunfeng@huawei.com>
Cc: kstewart@linuxfoundation.org, mark.rutland@arm.com,
	lorenzo.pieralisi@arm.com, hushiyuan@huawei.com,
	catalin.marinas@arm.com, Sudeep Holla <sudeep.holla@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linfeilong@huawei.com, David.Laight@ACULAB.COM,
	gregkh@linuxfoundation.org, tglx@linutronix.de,
	wuyun.wu@huawei.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5] arm64: psci: Reduce the waiting time for cpu_psci_cpu_kill()
Date: Mon, 21 Oct 2019 12:21:14 +0100	[thread overview]
Message-ID: <20191021112114.GC21581@bogus> (raw)
In-Reply-To: <710429cc-4d88-b7c3-b068-5459cf8133b5@huawei.com>

On Mon, Oct 21, 2019 at 06:52:16PM +0800, Yunfeng Ye wrote:
> In cases like suspend-to-disk and suspend-to-ram, a large number of CPU
> cores need to be shut down. At present, the CPU hotplug operation is
> serialised, and the CPU cores can only be shut down one by one. In this
> process, if PSCI affinity_info() does not return LEVEL_OFF quickly,
> cpu_psci_cpu_kill() needs to wait for 10ms. If hundreds of CPU cores
> need to be shut down, it will take a long time.
> 
> Normally, there is no need to wait 10ms in cpu_psci_cpu_kill(). So
> change the wait interval from 10 ms to max 1 ms and use usleep_range()
> instead of msleep() for more accurate timer.
> 
> In addition, reducing the time interval will increase the messages
> output, so remove the "Retry ..." message, instead, track time and
> output to the the successful message.

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Yunfeng Ye <yeyunfeng@huawei.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
	kstewart@linuxfoundation.org, gregkh@linuxfoundation.org,
	lorenzo.pieralisi@arm.com, tglx@linutronix.de,
	David.Laight@ACULAB.COM, mark.rutland@arm.com,
	linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	hushiyuan@huawei.com, wuyun.wu@huawei.com, linfeilong@huawei.com,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v5] arm64: psci: Reduce the waiting time for cpu_psci_cpu_kill()
Date: Mon, 21 Oct 2019 12:21:14 +0100	[thread overview]
Message-ID: <20191021112114.GC21581@bogus> (raw)
In-Reply-To: <710429cc-4d88-b7c3-b068-5459cf8133b5@huawei.com>

On Mon, Oct 21, 2019 at 06:52:16PM +0800, Yunfeng Ye wrote:
> In cases like suspend-to-disk and suspend-to-ram, a large number of CPU
> cores need to be shut down. At present, the CPU hotplug operation is
> serialised, and the CPU cores can only be shut down one by one. In this
> process, if PSCI affinity_info() does not return LEVEL_OFF quickly,
> cpu_psci_cpu_kill() needs to wait for 10ms. If hundreds of CPU cores
> need to be shut down, it will take a long time.
> 
> Normally, there is no need to wait 10ms in cpu_psci_cpu_kill(). So
> change the wait interval from 10 ms to max 1 ms and use usleep_range()
> instead of msleep() for more accurate timer.
> 
> In addition, reducing the time interval will increase the messages
> output, so remove the "Retry ..." message, instead, track time and
> output to the the successful message.

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>

--
Regards,
Sudeep

  reply	other threads:[~2019-10-21 11:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 10:52 [PATCH v5] arm64: psci: Reduce the waiting time for cpu_psci_cpu_kill() Yunfeng Ye
2019-10-21 10:52 ` Yunfeng Ye
2019-10-21 11:21 ` Sudeep Holla [this message]
2019-10-21 11:21   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021112114.GC21581@bogus \
    --to=sudeep.holla@arm.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hushiyuan@huawei.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linfeilong@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=wuyun.wu@huawei.com \
    --cc=yeyunfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.