* [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
@ 2019-10-21 16:25 Ben Dooks (Codethink)
2019-10-21 16:52 ` Sudeep Holla
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks (Codethink) @ 2019-10-21 16:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks (Codethink), Sudeep Holla, linux-kernel
The parse_acpi_topology() is not declared anywhere which
causes the following sparse warning:
drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
RFC: is this the best place to put it?
Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org
---
include/linux/arch_topology.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
index 42f2b5126094..7ae32900d9a2 100644
--- a/include/linux/arch_topology.h
+++ b/include/linux/arch_topology.h
@@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
void reset_cpu_topology(void);
#endif
+extern int parse_acpi_topology(void);
+
#endif /* _LINUX_ARCH_TOPOLOGY_H_ */
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
2019-10-21 16:25 [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h> Ben Dooks (Codethink)
@ 2019-10-21 16:52 ` Sudeep Holla
2019-10-22 8:42 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Sudeep Holla @ 2019-10-21 16:52 UTC (permalink / raw)
To: Ben Dooks (Codethink); +Cc: linux-kernel, linux-kernel, Sudeep Holla
On Mon, Oct 21, 2019 at 05:25:30PM +0100, Ben Dooks (Codethink) wrote:
> The parse_acpi_topology() is not declared anywhere which
> causes the following sparse warning:
>
> drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
>
> RFC: is this the best place to put it?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: linux-kernel@vger.kernel.org
> ---
> include/linux/arch_topology.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
> index 42f2b5126094..7ae32900d9a2 100644
> --- a/include/linux/arch_topology.h
> +++ b/include/linux/arch_topology.h
> @@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
> void reset_cpu_topology(void);
> #endif
>
> +extern int parse_acpi_topology(void);
> +
Can we drop extern like other declarations here ?
Also move this inside CONFIG_GENERIC_ARCH_TOPOLOGY ?
Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>
2019-10-21 16:52 ` Sudeep Holla
@ 2019-10-22 8:42 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2019-10-22 8:42 UTC (permalink / raw)
To: Sudeep Holla; +Cc: linux-kernel, linux-kernel
On 21/10/2019 17:52, Sudeep Holla wrote:
> On Mon, Oct 21, 2019 at 05:25:30PM +0100, Ben Dooks (Codethink) wrote:
>> The parse_acpi_topology() is not declared anywhere which
>> causes the following sparse warning:
>>
>> drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
>>
>> RFC: is this the best place to put it?
>>
>> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
>> ---
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> include/linux/arch_topology.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
>> index 42f2b5126094..7ae32900d9a2 100644
>> --- a/include/linux/arch_topology.h
>> +++ b/include/linux/arch_topology.h
>> @@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
>> void reset_cpu_topology(void);
>> #endif
>>
>> +extern int parse_acpi_topology(void);
>> +
>
> Can we drop extern like other declarations here ?
> Also move this inside CONFIG_GENERIC_ARCH_TOPOLOGY ?
>
> Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.
Ok, thank you for the input.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-22 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-21 16:25 [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h> Ben Dooks (Codethink)
2019-10-21 16:52 ` Sudeep Holla
2019-10-22 8:42 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.