From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, "Yangtao Li" <tiny.windzz@gmail.com>,
linux-wireless@vger.kernel.org,
"Kefeng Wang" <wangkefeng.wang@huawei.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
letux-kernel@openphoenux.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Petr Mladek" <pmladek@suse.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
kernel@pyra-handheld.com,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"David Sterba" <dsterba@suse.com>,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile
Date: Mon, 21 Oct 2019 10:11:04 -0700 [thread overview]
Message-ID: <20191021171104.GY5610@atomide.com> (raw)
In-Reply-To: <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [191021 17:08]:
>
> > Am 21.10.2019 um 16:30 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > * H. Nikolaus Schaller <hns@goldelico.com> [191019 18:43]:
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -216,7 +216,6 @@ obj-$(CONFIG_MACH_NOKIA_N8X0) += board-n8x0.o
> >>
> >> # Platform specific device init code
> >>
> >> -omap-hsmmc-$(CONFIG_MMC_OMAP_HS) := hsmmc.o
> >> obj-y += $(omap-hsmmc-m) $(omap-hsmmc-y)
> >
> > The related obj-y line can go now too, right?
>
> Yes, I think so. It is a construction that I have never seen before :)
> Therefore I did not recognize that it is related.
>
> > And looks like common.h also has struct omap2_hsmmc_info
> > so maybe check by grepping for hsmmc_info to see it's gone.
>
> Yes, it is just a forward-declaration of the struct name with
> no user anywhere.
>
> Scheduled for v3.
>
> BTW: should this series go through your tree since it is an
> omap machine?
Or MMC tree as that's where the code change really are.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, "Yangtao Li" <tiny.windzz@gmail.com>,
linux-wireless@vger.kernel.org,
"Kefeng Wang" <wangkefeng.wang@huawei.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
letux-kernel@openphoenux.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Petr Mladek" <pmladek@suse.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
kernel@pyra-handheld.com,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"David Sterba" <dsterba@suse.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-omap@vger.kernel.org,
"Allison Randal" <allison@lohutok.net>,
linux-arm-kernel@lists.infradead.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile
Date: Mon, 21 Oct 2019 10:11:04 -0700 [thread overview]
Message-ID: <20191021171104.GY5610@atomide.com> (raw)
In-Reply-To: <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [191021 17:08]:
>
> > Am 21.10.2019 um 16:30 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > * H. Nikolaus Schaller <hns@goldelico.com> [191019 18:43]:
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -216,7 +216,6 @@ obj-$(CONFIG_MACH_NOKIA_N8X0) += board-n8x0.o
> >>
> >> # Platform specific device init code
> >>
> >> -omap-hsmmc-$(CONFIG_MMC_OMAP_HS) := hsmmc.o
> >> obj-y += $(omap-hsmmc-m) $(omap-hsmmc-y)
> >
> > The related obj-y line can go now too, right?
>
> Yes, I think so. It is a construction that I have never seen before :)
> Therefore I did not recognize that it is related.
>
> > And looks like common.h also has struct omap2_hsmmc_info
> > so maybe check by grepping for hsmmc_info to see it's gone.
>
> Yes, it is just a forward-declaration of the struct name with
> no user anywhere.
>
> Scheduled for v3.
>
> BTW: should this series go through your tree since it is an
> omap machine?
Or MMC tree as that's where the code change really are.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Petr Mladek" <pmladek@suse.com>,
"Yangtao Li" <tiny.windzz@gmail.com>,
linux-mmc@vger.kernel.org,
"Kefeng Wang" <wangkefeng.wang@huawei.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
netdev@vger.kernel.org, letux-kernel@openphoenux.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
devicetree@vger.kernel.org,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Alexios Zavras" <alexios.zavras@intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
"David Sterba" <dsterba@suse.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-omap@vger.kernel.org,
"Allison Randal" <allison@lohutok.net>,
linux-arm-kernel@lists.infradead.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
kernel@pyra-handheld.com
Subject: Re: [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile
Date: Mon, 21 Oct 2019 10:11:04 -0700 [thread overview]
Message-ID: <20191021171104.GY5610@atomide.com> (raw)
In-Reply-To: <3FDBE28F-B2C5-4EDE-905C-687F601462B6@goldelico.com>
* H. Nikolaus Schaller <hns@goldelico.com> [191021 17:08]:
>
> > Am 21.10.2019 um 16:30 schrieb Tony Lindgren <tony@atomide.com>:
> >
> > * H. Nikolaus Schaller <hns@goldelico.com> [191019 18:43]:
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -216,7 +216,6 @@ obj-$(CONFIG_MACH_NOKIA_N8X0) += board-n8x0.o
> >>
> >> # Platform specific device init code
> >>
> >> -omap-hsmmc-$(CONFIG_MMC_OMAP_HS) := hsmmc.o
> >> obj-y += $(omap-hsmmc-m) $(omap-hsmmc-y)
> >
> > The related obj-y line can go now too, right?
>
> Yes, I think so. It is a construction that I have never seen before :)
> Therefore I did not recognize that it is related.
>
> > And looks like common.h also has struct omap2_hsmmc_info
> > so maybe check by grepping for hsmmc_info to see it's gone.
>
> Yes, it is just a forward-declaration of the struct name with
> no user anywhere.
>
> Scheduled for v3.
>
> BTW: should this series go through your tree since it is an
> omap machine?
Or MMC tree as that's where the code change really are.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-21 17:11 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 18:41 [PATCH v2 00/11] OpenPandora: make wl1251 connected to mmc3 sdio port of OpenPandora work again H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 01/11] Documentation: dt: wireless: update wl1251 for sdio H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-25 21:13 ` Rob Herring
2019-10-25 21:13 ` Rob Herring
2019-10-25 21:13 ` Rob Herring
2019-10-26 8:24 ` H. Nikolaus Schaller
2019-10-26 8:24 ` H. Nikolaus Schaller
2019-10-26 8:24 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 02/11] net: wireless: ti: wl1251 add device tree support H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 03/11] DTS: ARM: pandora-common: define wl1251 as child node of mmc3 H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-30 16:44 ` Ulf Hansson
2019-10-30 16:44 ` Ulf Hansson
2019-10-30 16:44 ` Ulf Hansson
2019-10-30 17:24 ` H. Nikolaus Schaller
2019-10-30 17:24 ` H. Nikolaus Schaller
2019-10-30 17:24 ` H. Nikolaus Schaller
[not found] ` <D9A82904-35BE-41F2-A308-9A49606428B1-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2019-10-31 16:59 ` Ulf Hansson
2019-10-31 16:59 ` Ulf Hansson
2019-10-31 16:59 ` Ulf Hansson
2019-10-19 18:41 ` [PATCH v2 04/11] mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-30 15:51 ` Ulf Hansson
2019-10-30 15:51 ` Ulf Hansson
2019-10-30 15:51 ` Ulf Hansson
2019-10-30 17:24 ` H. Nikolaus Schaller
2019-10-30 17:24 ` H. Nikolaus Schaller
2019-10-30 17:24 ` H. Nikolaus Schaller
2019-10-31 16:23 ` Ulf Hansson
2019-10-31 16:23 ` Ulf Hansson
2019-10-31 16:23 ` Ulf Hansson
2019-10-19 18:41 ` [PATCH v2 05/11] omap: pdata-quirks: revert pandora specific gpiod additions H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 06/11] omap: pdata-quirks: remove openpandora quirks for mmc3 and wl1251 H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 07/11] omap: remove old hsmmc.[ch] and in Makefile H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
[not found] ` <9bd4c0bb0df26523d7f5265cdb06d86d63dafba8.1571510481.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2019-10-21 14:30 ` Tony Lindgren
2019-10-21 14:30 ` Tony Lindgren
2019-10-21 14:30 ` Tony Lindgren
2019-10-21 17:07 ` H. Nikolaus Schaller
2019-10-21 17:07 ` H. Nikolaus Schaller
2019-10-21 17:07 ` H. Nikolaus Schaller
2019-10-21 17:11 ` Tony Lindgren [this message]
2019-10-21 17:11 ` Tony Lindgren
2019-10-21 17:11 ` Tony Lindgren
[not found] ` <20191021171104.GY5610-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2019-10-22 6:58 ` Ulf Hansson
2019-10-22 6:58 ` Ulf Hansson
2019-10-22 6:58 ` Ulf Hansson
2019-10-19 18:41 ` [PATCH v2 08/11] mmc: sdio: fix wl1251 vendor id H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 09/11] mmc: core: fix wl1251 sdio quirks H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 10/11] net: wireless: ti: wl1251 use new SDIO_VENDOR_ID_TI_WL1251 definition H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` [PATCH v2 11/11] net: wireless: ti: remove local VENDOR_ID and DEVICE_ID definitions H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
2019-10-19 18:41 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021171104.GY5610@atomide.com \
--to=tony@atomide.com \
--cc=alexios.zavras@intel.com \
--cc=bcousson@baylibre.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dsterba@suse.com \
--cc=hns@goldelico.com \
--cc=john.stultz@linaro.org \
--cc=kernel@pyra-handheld.com \
--cc=kvalo@codeaurora.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pmladek@suse.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tiny.windzz@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.