From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8
Date: Mon, 21 Oct 2019 20:56:09 +0200 [thread overview]
Message-ID: <20191021205609.57122e8c@windsurf> (raw)
In-Reply-To: <20191020193818.85518-1-james.hilliard1@gmail.com>
On Sun, 20 Oct 2019 13:38:18 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.net/results/71bf937339705a520e047d12c146229ec42a76f2
>
> Details:
> - https://bugs.python.org/issue36721
Reading this, I am not sure your fix is correct (though I am not sure
what the correct fix is).
Indeed, in this bug report, Victor Stinner explains:
"""
There are two use cases for libpython:
* Build a C extension and load it in Python: use case called "pyext" by waf
* Embed Python into an application: use case called "pyembed" by waf
"""
The first case should not require -lpython3.8, and therefore
python-config no longer returns -lpython3.8, unless you pass --embed
(which means you are in the second case: you embed Python into an
application).
But kmod is only providing Python bindings: it's a C extension to be
loaded in Python, so we are in the first case, and we shouldn't need
--embed.
What do you think ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-21 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 19:38 [Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8 James Hilliard
2019-10-21 18:56 ` Thomas Petazzoni [this message]
2019-10-21 19:12 ` James Hilliard
2019-10-21 19:23 ` Thomas Petazzoni
2019-10-22 9:02 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2019-11-16 11:45 Fabrice Fontaine
2019-11-16 16:23 ` Yann E. MORIN
2019-11-16 16:35 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021205609.57122e8c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.