From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8
Date: Sat, 16 Nov 2019 17:35:38 +0100 [thread overview]
Message-ID: <20191116163538.GE32494@scaer> (raw)
In-Reply-To: <20191116162307.GD32494@scaer>
Fabrice, All,
On 2019-11-16 17:23 +0100, Yann E. MORIN spake thusly:
> On 2019-11-16 12:45 +0100, Fabrice Fontaine spake thusly:
> > Replace second patch that adds -Wl,-z,undefs by a patch that remove
> > -Wl,--no-undefined as some ld versions are ignoring this flag:
[--SNIP--]
> > -diff --git a/Makefile.am b/Makefile.am
> > -index c5c2f06..8e9c90d 100644
> > ---- a/Makefile.am
> > -+++ b/Makefile.am
> > -@@ -173,7 +173,7 @@ CPYTHON_MODULE_CFLAGS = \
> > - $(AM_CFLAGS) -DCPYTHON_COMPILING_IN_PYPY=0 \
> > - $(PYTHON_NOWARN) $(PYTHON_CFLAGS) \
> > - -fvisibility=default
> > --CPYTHON_MODULE_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version -shared
> > -+CPYTHON_MODULE_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version -shared -Wl,-z,undefs
>
> What about this hack:
>
> CPYTHON_MODULE_LDFLAGS = (subst -Wl,--no-undefined,,$(AM_LDFLAGS)) ...
Does not work because of commas. The good hack would be:
comma = ,
CPYTHON_MODULE_LDFLAGS = (subst -Wl$(comma)--no-undefined,,$(AM_LDFLAGS)) ...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-11-16 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 11:45 [Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8 Fabrice Fontaine
2019-11-16 16:23 ` Yann E. MORIN
2019-11-16 16:35 ` Yann E. MORIN [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-20 19:38 James Hilliard
2019-10-21 18:56 ` Thomas Petazzoni
2019-10-21 19:12 ` James Hilliard
2019-10-21 19:23 ` Thomas Petazzoni
2019-10-22 9:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116163538.GE32494@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.