From: Nick Hu <nickhu@andestech.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
<alankao@andestech.com>, <palmer@sifive.com>,
<aou@eecs.berkeley.edu>, <glider@google.com>,
<dvyukov@google.com>, <corbet@lwn.net>,
<alexios.zavras@intel.com>, <allison@lohutok.net>,
<Anup.Patel@wdc.com>, <tglx@linutronix.de>,
<gregkh@linuxfoundation.org>, <atish.patra@wdc.com>,
<kstewart@linuxfoundation.org>, <linux-doc@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<kasan-dev@googlegroups.com>, <linux-mm@kvack.org>
Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.
Date: Tue, 22 Oct 2019 10:09:00 +0800 [thread overview]
Message-ID: <20191022020900.GA29285@andestech.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1910171957310.3156@viisi.sifive.com>
On Thu, Oct 17, 2019 at 07:58:04PM -0700, Paul Walmsley wrote:
> On Thu, 17 Oct 2019, Andrey Ryabinin wrote:
>
> > On 10/8/19 9:11 AM, Nick Hu wrote:
> > > Skip the memmove checking for those archs who don't support it.
> >
> > The patch is fine but the changelog sounds misleading. We don't skip memmove checking.
> > If arch don't have memmove than the C implementation from lib/string.c used.
> > It's instrumented by compiler so it's checked and we simply don't need that KASAN's memmove with
> > manual checks.
>
> Thanks Andrey. Nick, could you please update the patch description?
>
> - Paul
>
Thanks! I would update the description in v4 patch.
Nick
WARNING: multiple messages have this Message-ID (diff)
From: Nick Hu <nickhu@andestech.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: kstewart@linuxfoundation.org, aou@eecs.berkeley.edu,
alankao@andestech.com, corbet@lwn.net,
gregkh@linuxfoundation.org, palmer@sifive.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
alexios.zavras@intel.com, Anup.Patel@wdc.com, glider@google.com,
allison@lohutok.net, Andrey Ryabinin <aryabinin@virtuozzo.com>,
tglx@linutronix.de, atish.patra@wdc.com,
linux-riscv@lists.infradead.org, dvyukov@google.com
Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.
Date: Tue, 22 Oct 2019 10:09:00 +0800 [thread overview]
Message-ID: <20191022020900.GA29285@andestech.com> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1910171957310.3156@viisi.sifive.com>
On Thu, Oct 17, 2019 at 07:58:04PM -0700, Paul Walmsley wrote:
> On Thu, 17 Oct 2019, Andrey Ryabinin wrote:
>
> > On 10/8/19 9:11 AM, Nick Hu wrote:
> > > Skip the memmove checking for those archs who don't support it.
> >
> > The patch is fine but the changelog sounds misleading. We don't skip memmove checking.
> > If arch don't have memmove than the C implementation from lib/string.c used.
> > It's instrumented by compiler so it's checked and we simply don't need that KASAN's memmove with
> > manual checks.
>
> Thanks Andrey. Nick, could you please update the patch description?
>
> - Paul
>
Thanks! I would update the description in v4 patch.
Nick
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-22 2:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 6:11 [PATCH v3 0/3] KASAN support for RISC-V Nick Hu
2019-10-08 6:11 ` Nick Hu
2019-10-08 6:11 ` [PATCH v3 1/3] kasan: Archs don't check memmove if not support it Nick Hu
2019-10-08 6:11 ` Nick Hu
2019-10-16 19:23 ` Palmer Dabbelt
2019-10-16 19:23 ` Palmer Dabbelt
2019-10-17 10:39 ` Andrey Ryabinin
2019-10-17 10:39 ` Andrey Ryabinin
2019-10-18 2:58 ` Paul Walmsley
2019-10-18 2:58 ` Paul Walmsley
2019-10-22 2:09 ` Nick Hu [this message]
2019-10-22 2:09 ` Nick Hu
2019-10-08 6:11 ` [PATCH v3 2/3] riscv: Add KASAN support Nick Hu
2019-10-08 6:11 ` Nick Hu
2019-10-21 9:33 ` Greentime Hu
2019-10-21 9:33 ` Greentime Hu
2019-10-22 3:30 ` Nick Hu
2019-10-22 3:30 ` Nick Hu
2019-10-08 6:11 ` [PATCH v3 3/3] kasan: Add riscv to KASAN documentation Nick Hu
2019-10-08 6:11 ` Nick Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022020900.GA29285@andestech.com \
--to=nickhu@andestech.com \
--cc=Anup.Patel@wdc.com \
--cc=alankao@andestech.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=aou@eecs.berkeley.edu \
--cc=aryabinin@virtuozzo.com \
--cc=atish.patra@wdc.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kasan-dev@googlegroups.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.