From: Wolfram Sang <wsa@the-dreams.de>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH i2c-next 1/2] dt-bindings: i2c: aspeed: add hardware timeout support
Date: Tue, 22 Oct 2019 06:56:56 +0200 [thread overview]
Message-ID: <20191022045655.GA975@kunai> (raw)
In-Reply-To: <7abf933b-cb18-10af-9c1b-163ec65ffae5@linux.intel.com>
> Changes I submitted in this patch set is for a different purpose which
> is very Aspeed H/W specific, and actually it's a more serious timeout
> setting indeed. If this H/W is used in multi-master environment, it
> could meet a H/W hang that freezes itself in slave mode and it can't
> escape from the state. To resolve the specific case, this H/W provides
> self-recovery feature which monitors abnormal state of SDA, SCL and its
> H/W state machine using the timeout setting to determine the escape
> condition.
Thanks for the summary. I just wonder on what the timeout value depends.
Do we really need to put in DT or can we derive it e.g. from the
compatible value in the driver?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20191022/ea051ffb/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Brendan Higgins <brendanhiggins@google.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Tao Ren <taoren@fb.com>, Peter Rosin <peda@axentia.se>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Cedric Le Goater <clg@kaod.org>
Subject: Re: [PATCH i2c-next 1/2] dt-bindings: i2c: aspeed: add hardware timeout support
Date: Tue, 22 Oct 2019 06:56:56 +0200 [thread overview]
Message-ID: <20191022045655.GA975@kunai> (raw)
In-Reply-To: <7abf933b-cb18-10af-9c1b-163ec65ffae5@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 689 bytes --]
> Changes I submitted in this patch set is for a different purpose which
> is very Aspeed H/W specific, and actually it's a more serious timeout
> setting indeed. If this H/W is used in multi-master environment, it
> could meet a H/W hang that freezes itself in slave mode and it can't
> escape from the state. To resolve the specific case, this H/W provides
> self-recovery feature which monitors abnormal state of SDA, SCL and its
> H/W state machine using the timeout setting to determine the escape
> condition.
Thanks for the summary. I just wonder on what the timeout value depends.
Do we really need to put in DT or can we derive it e.g. from the
compatible value in the driver?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Peter Rosin <peda@axentia.se>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Jeffery <andrew@aj.id.au>, Tao Ren <taoren@fb.com>,
Cedric Le Goater <clg@kaod.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH i2c-next 1/2] dt-bindings: i2c: aspeed: add hardware timeout support
Date: Tue, 22 Oct 2019 06:56:56 +0200 [thread overview]
Message-ID: <20191022045655.GA975@kunai> (raw)
In-Reply-To: <7abf933b-cb18-10af-9c1b-163ec65ffae5@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
> Changes I submitted in this patch set is for a different purpose which
> is very Aspeed H/W specific, and actually it's a more serious timeout
> setting indeed. If this H/W is used in multi-master environment, it
> could meet a H/W hang that freezes itself in slave mode and it can't
> escape from the state. To resolve the specific case, this H/W provides
> self-recovery feature which monitors abnormal state of SDA, SCL and its
> H/W state machine using the timeout setting to determine the escape
> condition.
Thanks for the summary. I just wonder on what the timeout value depends.
Do we really need to put in DT or can we derive it e.g. from the
compatible value in the driver?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-22 4:56 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 20:24 [PATCH i2c-next 0/2] i2c: aspeed: Add H/W timeout support Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` [PATCH i2c-next 1/2] dt-bindings: i2c: aspeed: add hardware " Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 21:05 ` Peter Rosin
2019-10-21 21:05 ` Peter Rosin
2019-10-21 21:05 ` Peter Rosin
2019-10-21 21:05 ` Peter Rosin
2019-10-21 21:57 ` Jae Hyun Yoo
2019-10-21 21:57 ` Jae Hyun Yoo
2019-10-21 21:57 ` Jae Hyun Yoo
2019-10-21 21:57 ` Jae Hyun Yoo
2019-10-22 4:56 ` Wolfram Sang [this message]
2019-10-22 4:56 ` Wolfram Sang
2019-10-22 4:56 ` Wolfram Sang
2019-10-22 17:09 ` Jae Hyun Yoo
2019-10-22 17:09 ` Jae Hyun Yoo
2019-10-22 17:09 ` Jae Hyun Yoo
2019-10-22 17:09 ` Jae Hyun Yoo
2019-10-22 8:45 ` Peter Rosin
2019-10-22 8:45 ` Peter Rosin
2019-10-22 8:45 ` Peter Rosin
2019-10-22 8:45 ` Peter Rosin
2019-10-22 17:44 ` Jae Hyun Yoo
2019-10-22 17:44 ` Jae Hyun Yoo
2019-10-22 17:44 ` Jae Hyun Yoo
2019-10-22 17:44 ` Jae Hyun Yoo
2019-10-23 21:17 ` Peter Rosin
2019-10-23 21:17 ` Peter Rosin
2019-10-23 21:17 ` Peter Rosin
2019-10-23 21:17 ` Peter Rosin
2019-10-23 22:09 ` Tao Ren
2019-10-23 22:09 ` Tao Ren
2019-10-23 22:09 ` Tao Ren
2019-10-23 22:09 ` Tao Ren
2019-10-24 0:09 ` Brendan Higgins
2019-10-24 0:09 ` Brendan Higgins
2019-10-24 0:09 ` Brendan Higgins
2019-10-24 0:09 ` Brendan Higgins
2019-10-24 17:27 ` Jae Hyun Yoo
2019-10-24 17:27 ` Jae Hyun Yoo
2019-10-24 17:27 ` Jae Hyun Yoo
2019-10-24 17:27 ` Jae Hyun Yoo
2019-10-21 20:24 ` [PATCH i2c-next 2/2] i2c: aspeed: add slave inactive " Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
2019-10-21 20:24 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022045655.GA975@kunai \
--to=wsa@the-dreams.de \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.