From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Andrew Jones <drjones@redhat.com>,
qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: [PULL 1/9] s390x/cpumodel: Add missing visit_free
Date: Tue, 22 Oct 2019 11:54:20 +0200 [thread overview]
Message-ID: <20191022095428.20780-2-cohuck@redhat.com> (raw)
In-Reply-To: <20191022095428.20780-1-cohuck@redhat.com>
From: Andrew Jones <drjones@redhat.com>
Beata Michalska noticed this missing visit_free() while reviewing
arm's implementation of qmp_query_cpu_model_expansion(), which is
modeled off this s390x implementation.
Signed-off-by: Andrew Jones <drjones@redhat.com>
Message-Id: <20191016145434.7007-1-drjones@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
target/s390x/cpu_models.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 009afc38b92d..7e92fb2e156d 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
visitor = qobject_input_visitor_new(info->props);
visit_start_struct(visitor, NULL, NULL, 0, errp);
if (*errp) {
+ visit_free(visitor);
object_unref(obj);
return;
}
--
2.21.0
next prev parent reply other threads:[~2019-10-22 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 9:54 [PULL 0/9] more s390x fixes Cornelia Huck
2019-10-22 9:54 ` Cornelia Huck [this message]
2019-10-22 9:54 ` [PULL 2/9] s390x/mmu: Remove duplicate check for MMU_DATA_STORE Cornelia Huck
2019-10-22 9:54 ` [PULL 3/9] s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD Cornelia Huck
2019-10-22 9:54 ` [PULL 4/9] s390x/tcg: Fix VECTOR MULTIPLY AND ADD * Cornelia Huck
2019-10-22 9:54 ` [PULL 5/9] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE Cornelia Huck
2019-10-22 9:54 ` [PULL 6/9] s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION Cornelia Huck
2019-10-22 9:54 ` [PULL 7/9] s390x/tcg: Fix VECTOR SUBTRACT WITH " Cornelia Huck
2019-10-22 9:54 ` [PULL 8/9] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE " Cornelia Huck
2019-10-22 9:54 ` [PULL 9/9] s390x/kvm: Set default cpu model for all machine classes Cornelia Huck
2019-10-22 13:52 ` [PULL 0/9] more s390x fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022095428.20780-2-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.