From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, David Hildenbrand <david@redhat.com>
Subject: [PULL 2/9] s390x/mmu: Remove duplicate check for MMU_DATA_STORE
Date: Tue, 22 Oct 2019 11:54:21 +0200 [thread overview]
Message-ID: <20191022095428.20780-3-cohuck@redhat.com> (raw)
In-Reply-To: <20191022095428.20780-1-cohuck@redhat.com>
From: David Hildenbrand <david@redhat.com>
No need to double-check if we have a write.
Found by Coverity (CID: 1406404).
Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_real")
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191017121922.18840-1-david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
target/s390x/mmu_helper.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c
index 90b81335f920..c9f3f3475010 100644
--- a/target/s390x/mmu_helper.c
+++ b/target/s390x/mmu_helper.c
@@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw,
*flags |= PAGE_WRITE_INV;
if (is_low_address(raddr) && rw == MMU_DATA_STORE) {
/* LAP sets bit 56 */
- *tec = (raddr & TARGET_PAGE_MASK)
- | (rw == MMU_DATA_STORE ? FS_WRITE : FS_READ)
- | 0x80;
+ *tec = (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80;
return PGM_PROTECTION;
}
}
--
2.21.0
next prev parent reply other threads:[~2019-10-22 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 9:54 [PULL 0/9] more s390x fixes Cornelia Huck
2019-10-22 9:54 ` [PULL 1/9] s390x/cpumodel: Add missing visit_free Cornelia Huck
2019-10-22 9:54 ` Cornelia Huck [this message]
2019-10-22 9:54 ` [PULL 3/9] s390x/tcg: Fix VECTOR MULTIPLY LOGICAL ODD Cornelia Huck
2019-10-22 9:54 ` [PULL 4/9] s390x/tcg: Fix VECTOR MULTIPLY AND ADD * Cornelia Huck
2019-10-22 9:54 ` [PULL 5/9] s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE Cornelia Huck
2019-10-22 9:54 ` [PULL 6/9] s390x/tcg: Fix VECTOR SUBTRACT COMPUTE BORROW INDICATION Cornelia Huck
2019-10-22 9:54 ` [PULL 7/9] s390x/tcg: Fix VECTOR SUBTRACT WITH " Cornelia Huck
2019-10-22 9:54 ` [PULL 8/9] s390x/tcg: Fix VECTOR SUBTRACT WITH BORROW COMPUTE " Cornelia Huck
2019-10-22 9:54 ` [PULL 9/9] s390x/kvm: Set default cpu model for all machine classes Cornelia Huck
2019-10-22 13:52 ` [PULL 0/9] more s390x fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022095428.20780-3-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.