All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com,
	x86@kernel.org, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, dhowells@redhat.com,
	mingo@redhat.com, ebiederm@xmission.com, hpa@zytor.com,
	tglx@linutronix.de, dyoung@redhat.com, vgoyal@redhat.com
Subject: Re: [PATCH 3/3 v4] x86/kdump: clean up all the code related to the backup region
Date: Tue, 22 Oct 2019 14:15:41 +0200	[thread overview]
Message-ID: <20191022121541.GC31700@zn.tnic> (raw)
In-Reply-To: <20191017094347.20327-4-lijiang@redhat.com>

On Thu, Oct 17, 2019 at 05:43:47PM +0800, Lianbo Jiang wrote:
> When the crashkernel kernel command line option is specified, the
> low 1MiB memory will always be reserved, which makes that the memory
> allocated later won't fall into the low 1MiB area, thereby, it's not
> necessary to create a backup region and also no need to copy the first
> 640k content to a backup region.
> 
> Currently, the code related to the backup region can be safely removed,
> so lets clean up.
> 
> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
> ---
>  arch/x86/include/asm/kexec.h       | 10 ----
>  arch/x86/include/asm/purgatory.h   | 10 ----
>  arch/x86/kernel/crash.c            | 87 ++++--------------------------
>  arch/x86/kernel/machine_kexec_64.c | 47 ----------------
>  arch/x86/purgatory/purgatory.c     | 19 -------
>  5 files changed, 11 insertions(+), 162 deletions(-)

That's a diffstat one cannot object to nowadays. :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Lianbo Jiang <lijiang@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bhe@redhat.com,
	dyoung@redhat.com, jgross@suse.com, dhowells@redhat.com,
	Thomas.Lendacky@amd.com, ebiederm@xmission.com,
	vgoyal@redhat.com, kexec@lists.infradead.org
Subject: Re: [PATCH 3/3 v4] x86/kdump: clean up all the code related to the backup region
Date: Tue, 22 Oct 2019 14:15:41 +0200	[thread overview]
Message-ID: <20191022121541.GC31700@zn.tnic> (raw)
In-Reply-To: <20191017094347.20327-4-lijiang@redhat.com>

On Thu, Oct 17, 2019 at 05:43:47PM +0800, Lianbo Jiang wrote:
> When the crashkernel kernel command line option is specified, the
> low 1MiB memory will always be reserved, which makes that the memory
> allocated later won't fall into the low 1MiB area, thereby, it's not
> necessary to create a backup region and also no need to copy the first
> 640k content to a backup region.
> 
> Currently, the code related to the backup region can be safely removed,
> so lets clean up.
> 
> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
> ---
>  arch/x86/include/asm/kexec.h       | 10 ----
>  arch/x86/include/asm/purgatory.h   | 10 ----
>  arch/x86/kernel/crash.c            | 87 ++++--------------------------
>  arch/x86/kernel/machine_kexec_64.c | 47 ----------------
>  arch/x86/purgatory/purgatory.c     | 19 -------
>  5 files changed, 11 insertions(+), 162 deletions(-)

That's a diffstat one cannot object to nowadays. :)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2019-10-22 12:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17  9:43 [PATCH 0/3 v4] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Lianbo Jiang
2019-10-17  9:43 ` Lianbo Jiang
2019-10-17  9:43 ` [PATCH 1/3 v4] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified Lianbo Jiang
2019-10-17  9:43   ` Lianbo Jiang
2019-10-22  8:30   ` Borislav Petkov
2019-10-22  8:30     ` Borislav Petkov
2019-10-23  5:23     ` lijiang
2019-10-23  5:23       ` lijiang
2019-10-23  7:43       ` Borislav Petkov
2019-10-23  7:43         ` Borislav Petkov
2019-10-23  5:35     ` lijiang
2019-10-23  5:35       ` lijiang
2019-10-23  7:46       ` Borislav Petkov
2019-10-23  7:46         ` Borislav Petkov
2019-10-23  9:20         ` lijiang
2019-10-23  9:20           ` lijiang
2019-10-24  8:13       ` d.hatayama
2019-10-24  8:13         ` d.hatayama
2019-10-24  9:10         ` Borislav Petkov
2019-10-24  9:10           ` Borislav Petkov
2019-10-24 11:24         ` lijiang
2019-10-24 11:24           ` lijiang
2019-10-24 22:12       ` [PATCH] x86/kdump: always reserve the low 1MiB when the crashkernel kbuild test robot
2019-10-24 22:12         ` kbuild test robot
2019-10-24 22:12         ` kbuild test robot
2019-10-24 23:55         ` lijiang
2019-10-24 23:55           ` lijiang
2019-10-24 23:55           ` lijiang
2019-10-17  9:43 ` [PATCH 2/3 v4] x86/kdump: remove the unused crash_copy_backup_region() Lianbo Jiang
2019-10-17  9:43   ` Lianbo Jiang
2019-10-17  9:43 ` [PATCH 3/3 v4] x86/kdump: clean up all the code related to the backup region Lianbo Jiang
2019-10-17  9:43   ` Lianbo Jiang
2019-10-22 12:15   ` Borislav Petkov [this message]
2019-10-22 12:15     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191022121541.GC31700@zn.tnic \
    --to=bp@alien8.de \
    --cc=Thomas.Lendacky@amd.com \
    --cc=bhe@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=kexec@lists.infradead.org \
    --cc=lijiang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vgoyal@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.