From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] timer_create01: accept kernel ENOTSUPP
Date: Wed, 23 Oct 2019 11:04:09 -0300 [thread overview]
Message-ID: <20191023140408.GC4055@calabresa> (raw)
In-Reply-To: <1714198769.8739783.1571839133168.JavaMail.zimbra@redhat.com>
On Wed, Oct 23, 2019 at 09:58:53AM -0400, Jan Stancek wrote:
>
>
> ----- Original Message -----
> > ENOTSUP in userspace is alias for EOPNOTSUPP, so the test still fails.
> > Add definition of kernel's ENOTSUPP and use that.
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
> I think I misread the original commit. Seems we want this to fail for ENOTSUPP.
>
You are right. We want this to succeed with EOPNOTSUPP, as it's a valid error
from kernel space.
However, we don't want to validate kernels that wrongly return ENOTSUPP, as
it's not a valid userspace errno. Any kernel code that exposes ENOTSUPP to
userspace is buggy and should be fixed. So, in fact, we would like to flag such
return values as failures/kernel bugs.
Cascardo.
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2019-10-23 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:56 [LTP] [PATCH] timer_create01: accept kernel ENOTSUPP Jan Stancek
2019-10-23 13:58 ` Jan Stancek
2019-10-23 14:03 ` Cyril Hrubis
2019-10-23 14:04 ` Thadeu Lima de Souza Cascardo [this message]
2019-10-23 14:29 ` Martin Doucha
2019-10-23 14:35 ` Cyril Hrubis
2019-10-23 14:56 ` Thadeu Lima de Souza Cascardo
2019-10-23 15:36 ` Cyril Hrubis
2019-10-23 15:38 ` Cyril Hrubis
2019-10-23 17:50 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023140408.GC4055@calabresa \
--to=cascardo@canonical.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.