From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] timer_create01: accept kernel ENOTSUPP
Date: Wed, 23 Oct 2019 16:35:11 +0200 [thread overview]
Message-ID: <20191023143510.GA10116@rei> (raw)
In-Reply-To: <6089b924-8dbe-c43d-72d9-a4086a13b0d5@suse.cz>
Hi!
> > You are right. We want this to succeed with EOPNOTSUPP, as it's a valid error
> > from kernel space.
>
> Actually, man says that EOPNOTSUPP is only valid for socket operations.
> So no, we should not go out of our way to explicitly check timer errors
> against EOPNOTSUPP either. (It's also a waste of time because on Linux,
> ENOTSUP == EOPNOTSUPP).
Beware that kernel defines ENOTSUP that is not equal to EOPNOTSUPP and
in this case this value leaked to userspace leading to invalid userspace
errno value.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-10-23 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 13:56 [LTP] [PATCH] timer_create01: accept kernel ENOTSUPP Jan Stancek
2019-10-23 13:58 ` Jan Stancek
2019-10-23 14:03 ` Cyril Hrubis
2019-10-23 14:04 ` Thadeu Lima de Souza Cascardo
2019-10-23 14:29 ` Martin Doucha
2019-10-23 14:35 ` Cyril Hrubis [this message]
2019-10-23 14:56 ` Thadeu Lima de Souza Cascardo
2019-10-23 15:36 ` Cyril Hrubis
2019-10-23 15:38 ` Cyril Hrubis
2019-10-23 17:50 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023143510.GA10116@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.