* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-11 1:58 ` Jun Li
0 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-11 1:58 UTC (permalink / raw)
To: Tim
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Neil Armstrong, Dongjin Kim, linux-amlogic,
Rob Herring, linux-arm-kernel
Hi Neil
As I got the information from Synopsys, this bug exists on current IP versions,
and per my tests with external USB3 hub + 2 Super speed udisks on data
read by dd, I can reproduce this issue with different kernel versions, also I
didn't see obvious performance drop by dd tests after disable park mode for
super speed, so should we just disable it by default so no need a quirk?
Li Jun
Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>
> Thanks for working on this Neil,
> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> As previously mentioned the patch set fixes the issue on affected hardware;
> https://patchwork.kernel.org/patch/11164515/
>
>
>
> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > This patch updates the documentation with the information related
> > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > instances in park mode.
> > >
> > > CC: Dongjin Kim <tobetter@gmail.com>
> > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > Reported-by: Tim <elatllat@gmail.com>
> > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > ---
> > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > Sigh, what's one more to the never ending list of quirks...
> >
> > Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-11 1:58 ` Jun Li
0 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-11 1:58 UTC (permalink / raw)
To: Tim
Cc: Neil Armstrong, Felipe Balbi, khilman, devicetree, linux-usb,
linux-amlogic, linux-arm-kernel, linux-kernel, Dongjin Kim,
Jianxin Pan, Rob Herring
Hi Neil
As I got the information from Synopsys, this bug exists on current IP versions,
and per my tests with external USB3 hub + 2 Super speed udisks on data
read by dd, I can reproduce this issue with different kernel versions, also I
didn't see obvious performance drop by dd tests after disable park mode for
super speed, so should we just disable it by default so no need a quirk?
Li Jun
Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>
> Thanks for working on this Neil,
> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> As previously mentioned the patch set fixes the issue on affected hardware;
> https://patchwork.kernel.org/patch/11164515/
>
>
>
> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > This patch updates the documentation with the information related
> > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > instances in park mode.
> > >
> > > CC: Dongjin Kim <tobetter@gmail.com>
> > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > Reported-by: Tim <elatllat@gmail.com>
> > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > ---
> > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > Sigh, what's one more to the never ending list of quirks...
> >
> > Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-11-11 1:58 ` Jun Li
(?)
@ 2019-11-11 14:05 ` Tim
-1 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-11-11 14:05 UTC (permalink / raw)
To: Jun Li
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Neil Armstrong, Dongjin Kim, linux-amlogic,
Rob Herring, linux-arm-kernel
Speculation;
Maybe the kernel maintainers prefer to optimistically permit future
products to easily remove workarounds via quirk flags.
Even if data from testing were shown, and it did not impact
performance, code reduction and clarity are desirable.
On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
>
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >
> > Thanks for working on this Neil,
> > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > As previously mentioned the patch set fixes the issue on affected hardware;
> > https://patchwork.kernel.org/patch/11164515/
> >
> >
> >
> > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > This patch updates the documentation with the information related
> > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > instances in park mode.
> > > >
> > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > Reported-by: Tim <elatllat@gmail.com>
> > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > >
> > > Sigh, what's one more to the never ending list of quirks...
> > >
> > > Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-11 14:05 ` Tim
0 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-11-11 14:05 UTC (permalink / raw)
To: Jun Li
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Neil Armstrong, Dongjin Kim, linux-amlogic,
Rob Herring, linux-arm-kernel
Speculation;
Maybe the kernel maintainers prefer to optimistically permit future
products to easily remove workarounds via quirk flags.
Even if data from testing were shown, and it did not impact
performance, code reduction and clarity are desirable.
On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
>
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >
> > Thanks for working on this Neil,
> > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > As previously mentioned the patch set fixes the issue on affected hardware;
> > https://patchwork.kernel.org/patch/11164515/
> >
> >
> >
> > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > This patch updates the documentation with the information related
> > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > instances in park mode.
> > > >
> > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > Reported-by: Tim <elatllat@gmail.com>
> > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > >
> > > Sigh, what's one more to the never ending list of quirks...
> > >
> > > Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-11 14:05 ` Tim
0 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-11-11 14:05 UTC (permalink / raw)
To: Jun Li
Cc: Neil Armstrong, Felipe Balbi, khilman, devicetree, linux-usb,
linux-amlogic, linux-arm-kernel, linux-kernel, Dongjin Kim,
Jianxin Pan, Rob Herring
Speculation;
Maybe the kernel maintainers prefer to optimistically permit future
products to easily remove workarounds via quirk flags.
Even if data from testing were shown, and it did not impact
performance, code reduction and clarity are desirable.
On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
>
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >
> > Thanks for working on this Neil,
> > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > As previously mentioned the patch set fixes the issue on affected hardware;
> > https://patchwork.kernel.org/patch/11164515/
> >
> >
> >
> > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > This patch updates the documentation with the information related
> > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > instances in park mode.
> > > >
> > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > Reported-by: Tim <elatllat@gmail.com>
> > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > ---
> > > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > >
> > > Sigh, what's one more to the never ending list of quirks...
> > >
> > > Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-11-11 14:05 ` Tim
(?)
@ 2019-11-12 1:48 ` Jun Li
-1 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-12 1:48 UTC (permalink / raw)
To: Tim
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Neil Armstrong, Dongjin Kim, linux-amlogic,
Rob Herring, linux-arm-kernel
by a quirk, those platforms without this quirk can't benefit this fix.
if later this bug is fixed by some reversion of dwc3 IP, we can easily
remove the workaround by a IP version check:
if (dwc->revision < DWC3_REVISION_PARK_MODE_FIXED)
{
disable park mode for ss;
}
Li Jun
Tim <elatllat@gmail.com> 于2019年11月11日周一 下午10:05写道：
>
> Speculation;
>
> Maybe the kernel maintainers prefer to optimistically permit future
> products to easily remove workarounds via quirk flags.
> Even if data from testing were shown, and it did not impact
> performance, code reduction and clarity are desirable.
>
> On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
> >
> > Hi Neil
> >
> > As I got the information from Synopsys, this bug exists on current IP versions,
> > and per my tests with external USB3 hub + 2 Super speed udisks on data
> > read by dd, I can reproduce this issue with different kernel versions, also I
> > didn't see obvious performance drop by dd tests after disable park mode for
> > super speed, so should we just disable it by default so no need a quirk?
> >
> > Li Jun
> >
> > Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> > >
> > > Thanks for working on this Neil,
> > > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > > As previously mentioned the patch set fixes the issue on affected hardware;
> > > https://patchwork.kernel.org/patch/11164515/
> > >
> > >
> > >
> > > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > > >
> > > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > > This patch updates the documentation with the information related
> > > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > > instances in park mode.
> > > > >
> > > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > > Reported-by: Tim <elatllat@gmail.com>
> > > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > >
> > > > Sigh, what's one more to the never ending list of quirks...
> > > >
> > > > Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 1:48 ` Jun Li
0 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-12 1:48 UTC (permalink / raw)
To: Tim
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Neil Armstrong, Dongjin Kim, linux-amlogic,
Rob Herring, linux-arm-kernel
by a quirk, those platforms without this quirk can't benefit this fix.
if later this bug is fixed by some reversion of dwc3 IP, we can easily
remove the workaround by a IP version check:
if (dwc->revision < DWC3_REVISION_PARK_MODE_FIXED)
{
disable park mode for ss;
}
Li Jun
Tim <elatllat@gmail.com> 于2019年11月11日周一 下午10:05写道：
>
> Speculation;
>
> Maybe the kernel maintainers prefer to optimistically permit future
> products to easily remove workarounds via quirk flags.
> Even if data from testing were shown, and it did not impact
> performance, code reduction and clarity are desirable.
>
> On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
> >
> > Hi Neil
> >
> > As I got the information from Synopsys, this bug exists on current IP versions,
> > and per my tests with external USB3 hub + 2 Super speed udisks on data
> > read by dd, I can reproduce this issue with different kernel versions, also I
> > didn't see obvious performance drop by dd tests after disable park mode for
> > super speed, so should we just disable it by default so no need a quirk?
> >
> > Li Jun
> >
> > Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> > >
> > > Thanks for working on this Neil,
> > > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > > As previously mentioned the patch set fixes the issue on affected hardware;
> > > https://patchwork.kernel.org/patch/11164515/
> > >
> > >
> > >
> > > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > > >
> > > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > > This patch updates the documentation with the information related
> > > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > > instances in park mode.
> > > > >
> > > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > > Reported-by: Tim <elatllat@gmail.com>
> > > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > >
> > > > Sigh, what's one more to the never ending list of quirks...
> > > >
> > > > Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 1:48 ` Jun Li
0 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-12 1:48 UTC (permalink / raw)
To: Tim
Cc: Neil Armstrong, Felipe Balbi, khilman, devicetree, linux-usb,
linux-amlogic, linux-arm-kernel, linux-kernel, Dongjin Kim,
Jianxin Pan, Rob Herring
by a quirk, those platforms without this quirk can't benefit this fix.
if later this bug is fixed by some reversion of dwc3 IP, we can easily
remove the workaround by a IP version check:
if (dwc->revision < DWC3_REVISION_PARK_MODE_FIXED)
{
disable park mode for ss;
}
Li Jun
Tim <elatllat@gmail.com> 于2019年11月11日周一 下午10:05写道：
>
> Speculation;
>
> Maybe the kernel maintainers prefer to optimistically permit future
> products to easily remove workarounds via quirk flags.
> Even if data from testing were shown, and it did not impact
> performance, code reduction and clarity are desirable.
>
> On Sun, Nov 10, 2019 at 8:58 PM Jun Li <lijun.kernel@gmail.com> wrote:
> >
> > Hi Neil
> >
> > As I got the information from Synopsys, this bug exists on current IP versions,
> > and per my tests with external USB3 hub + 2 Super speed udisks on data
> > read by dd, I can reproduce this issue with different kernel versions, also I
> > didn't see obvious performance drop by dd tests after disable park mode for
> > super speed, so should we just disable it by default so no need a quirk?
> >
> > Li Jun
> >
> > Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> > >
> > > Thanks for working on this Neil,
> > > Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> > > As previously mentioned the patch set fixes the issue on affected hardware;
> > > https://patchwork.kernel.org/patch/11164515/
> > >
> > >
> > >
> > > On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> > > >
> > > > On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> > > > > This patch updates the documentation with the information related
> > > > > to the quirks that needs to be added for disabling all SuperSpeed XHCi
> > > > > instances in park mode.
> > > > >
> > > > > CC: Dongjin Kim <tobetter@gmail.com>
> > > > > Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> > > > > Reported-by: Tim <elatllat@gmail.com>
> > > > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > >
> > > > Sigh, what's one more to the never ending list of quirks...
> > > >
> > > > Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-11-11 1:58 ` Jun Li
(?)
@ 2019-11-12 9:00 ` Neil Armstrong
-1 siblings, 0 replies; 45+ messages in thread
From: Neil Armstrong @ 2019-11-12 9:00 UTC (permalink / raw)
To: Jun Li, Tim
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Dongjin Kim, linux-amlogic, Rob Herring,
linux-arm-kernel
Hi Li,
On 11/11/2019 02:58, Jun Li wrote:
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
how to handle this.
Did Synopsys specified a range of affected IP version ?
Neil
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>
>> Thanks for working on this Neil,
>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>> As previously mentioned the patch set fixes the issue on affected hardware;
>> https://patchwork.kernel.org/patch/11164515/
>>
>>
>>
>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>
>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>> This patch updates the documentation with the information related
>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>> instances in park mode.
>>>>
>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>> Reported-by: Tim <elatllat@gmail.com>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>
>>> Sigh, what's one more to the never ending list of quirks...
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 9:00 ` Neil Armstrong
0 siblings, 0 replies; 45+ messages in thread
From: Neil Armstrong @ 2019-11-12 9:00 UTC (permalink / raw)
To: Jun Li, Tim
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Dongjin Kim, linux-amlogic, Rob Herring,
linux-arm-kernel
Hi Li,
On 11/11/2019 02:58, Jun Li wrote:
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
how to handle this.
Did Synopsys specified a range of affected IP version ?
Neil
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>
>> Thanks for working on this Neil,
>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>> As previously mentioned the patch set fixes the issue on affected hardware;
>> https://patchwork.kernel.org/patch/11164515/
>>
>>
>>
>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>
>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>> This patch updates the documentation with the information related
>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>> instances in park mode.
>>>>
>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>> Reported-by: Tim <elatllat@gmail.com>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>
>>> Sigh, what's one more to the never ending list of quirks...
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 9:00 ` Neil Armstrong
0 siblings, 0 replies; 45+ messages in thread
From: Neil Armstrong @ 2019-11-12 9:00 UTC (permalink / raw)
To: Jun Li, Tim
Cc: Felipe Balbi, khilman, devicetree, linux-usb, linux-amlogic,
linux-arm-kernel, linux-kernel, Dongjin Kim, Jianxin Pan,
Rob Herring
Hi Li,
On 11/11/2019 02:58, Jun Li wrote:
> Hi Neil
>
> As I got the information from Synopsys, this bug exists on current IP versions,
> and per my tests with external USB3 hub + 2 Super speed udisks on data
> read by dd, I can reproduce this issue with different kernel versions, also I
> didn't see obvious performance drop by dd tests after disable park mode for
> super speed, so should we just disable it by default so no need a quirk?
I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
how to handle this.
Did Synopsys specified a range of affected IP version ?
Neil
>
> Li Jun
>
> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>
>> Thanks for working on this Neil,
>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>> As previously mentioned the patch set fixes the issue on affected hardware;
>> https://patchwork.kernel.org/patch/11164515/
>>
>>
>>
>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>
>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>> This patch updates the documentation with the information related
>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>> instances in park mode.
>>>>
>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>> Reported-by: Tim <elatllat@gmail.com>
>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>> ---
>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>
>>> Sigh, what's one more to the never ending list of quirks...
>>>
>>> Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-11-12 9:00 ` Neil Armstrong
(?)
@ 2019-11-12 10:51 ` Jun Li
-1 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-12 10:51 UTC (permalink / raw)
To: Neil Armstrong, Thinh Nguyen
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Tim, Dongjin Kim, linux-amlogic, Rob Herring,
linux-arm-kernel
This bug exists on all current versions per information I got from Synopsys.
+ Thinh Nguyen <thinhn@synopsys.com>.
Li Jun
Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>
> Hi Li,
>
> On 11/11/2019 02:58, Jun Li wrote:
> > Hi Neil
> >
> > As I got the information from Synopsys, this bug exists on current IP versions,
> > and per my tests with external USB3 hub + 2 Super speed udisks on data
> > read by dd, I can reproduce this issue with different kernel versions, also I
> > didn't see obvious performance drop by dd tests after disable park mode for
> > super speed, so should we just disable it by default so no need a quirk?
>
> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
> how to handle this.
>
> Did Synopsys specified a range of affected IP version ?
>
> Neil
>
> >
> > Li Jun
> >
> > Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >>
> >> Thanks for working on this Neil,
> >> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> >> As previously mentioned the patch set fixes the issue on affected hardware;
> >> https://patchwork.kernel.org/patch/11164515/
> >>
> >>
> >>
> >> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >>>
> >>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> >>>> This patch updates the documentation with the information related
> >>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
> >>>> instances in park mode.
> >>>>
> >>>> CC: Dongjin Kim <tobetter@gmail.com>
> >>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> >>>> Reported-by: Tim <elatllat@gmail.com>
> >>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>> ---
> >>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> >>>> 1 file changed, 2 insertions(+)
> >>>
> >>> Sigh, what's one more to the never ending list of quirks...
> >>>
> >>> Acked-by: Rob Herring <robh@kernel.org>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 10:51 ` Jun Li
0 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-12 10:51 UTC (permalink / raw)
To: Neil Armstrong, Thinh Nguyen
Cc: Felipe Balbi, Jianxin Pan, devicetree, khilman, linux-usb,
linux-kernel, Tim, Dongjin Kim, linux-amlogic, Rob Herring,
linux-arm-kernel
This bug exists on all current versions per information I got from Synopsys.
+ Thinh Nguyen <thinhn@synopsys.com>.
Li Jun
Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>
> Hi Li,
>
> On 11/11/2019 02:58, Jun Li wrote:
> > Hi Neil
> >
> > As I got the information from Synopsys, this bug exists on current IP versions,
> > and per my tests with external USB3 hub + 2 Super speed udisks on data
> > read by dd, I can reproduce this issue with different kernel versions, also I
> > didn't see obvious performance drop by dd tests after disable park mode for
> > super speed, so should we just disable it by default so no need a quirk?
>
> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
> how to handle this.
>
> Did Synopsys specified a range of affected IP version ?
>
> Neil
>
> >
> > Li Jun
> >
> > Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >>
> >> Thanks for working on this Neil,
> >> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> >> As previously mentioned the patch set fixes the issue on affected hardware;
> >> https://patchwork.kernel.org/patch/11164515/
> >>
> >>
> >>
> >> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >>>
> >>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> >>>> This patch updates the documentation with the information related
> >>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
> >>>> instances in park mode.
> >>>>
> >>>> CC: Dongjin Kim <tobetter@gmail.com>
> >>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> >>>> Reported-by: Tim <elatllat@gmail.com>
> >>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>> ---
> >>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> >>>> 1 file changed, 2 insertions(+)
> >>>
> >>> Sigh, what's one more to the never ending list of quirks...
> >>>
> >>> Acked-by: Rob Herring <robh@kernel.org>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 10:51 ` Jun Li
0 siblings, 0 replies; 45+ messages in thread
From: Jun Li @ 2019-11-12 10:51 UTC (permalink / raw)
To: Neil Armstrong, Thinh Nguyen
Cc: Tim, Felipe Balbi, khilman, devicetree, linux-usb, linux-amlogic,
linux-arm-kernel, linux-kernel, Dongjin Kim, Jianxin Pan,
Rob Herring
This bug exists on all current versions per information I got from Synopsys.
+ Thinh Nguyen <thinhn@synopsys.com>.
Li Jun
Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>
> Hi Li,
>
> On 11/11/2019 02:58, Jun Li wrote:
> > Hi Neil
> >
> > As I got the information from Synopsys, this bug exists on current IP versions,
> > and per my tests with external USB3 hub + 2 Super speed udisks on data
> > read by dd, I can reproduce this issue with different kernel versions, also I
> > didn't see obvious performance drop by dd tests after disable park mode for
> > super speed, so should we just disable it by default so no need a quirk?
>
> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
> how to handle this.
>
> Did Synopsys specified a range of affected IP version ?
>
> Neil
>
> >
> > Li Jun
> >
> > Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >>
> >> Thanks for working on this Neil,
> >> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> >> As previously mentioned the patch set fixes the issue on affected hardware;
> >> https://patchwork.kernel.org/patch/11164515/
> >>
> >>
> >>
> >> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >>>
> >>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> >>>> This patch updates the documentation with the information related
> >>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
> >>>> instances in park mode.
> >>>>
> >>>> CC: Dongjin Kim <tobetter@gmail.com>
> >>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> >>>> Reported-by: Tim <elatllat@gmail.com>
> >>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>> ---
> >>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> >>>> 1 file changed, 2 insertions(+)
> >>>
> >>> Sigh, what's one more to the never ending list of quirks...
> >>>
> >>> Acked-by: Rob Herring <robh@kernel.org>
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-11-12 10:51 ` Jun Li
(?)
@ 2019-11-12 20:03 ` Thinh Nguyen
-1 siblings, 0 replies; 45+ messages in thread
From: Thinh Nguyen @ 2019-11-12 20:03 UTC (permalink / raw)
To: Jun Li, Neil Armstrong, Thinh Nguyen
Cc: Felipe Balbi, Jianxin Pan, devicetree@vger.kernel.org,
khilman@baylibre.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Tim, Dongjin Kim,
linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
Hi,
Jun Li wrote:
> This bug exists on all current versions per information I got from Synopsys.
> + Thinh Nguyen <thinhn@synopsys.com>.
>
> Li Jun
The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
running in host mode. This should not be set for other IPs.
This can be disabled by default based on IP, but I recommend to have a
property to enable this feature for devices that need this.
>
> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>> Hi Li,
>>
>> On 11/11/2019 02:58, Jun Li wrote:
>>> Hi Neil
>>>
>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>> didn't see obvious performance drop by dd tests after disable park mode for
>>> super speed, so should we just disable it by default so no need a quirk?
>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>> how to handle this.
>>
>> Did Synopsys specified a range of affected IP version ?
>>
>> Neil
>>
>>> Li Jun
>>>
>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>>> Thanks for working on this Neil,
>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>
>>>>
>>>>
>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>> This patch updates the documentation with the information related
>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>> instances in park mode.
>>>>>>
>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>>>> Reported-by: Tim <elatllat@gmail.com>
>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>> ---
>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>> 1 file changed, 2 insertions(+)
>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
BR,
Thinh
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 20:03 ` Thinh Nguyen
0 siblings, 0 replies; 45+ messages in thread
From: Thinh Nguyen @ 2019-11-12 20:03 UTC (permalink / raw)
To: Jun Li, Neil Armstrong, Thinh Nguyen
Cc: Felipe Balbi, Jianxin Pan, devicetree@vger.kernel.org,
khilman@baylibre.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Tim, Dongjin Kim,
linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
Hi,
Jun Li wrote:
> This bug exists on all current versions per information I got from Synopsys.
> + Thinh Nguyen <thinhn@synopsys.com>.
>
> Li Jun
The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
running in host mode. This should not be set for other IPs.
This can be disabled by default based on IP, but I recommend to have a
property to enable this feature for devices that need this.
>
> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>> Hi Li,
>>
>> On 11/11/2019 02:58, Jun Li wrote:
>>> Hi Neil
>>>
>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>> didn't see obvious performance drop by dd tests after disable park mode for
>>> super speed, so should we just disable it by default so no need a quirk?
>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>> how to handle this.
>>
>> Did Synopsys specified a range of affected IP version ?
>>
>> Neil
>>
>>> Li Jun
>>>
>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>>> Thanks for working on this Neil,
>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>
>>>>
>>>>
>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>> This patch updates the documentation with the information related
>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>> instances in park mode.
>>>>>>
>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>>>> Reported-by: Tim <elatllat@gmail.com>
>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>> ---
>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>> 1 file changed, 2 insertions(+)
>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
BR,
Thinh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-11-12 20:03 ` Thinh Nguyen
0 siblings, 0 replies; 45+ messages in thread
From: Thinh Nguyen @ 2019-11-12 20:03 UTC (permalink / raw)
To: Jun Li, Neil Armstrong, Thinh Nguyen
Cc: Tim, Felipe Balbi, khilman@baylibre.com,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Dongjin Kim, Jianxin Pan,
Rob Herring
Hi,
Jun Li wrote:
> This bug exists on all current versions per information I got from Synopsys.
> + Thinh Nguyen <thinhn@synopsys.com>.
>
> Li Jun
The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
running in host mode. This should not be set for other IPs.
This can be disabled by default based on IP, but I recommend to have a
property to enable this feature for devices that need this.
>
> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>> Hi Li,
>>
>> On 11/11/2019 02:58, Jun Li wrote:
>>> Hi Neil
>>>
>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>> didn't see obvious performance drop by dd tests after disable park mode for
>>> super speed, so should we just disable it by default so no need a quirk?
>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>> how to handle this.
>>
>> Did Synopsys specified a range of affected IP version ?
>>
>> Neil
>>
>>> Li Jun
>>>
>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>>> Thanks for working on this Neil,
>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>
>>>>
>>>>
>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>> This patch updates the documentation with the information related
>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>> instances in park mode.
>>>>>>
>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>>>> Reported-by: Tim <elatllat@gmail.com>
>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>> ---
>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>> 1 file changed, 2 insertions(+)
>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>
>>>>> Acked-by: Rob Herring <robh@kernel.org>
BR,
Thinh
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-11-12 20:03 ` Thinh Nguyen
(?)
@ 2019-12-10 8:55 ` Neil Armstrong
-1 siblings, 0 replies; 45+ messages in thread
From: Neil Armstrong @ 2019-12-10 8:55 UTC (permalink / raw)
To: Thinh Nguyen, Jun Li
Cc: Felipe Balbi, Jianxin Pan, devicetree@vger.kernel.org,
khilman@baylibre.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Tim, Dongjin Kim,
linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
Hi,
On 12/11/2019 21:03, Thinh Nguyen wrote:
> Hi,
>
> Jun Li wrote:
>> This bug exists on all current versions per information I got from Synopsys.
>> + Thinh Nguyen <thinhn@synopsys.com>.
>>
>> Li Jun
>
> The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
> running in host mode. This should not be set for other IPs.
>
> This can be disabled by default based on IP, but I recommend to have a
> property to enable this feature for devices that need this.
Thanks, so this patchset is the right way to solve this.
Felipe, would it be possible to have it merged for next release ?
Should I resend it ?
Thanks,
Neil
>
>
>>
>> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>>> Hi Li,
>>>
>>> On 11/11/2019 02:58, Jun Li wrote:
>>>> Hi Neil
>>>>
>>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>>> didn't see obvious performance drop by dd tests after disable park mode for
>>>> super speed, so should we just disable it by default so no need a quirk?
>>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>>> how to handle this.
>>>
>>> Did Synopsys specified a range of affected IP version ?
>>>
>>> Neil
>>>
>>>> Li Jun
>>>>
>>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>>>> Thanks for working on this Neil,
>>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>>> This patch updates the documentation with the information related
>>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>>> instances in park mode.
>>>>>>>
>>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>>>>> Reported-by: Tim <elatllat@gmail.com>
>>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>>> ---
>>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>>> 1 file changed, 2 insertions(+)
>>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>>
>>>>>> Acked-by: Rob Herring <robh@kernel.org>
>
> BR,
> Thinh
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-12-10 8:55 ` Neil Armstrong
0 siblings, 0 replies; 45+ messages in thread
From: Neil Armstrong @ 2019-12-10 8:55 UTC (permalink / raw)
To: Thinh Nguyen, Jun Li
Cc: Felipe Balbi, Jianxin Pan, devicetree@vger.kernel.org,
khilman@baylibre.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Tim, Dongjin Kim,
linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
Hi,
On 12/11/2019 21:03, Thinh Nguyen wrote:
> Hi,
>
> Jun Li wrote:
>> This bug exists on all current versions per information I got from Synopsys.
>> + Thinh Nguyen <thinhn@synopsys.com>.
>>
>> Li Jun
>
> The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
> running in host mode. This should not be set for other IPs.
>
> This can be disabled by default based on IP, but I recommend to have a
> property to enable this feature for devices that need this.
Thanks, so this patchset is the right way to solve this.
Felipe, would it be possible to have it merged for next release ?
Should I resend it ?
Thanks,
Neil
>
>
>>
>> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>>> Hi Li,
>>>
>>> On 11/11/2019 02:58, Jun Li wrote:
>>>> Hi Neil
>>>>
>>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>>> didn't see obvious performance drop by dd tests after disable park mode for
>>>> super speed, so should we just disable it by default so no need a quirk?
>>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>>> how to handle this.
>>>
>>> Did Synopsys specified a range of affected IP version ?
>>>
>>> Neil
>>>
>>>> Li Jun
>>>>
>>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>>>> Thanks for working on this Neil,
>>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>>> This patch updates the documentation with the information related
>>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>>> instances in park mode.
>>>>>>>
>>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>>>>> Reported-by: Tim <elatllat@gmail.com>
>>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>>> ---
>>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>>> 1 file changed, 2 insertions(+)
>>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>>
>>>>>> Acked-by: Rob Herring <robh@kernel.org>
>
> BR,
> Thinh
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-12-10 8:55 ` Neil Armstrong
0 siblings, 0 replies; 45+ messages in thread
From: Neil Armstrong @ 2019-12-10 8:55 UTC (permalink / raw)
To: Thinh Nguyen, Jun Li
Cc: Tim, Felipe Balbi, khilman@baylibre.com,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Dongjin Kim, Jianxin Pan,
Rob Herring
Hi,
On 12/11/2019 21:03, Thinh Nguyen wrote:
> Hi,
>
> Jun Li wrote:
>> This bug exists on all current versions per information I got from Synopsys.
>> + Thinh Nguyen <thinhn@synopsys.com>.
>>
>> Li Jun
>
> The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
> running in host mode. This should not be set for other IPs.
>
> This can be disabled by default based on IP, but I recommend to have a
> property to enable this feature for devices that need this.
Thanks, so this patchset is the right way to solve this.
Felipe, would it be possible to have it merged for next release ?
Should I resend it ?
Thanks,
Neil
>
>
>>
>> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
>>> Hi Li,
>>>
>>> On 11/11/2019 02:58, Jun Li wrote:
>>>> Hi Neil
>>>>
>>>> As I got the information from Synopsys, this bug exists on current IP versions,
>>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
>>>> read by dd, I can reproduce this issue with different kernel versions, also I
>>>> didn't see obvious performance drop by dd tests after disable park mode for
>>>> super speed, so should we just disable it by default so no need a quirk?
>>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
>>> how to handle this.
>>>
>>> Did Synopsys specified a range of affected IP version ?
>>>
>>> Neil
>>>
>>>> Li Jun
>>>>
>>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
>>>>> Thanks for working on this Neil,
>>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
>>>>> As previously mentioned the patch set fixes the issue on affected hardware;
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
>>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
>>>>>>> This patch updates the documentation with the information related
>>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
>>>>>>> instances in park mode.
>>>>>>>
>>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
>>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
>>>>>>> Reported-by: Tim <elatllat@gmail.com>
>>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>>>> ---
>>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
>>>>>>> 1 file changed, 2 insertions(+)
>>>>>> Sigh, what's one more to the never ending list of quirks...
>>>>>>
>>>>>> Acked-by: Rob Herring <robh@kernel.org>
>
> BR,
> Thinh
>
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-12-10 8:55 ` Neil Armstrong
(?)
@ 2019-12-11 0:45 ` Tim
-1 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-12-11 0:45 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree@vger.kernel.org, Jianxin Pan, Felipe Balbi,
Thinh Nguyen, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Jun Li, khilman@baylibre.com,
Dongjin Kim, linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
Just writing to say;
this patch is still performing well on 5.5.0-rc1, and
there is no speed improvement by adding DWC3_GUCTL_NAK_PER_ENH_HS BIT(17)
I get up to 3890 ms second lag with "ping -s 5120 $IP" when
copying between USB HDDs either way, but at least this patch stops the
crashing.
On Tue, Dec 10, 2019 at 3:55 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi,
>
> On 12/11/2019 21:03, Thinh Nguyen wrote:
> > Hi,
> >
> > Jun Li wrote:
> >> This bug exists on all current versions per information I got from Synopsys.
> >> + Thinh Nguyen <thinhn@synopsys.com>.
> >>
> >> Li Jun
> >
> > The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
> > running in host mode. This should not be set for other IPs.
> >
> > This can be disabled by default based on IP, but I recommend to have a
> > property to enable this feature for devices that need this.
>
> Thanks, so this patchset is the right way to solve this.
>
> Felipe, would it be possible to have it merged for next release ?
> Should I resend it ?
>
> Thanks,
> Neil
>
> >
> >
> >>
> >> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
> >>> Hi Li,
> >>>
> >>> On 11/11/2019 02:58, Jun Li wrote:
> >>>> Hi Neil
> >>>>
> >>>> As I got the information from Synopsys, this bug exists on current IP versions,
> >>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
> >>>> read by dd, I can reproduce this issue with different kernel versions, also I
> >>>> didn't see obvious performance drop by dd tests after disable park mode for
> >>>> super speed, so should we just disable it by default so no need a quirk?
> >>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
> >>> how to handle this.
> >>>
> >>> Did Synopsys specified a range of affected IP version ?
> >>>
> >>> Neil
> >>>
> >>>> Li Jun
> >>>>
> >>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >>>>> Thanks for working on this Neil,
> >>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> >>>>> As previously mentioned the patch set fixes the issue on affected hardware;
> >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
> >>>>>
> >>>>>
> >>>>>
> >>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> >>>>>>> This patch updates the documentation with the information related
> >>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
> >>>>>>> instances in park mode.
> >>>>>>>
> >>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
> >>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> >>>>>>> Reported-by: Tim <elatllat@gmail.com>
> >>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>>>>> ---
> >>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> >>>>>>> 1 file changed, 2 insertions(+)
> >>>>>> Sigh, what's one more to the never ending list of quirks...
> >>>>>>
> >>>>>> Acked-by: Rob Herring <robh@kernel.org>
> >
> > BR,
> > Thinh
> >
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-12-11 0:45 ` Tim
0 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-12-11 0:45 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree@vger.kernel.org, Jianxin Pan, Felipe Balbi,
Thinh Nguyen, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Jun Li, khilman@baylibre.com,
Dongjin Kim, linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
Just writing to say;
this patch is still performing well on 5.5.0-rc1, and
there is no speed improvement by adding DWC3_GUCTL_NAK_PER_ENH_HS BIT(17)
I get up to 3890 ms second lag with "ping -s 5120 $IP" when
copying between USB HDDs either way, but at least this patch stops the
crashing.
On Tue, Dec 10, 2019 at 3:55 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi,
>
> On 12/11/2019 21:03, Thinh Nguyen wrote:
> > Hi,
> >
> > Jun Li wrote:
> >> This bug exists on all current versions per information I got from Synopsys.
> >> + Thinh Nguyen <thinhn@synopsys.com>.
> >>
> >> Li Jun
> >
> > The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
> > running in host mode. This should not be set for other IPs.
> >
> > This can be disabled by default based on IP, but I recommend to have a
> > property to enable this feature for devices that need this.
>
> Thanks, so this patchset is the right way to solve this.
>
> Felipe, would it be possible to have it merged for next release ?
> Should I resend it ?
>
> Thanks,
> Neil
>
> >
> >
> >>
> >> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
> >>> Hi Li,
> >>>
> >>> On 11/11/2019 02:58, Jun Li wrote:
> >>>> Hi Neil
> >>>>
> >>>> As I got the information from Synopsys, this bug exists on current IP versions,
> >>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
> >>>> read by dd, I can reproduce this issue with different kernel versions, also I
> >>>> didn't see obvious performance drop by dd tests after disable park mode for
> >>>> super speed, so should we just disable it by default so no need a quirk?
> >>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
> >>> how to handle this.
> >>>
> >>> Did Synopsys specified a range of affected IP version ?
> >>>
> >>> Neil
> >>>
> >>>> Li Jun
> >>>>
> >>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >>>>> Thanks for working on this Neil,
> >>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> >>>>> As previously mentioned the patch set fixes the issue on affected hardware;
> >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
> >>>>>
> >>>>>
> >>>>>
> >>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> >>>>>>> This patch updates the documentation with the information related
> >>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
> >>>>>>> instances in park mode.
> >>>>>>>
> >>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
> >>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> >>>>>>> Reported-by: Tim <elatllat@gmail.com>
> >>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>>>>> ---
> >>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> >>>>>>> 1 file changed, 2 insertions(+)
> >>>>>> Sigh, what's one more to the never ending list of quirks...
> >>>>>>
> >>>>>> Acked-by: Rob Herring <robh@kernel.org>
> >
> > BR,
> > Thinh
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-12-11 0:45 ` Tim
0 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-12-11 0:45 UTC (permalink / raw)
To: Neil Armstrong
Cc: Thinh Nguyen, Jun Li, Felipe Balbi, khilman@baylibre.com,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Dongjin Kim, Jianxin Pan,
Rob Herring
Just writing to say;
this patch is still performing well on 5.5.0-rc1, and
there is no speed improvement by adding DWC3_GUCTL_NAK_PER_ENH_HS BIT(17)
I get up to 3890 ms second lag with "ping -s 5120 $IP" when
copying between USB HDDs either way, but at least this patch stops the
crashing.
On Tue, Dec 10, 2019 at 3:55 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi,
>
> On 12/11/2019 21:03, Thinh Nguyen wrote:
> > Hi,
> >
> > Jun Li wrote:
> >> This bug exists on all current versions per information I got from Synopsys.
> >> + Thinh Nguyen <thinhn@synopsys.com>.
> >>
> >> Li Jun
> >
> > The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
> > running in host mode. This should not be set for other IPs.
> >
> > This can be disabled by default based on IP, but I recommend to have a
> > property to enable this feature for devices that need this.
>
> Thanks, so this patchset is the right way to solve this.
>
> Felipe, would it be possible to have it merged for next release ?
> Should I resend it ?
>
> Thanks,
> Neil
>
> >
> >
> >>
> >> Neil Armstrong <narmstrong@baylibre.com> 于2019年11月12日周二 下午5:00写道：
> >>> Hi Li,
> >>>
> >>> On 11/11/2019 02:58, Jun Li wrote:
> >>>> Hi Neil
> >>>>
> >>>> As I got the information from Synopsys, this bug exists on current IP versions,
> >>>> and per my tests with external USB3 hub + 2 Super speed udisks on data
> >>>> read by dd, I can reproduce this issue with different kernel versions, also I
> >>>> didn't see obvious performance drop by dd tests after disable park mode for
> >>>> super speed, so should we just disable it by default so no need a quirk?
> >>> I don't have any opinion on this, I think the USB & DWC3 maintainers should decide
> >>> how to handle this.
> >>>
> >>> Did Synopsys specified a range of affected IP version ?
> >>>
> >>> Neil
> >>>
> >>>> Li Jun
> >>>>
> >>>> Tim <elatllat@gmail.com> 于2019年11月11日周一 上午8:42写道：
> >>>>> Thanks for working on this Neil,
> >>>>> Is there something that needs doing for this patch to make it into 5.3 or 5.4?
> >>>>> As previously mentioned the patch set fixes the issue on affected hardware;
> >>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.kernel.org_patch_11164515_&d=DwIFaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=u9FYoxKtyhjrGFcyixFYqTjw1ZX0VsG2d8FCmzkTY-w&m=BCfRHM9e86039Su0-QvK_yUjNnYrnl_BcvxTtViypT8&s=aV5u7uxNX6oTLB3_-qNuzrNvyiqx_rPC6P9TMqG-LNE&e=
> >>>>>
> >>>>>
> >>>>>
> >>>>> On Wed, Oct 23, 2019 at 4:11 PM Rob Herring <robh@kernel.org> wrote:
> >>>>>> On Mon, Oct 14, 2019 at 04:17:16PM +0200, Neil Armstrong wrote:
> >>>>>>> This patch updates the documentation with the information related
> >>>>>>> to the quirks that needs to be added for disabling all SuperSpeed XHCi
> >>>>>>> instances in park mode.
> >>>>>>>
> >>>>>>> CC: Dongjin Kim <tobetter@gmail.com>
> >>>>>>> Cc: Jianxin Pan <jianxin.pan@amlogic.com>
> >>>>>>> Reported-by: Tim <elatllat@gmail.com>
> >>>>>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >>>>>>> ---
> >>>>>>> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> >>>>>>> 1 file changed, 2 insertions(+)
> >>>>>> Sigh, what's one more to the never ending list of quirks...
> >>>>>>
> >>>>>> Acked-by: Rob Herring <robh@kernel.org>
> >
> > BR,
> > Thinh
> >
>
^ permalink raw reply [flat|nested] 45+ messages in thread* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
2019-12-11 0:45 ` Tim
(?)
@ 2019-12-20 9:58 ` Tim
-1 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-12-20 9:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree@vger.kernel.org, Jianxin Pan, Felipe Balbi,
Thinh Nguyen, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Jun Li, khilman@baylibre.com,
Dongjin Kim, linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
This patch is still good on 5.4 and 5.5, and the following network lag
was solved by separating the USB and NIC smp_affinity_list.
On Tue, Dec 10, 2019, 7:45 PM Tim <elatllat@gmail.com> wrote:
>
> Just writing to say;
> this patch is still performing well on 5.5.0-rc1, and
> there is no speed improvement by adding DWC3_GUCTL_NAK_PER_ENH_HS BIT(17)
> I get up to 3890 ms second lag with "ping -s 5120 $IP" when
> copying between USB HDDs either way, but at least this patch stops the
> crashing.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-12-20 9:58 ` Tim
0 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-12-20 9:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: devicetree@vger.kernel.org, Jianxin Pan, Felipe Balbi,
Thinh Nguyen, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Jun Li, khilman@baylibre.com,
Dongjin Kim, linux-amlogic@lists.infradead.org, Rob Herring,
linux-arm-kernel@lists.infradead.org
This patch is still good on 5.4 and 5.5, and the following network lag
was solved by separating the USB and NIC smp_affinity_list.
On Tue, Dec 10, 2019, 7:45 PM Tim <elatllat@gmail.com> wrote:
>
> Just writing to say;
> this patch is still performing well on 5.5.0-rc1, and
> there is no speed improvement by adding DWC3_GUCTL_NAK_PER_ENH_HS BIT(17)
> I get up to 3890 ms second lag with "ping -s 5120 $IP" when
> copying between USB HDDs either way, but at least this patch stops the
> crashing.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 45+ messages in thread
* Re: [PATCH 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode
@ 2019-12-20 9:58 ` Tim
0 siblings, 0 replies; 45+ messages in thread
From: Tim @ 2019-12-20 9:58 UTC (permalink / raw)
To: Neil Armstrong
Cc: Thinh Nguyen, Jun Li, Felipe Balbi, khilman@baylibre.com,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Dongjin Kim, Jianxin Pan,
Rob Herring
This patch is still good on 5.4 and 5.5, and the following network lag
was solved by separating the USB and NIC smp_affinity_list.
On Tue, Dec 10, 2019, 7:45 PM Tim <elatllat@gmail.com> wrote:
>
> Just writing to say;
> this patch is still performing well on 5.5.0-rc1, and
> there is no speed improvement by adding DWC3_GUCTL_NAK_PER_ENH_HS BIT(17)
> I get up to 3890 ms second lag with "ping -s 5120 $IP" when
> copying between USB HDDs either way, but at least this patch stops the
> crashing.
^ permalink raw reply [flat|nested] 45+ messages in thread