From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Stephane Eranian <eranian@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver
Date: Wed, 23 Oct 2019 23:20:04 +0000 [thread overview]
Message-ID: <20191023232004.GV3125@piout.net> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com>
On 23/10/2019 21:30:29+0000, Luck, Tony wrote:
> >> rtc-efi rtc-efi: setting system clock to 2019-10-23T18:30:23 UTC (1571855423)
>
> > You can remove CONFIG_RTC_HCTOSYS, this line will disappear, systemd
> > will not like that but efirtc was not setting the system time anyway so
> > this shouldn't change the behaviour.
>
>
> Wait ... that message says "setting system clock"
>
> but then you say " efirtc was not setting the system time anyway".
>
> So did the time get set, or not?
>
> If it wasn't set, why does the message say that it was set?
>
What I meant was that drivers/char/efirtc.c was not setting the system
time but when using drivers/rtc/rtc-efi.c with CONFIG_RTC_HCTOSYS, the
kernel will use the rtc to set the system time.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Stephane Eranian <eranian@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver
Date: Thu, 24 Oct 2019 01:20:04 +0200 [thread overview]
Message-ID: <20191023232004.GV3125@piout.net> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F4AD7F7@ORSMSX115.amr.corp.intel.com>
On 23/10/2019 21:30:29+0000, Luck, Tony wrote:
> >> rtc-efi rtc-efi: setting system clock to 2019-10-23T18:30:23 UTC (1571855423)
>
> > You can remove CONFIG_RTC_HCTOSYS, this line will disappear, systemd
> > will not like that but efirtc was not setting the system time anyway so
> > this shouldn't change the behaviour.
>
>
> Wait ... that message says "setting system clock"
>
> but then you say " efirtc was not setting the system time anyway".
>
> So did the time get set, or not?
>
> If it wasn't set, why does the message say that it was set?
>
What I meant was that drivers/char/efirtc.c was not setting the system
time but when using drivers/rtc/rtc-efi.c with CONFIG_RTC_HCTOSYS, the
kernel will use the rtc to set the system time.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-23 23:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 15:01 [PATCH 1/2] rtc/ia64: remove legacy efirtc driver Arnd Bergmann
2019-10-23 15:01 ` Arnd Bergmann
2019-10-23 15:01 ` [PATCH 2/2] rtc/alpha: remove legacy rtc driver Arnd Bergmann
2019-10-23 15:23 ` Alexandre Belloni
2019-10-23 16:41 ` Paul Gortmaker
2019-10-23 16:41 ` Paul Gortmaker
2019-10-23 15:23 ` [PATCH 1/2] rtc/ia64: remove legacy efirtc driver Alexandre Belloni
2019-10-23 15:23 ` Alexandre Belloni
2019-10-23 18:46 ` Luck, Tony
2019-10-23 18:46 ` Luck, Tony
2019-10-23 20:01 ` Alexandre Belloni
2019-10-23 20:01 ` Alexandre Belloni
2019-10-23 21:30 ` Luck, Tony
2019-10-23 23:20 ` Alexandre Belloni [this message]
2019-10-23 23:20 ` Alexandre Belloni
2019-10-24 7:32 ` Arnd Bergmann
2019-10-24 7:32 ` Arnd Bergmann
2019-10-24 16:57 ` Luck, Tony
2019-10-24 16:57 ` Luck, Tony
2019-10-25 10:41 ` Arnd Bergmann
2019-10-25 10:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023232004.GV3125@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.