From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Andrea Arcangeli
<aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Yang, Philip" <Philip.Yang-5C7GfCeVMHo@public.gmane.org>,
Ralph Campbell
<rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
John Hubbard <jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"Kuehling, Felix" <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
Jerome Glisse <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"christian.koenig-5C7GfCeVMHo@public.gmane.org"
<christian.koenig-5C7GfCeVMHo@public.gmane.org>,
Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking
Date: Wed, 23 Oct 2019 19:16:25 -0700 [thread overview]
Message-ID: <20191024021625.GA5893@infradead.org> (raw)
In-Reply-To: <20191023172442.GX22766-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Wed, Oct 23, 2019 at 05:24:45PM +0000, Jason Gunthorpe wrote:
> mlx5 is similar, but not currently coded quite right, there is one
> lock that protects the command queue for submitting invalidations to
> the HW and it doesn't make a lot of sense to have additional fine
> grained locking beyond that.
IFF all drivers could agree on a lock type (rw_semaphore?) for this
protection you could add a pointer to the range which would clear
things up a lot. I'm just not sure you could get everyone to
agree.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
"Yang, Philip" <Philip.Yang@amd.com>,
Ralph Campbell <rcampbell@nvidia.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
John Hubbard <jhubbard@nvidia.com>,
"Kuehling, Felix" <Felix.Kuehling@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Jerome Glisse <jglisse@redhat.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking
Date: Wed, 23 Oct 2019 19:16:25 -0700 [thread overview]
Message-ID: <20191024021625.GA5893@infradead.org> (raw)
Message-ID: <20191024021625.T4GvV1dcH0SpS81Gh1i9TdprdBeEYFbBg8lnGKK_8fE@z> (raw)
In-Reply-To: <20191023172442.GX22766@mellanox.com>
On Wed, Oct 23, 2019 at 05:24:45PM +0000, Jason Gunthorpe wrote:
> mlx5 is similar, but not currently coded quite right, there is one
> lock that protects the command queue for submitting invalidations to
> the HW and it doesn't make a lot of sense to have additional fine
> grained locking beyond that.
IFF all drivers could agree on a lock type (rw_semaphore?) for this
protection you could add a pointer to the range which would clear
things up a lot. I'm just not sure you could get everyone to
agree.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Jerome Glisse <jglisse@redhat.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Yang, Philip" <Philip.Yang@amd.com>,
Ralph Campbell <rcampbell@nvidia.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
John Hubbard <jhubbard@nvidia.com>,
"Kuehling, Felix" <Felix.Kuehling@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking
Date: Wed, 23 Oct 2019 19:16:25 -0700 [thread overview]
Message-ID: <20191024021625.GA5893@infradead.org> (raw)
In-Reply-To: <20191023172442.GX22766@mellanox.com>
On Wed, Oct 23, 2019 at 05:24:45PM +0000, Jason Gunthorpe wrote:
> mlx5 is similar, but not currently coded quite right, there is one
> lock that protects the command queue for submitting invalidations to
> the HW and it doesn't make a lot of sense to have additional fine
> grained locking beyond that.
IFF all drivers could agree on a lock type (rw_semaphore?) for this
protection you could add a pointer to the range which would clear
things up a lot. I'm just not sure you could get everyone to
agree.
next prev parent reply other threads:[~2019-10-24 2:16 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 18:12 [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER Jason Gunthorpe
2019-10-15 18:12 ` [Xen-devel] " Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-16 5:11 ` Jürgen Groß
2019-10-16 5:11 ` [Xen-devel] " Jürgen Groß
2019-10-16 5:11 ` Jürgen Groß
2019-10-16 6:35 ` Oleksandr Andrushchenko
2019-10-16 6:35 ` [Xen-devel] " Oleksandr Andrushchenko
2019-10-16 6:35 ` Oleksandr Andrushchenko
2019-10-21 19:12 ` Jason Gunthorpe
2019-10-21 19:12 ` [Xen-devel] " Jason Gunthorpe
2019-10-21 19:12 ` Jason Gunthorpe
[not found] ` <20191021191219.GJ6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-28 6:25 ` [Xen-devel] " Oleksandr Andrushchenko
2019-10-28 6:25 ` Oleksandr Andrushchenko
2019-10-28 6:25 ` Oleksandr Andrushchenko
2019-10-28 6:25 ` Oleksandr Andrushchenko
2019-10-28 6:25 ` Oleksandr Andrushchenko
2019-10-15 18:12 ` [PATCH hmm 09/15] xen/gntdev: use mmu_range_notifier_insert Jason Gunthorpe
2019-10-15 18:12 ` [Xen-devel] " Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
[not found] ` <20191015181242.8343-1-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-15 18:12 ` [PATCH hmm 01/15] mm/mmu_notifier: define the header pre-processor parts even if disabled Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
[not found] ` <20191015181242.8343-2-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-21 18:32 ` Jerome Glisse
2019-10-21 18:32 ` Jerome Glisse
2019-10-15 18:12 ` [PATCH hmm 02/15] mm/mmu_notifier: add an interval tree notifier Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-21 18:30 ` Jerome Glisse
2019-10-21 18:30 ` Jerome Glisse
2019-10-21 18:54 ` Jason Gunthorpe
2019-10-21 18:54 ` Jason Gunthorpe
2019-10-21 19:11 ` Jerome Glisse
2019-10-21 19:11 ` Jerome Glisse
2019-10-21 19:24 ` Jason Gunthorpe
2019-10-21 19:24 ` Jason Gunthorpe
[not found] ` <20191021192448.GK6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-21 19:47 ` Jerome Glisse
2019-10-21 19:47 ` Jerome Glisse
2019-10-27 23:15 ` Jason Gunthorpe
2019-10-27 23:15 ` Jason Gunthorpe
2019-10-27 23:15 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 03/15] mm/hmm: allow hmm_range to be used with a mmu_range_notifier or hmm_mirror Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-21 18:33 ` Jerome Glisse
2019-10-21 18:33 ` Jerome Glisse
2019-10-15 18:12 ` [PATCH hmm 04/15] mm/hmm: define the pre-processor related parts of hmm.h even if disabled Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
[not found] ` <20191015181242.8343-5-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-21 18:31 ` Jerome Glisse
2019-10-21 18:31 ` Jerome Glisse
2019-10-15 18:12 ` [PATCH hmm 05/15] RDMA/odp: Use mmu_range_notifier_insert() Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
[not found] ` <20191015181242.8343-6-jgg-uk2M96/98Pc@public.gmane.org>
2019-11-04 20:25 ` Jason Gunthorpe
2019-11-04 20:25 ` Jason Gunthorpe
2019-11-04 20:25 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 06/15] RDMA/hfi1: Use mmu_range_notifier_inset for user_exp_rcv Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-29 12:15 ` Dennis Dalessandro
2019-10-29 12:15 ` Dennis Dalessandro
2019-10-29 12:15 ` Dennis Dalessandro
2019-10-15 18:12 ` [PATCH hmm 07/15] drm/radeon: use mmu_range_notifier_insert Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 10/15] nouveau: use mmu_notifier directly for invalidate_range_start Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 11/15] nouveau: use mmu_range_notifier instead of hmm_mirror Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 12/15] drm/amdgpu: Call find_vma under mmap_sem Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 13/15] drm/amdgpu: Use mmu_range_insert instead of hmm_mirror Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 14/15] drm/amdgpu: Use mmu_range_notifier " Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 15/15] mm/hmm: remove hmm_mirror and related Jason Gunthorpe
2019-10-15 18:12 ` Jason Gunthorpe
[not found] ` <20191015181242.8343-16-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-21 18:38 ` Jerome Glisse
2019-10-21 18:38 ` Jerome Glisse
2019-10-21 18:57 ` Jason Gunthorpe
2019-10-21 18:57 ` Jason Gunthorpe
[not found] ` <20191021185738.GH6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-21 19:19 ` Jerome Glisse
2019-10-21 19:19 ` Jerome Glisse
2019-10-16 8:58 ` [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Christian König
2019-10-16 8:58 ` Christian König
[not found] ` <bc954d29-388b-9e29-f960-115ccc6b9fea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-16 16:04 ` Jason Gunthorpe
2019-10-16 16:04 ` Jason Gunthorpe
[not found] ` <20191016160444.GB3430-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-17 8:54 ` Christian König
2019-10-17 8:54 ` Christian König
2019-10-17 16:26 ` Yang, Philip
2019-10-17 16:26 ` Yang, Philip
[not found] ` <2046e0b4-ba05-0683-5804-e9bbf903658d-5C7GfCeVMHo@public.gmane.org>
2019-10-17 16:47 ` Koenig, Christian
2019-10-17 16:47 ` Koenig, Christian
[not found] ` <d6bcbd2a-2519-8945-eaf5-4f4e738c7fa9-5C7GfCeVMHo@public.gmane.org>
2019-10-18 20:36 ` Jason Gunthorpe
2019-10-18 20:36 ` Jason Gunthorpe
2019-10-20 14:21 ` Koenig, Christian
2019-10-20 14:21 ` Koenig, Christian
2019-10-21 13:57 ` Jason Gunthorpe
2019-10-21 13:57 ` Jason Gunthorpe
[not found] ` <20191021135744.GA25164-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-21 14:28 ` Koenig, Christian
2019-10-21 14:28 ` Koenig, Christian
2019-10-21 15:12 ` Jason Gunthorpe
2019-10-21 15:12 ` Jason Gunthorpe
[not found] ` <20191021151221.GC25164-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-22 7:57 ` Daniel Vetter
2019-10-22 7:57 ` Daniel Vetter
2019-10-22 15:01 ` Jason Gunthorpe
2019-10-22 15:01 ` Jason Gunthorpe
2019-10-23 9:08 ` Daniel Vetter
2019-10-23 9:08 ` Daniel Vetter
2019-10-23 9:08 ` Daniel Vetter
2019-10-23 9:32 ` Christian König
2019-10-23 9:32 ` Christian König
2019-10-23 9:32 ` Christian König
[not found] ` <13edf841-421e-3522-fcec-ef919c2013ef-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-23 16:52 ` Jerome Glisse
2019-10-23 16:52 ` Jerome Glisse
2019-10-23 16:52 ` Jerome Glisse
2019-10-23 16:52 ` Jerome Glisse
2019-10-23 17:24 ` Jason Gunthorpe
2019-10-23 17:24 ` Jason Gunthorpe
2019-10-23 17:24 ` Jason Gunthorpe
[not found] ` <20191023172442.GX22766-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-24 2:16 ` Christoph Hellwig [this message]
2019-10-24 2:16 ` Christoph Hellwig
2019-10-24 2:16 ` Christoph Hellwig
2019-10-21 18:40 ` Jerome Glisse
2019-10-21 18:40 ` Jerome Glisse
2019-10-21 19:06 ` Jason Gunthorpe
2019-10-21 19:06 ` Jason Gunthorpe
[not found] ` <20191021190556.GI6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-23 20:26 ` Jerome Glisse
2019-10-23 20:26 ` Jerome Glisse
2019-10-23 20:26 ` Jerome Glisse
2019-10-23 20:26 ` Jerome Glisse
2019-10-21 15:55 ` Dennis Dalessandro
2019-10-21 15:55 ` Dennis Dalessandro
2019-10-21 16:58 ` Jason Gunthorpe
2019-10-21 16:58 ` Jason Gunthorpe
2019-10-22 11:56 ` Dennis Dalessandro
2019-10-22 11:56 ` Dennis Dalessandro
2019-10-22 14:37 ` Jason Gunthorpe
2019-10-22 14:37 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2019-10-17 16:44 Koenig, Christian
2019-10-17 16:44 ` Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024021625.GA5893@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=Felix.Kuehling-5C7GfCeVMHo@public.gmane.org \
--cc=Philip.Yang-5C7GfCeVMHo@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jhubbard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rcampbell-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.