* [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'
@ 2019-10-23 7:53 YueHaibing
2019-10-23 10:10 ` Chris Chiu
2019-10-24 5:49 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-10-23 7:53 UTC (permalink / raw)
To: Jes.Sorensen, kvalo, davem
Cc: linux-wireless, netdev, linux-kernel, YueHaibing
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
warning: variable rate_mask set but not used [-Wunused-but-set-variable]
It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
TX performance of RTL8723BU on rtl8xxxu driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 1e3b716..3843d7a 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -4481,11 +4481,6 @@ static u16
rtl8xxxu_wireless_mode(struct ieee80211_hw *hw, struct ieee80211_sta *sta)
{
u16 network_type = WIRELESS_MODE_UNKNOWN;
- u32 rate_mask;
-
- rate_mask = (sta->supp_rates[0] & 0xfff) |
- (sta->ht_cap.mcs.rx_mask[0] << 12) |
- (sta->ht_cap.mcs.rx_mask[0] << 20);
if (hw->conf.chandef.chan->band == NL80211_BAND_5GHZ) {
if (sta->vht_cap.vht_supported)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'
2019-10-23 7:53 [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask' YueHaibing
@ 2019-10-23 10:10 ` Chris Chiu
2019-10-23 10:16 ` Kalle Valo
2019-10-24 5:49 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Chris Chiu @ 2019-10-23 10:10 UTC (permalink / raw)
To: YueHaibing
Cc: Jes Sorensen, Kalle Valo, David Miller, linux-wireless, netdev,
Linux Kernel
On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
> warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>
> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
> TX performance of RTL8723BU on rtl8xxxu driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Singed-off-by: Chris Chiu <chiu@endlessm.com>
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index 1e3b716..3843d7a 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -4481,11 +4481,6 @@ static u16
> rtl8xxxu_wireless_mode(struct ieee80211_hw *hw, struct ieee80211_sta *sta)
> {
> u16 network_type = WIRELESS_MODE_UNKNOWN;
> - u32 rate_mask;
> -
> - rate_mask = (sta->supp_rates[0] & 0xfff) |
> - (sta->ht_cap.mcs.rx_mask[0] << 12) |
> - (sta->ht_cap.mcs.rx_mask[0] << 20);
>
> if (hw->conf.chandef.chan->band == NL80211_BAND_5GHZ) {
> if (sta->vht_cap.vht_supported)
> --
> 2.7.4
Thanks for pointing that out.
Chris
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'
2019-10-23 10:10 ` Chris Chiu
@ 2019-10-23 10:16 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-10-23 10:16 UTC (permalink / raw)
To: Chris Chiu
Cc: YueHaibing, Jes Sorensen, Kalle Valo, David Miller,
linux-wireless, netdev, Linux Kernel
Chris Chiu <chiu@endlessm.com> writes:
> On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@huawei.com> wrote:
>>
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
>> warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>>
>> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
>> TX performance of RTL8723BU on rtl8xxxu driver")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
> Singed-off-by: Chris Chiu <chiu@endlessm.com>
In the future please use Reviewed-by:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Signed-off-by is supposed to be used when you are sending a patch and
Acked-by is used by the driver maintainer, in this case Jes.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'
2019-10-23 7:53 [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask' YueHaibing
2019-10-23 10:10 ` Chris Chiu
@ 2019-10-24 5:49 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-10-24 5:49 UTC (permalink / raw)
To: YueHaibing
Cc: Jes.Sorensen, davem, linux-wireless, netdev, linux-kernel,
YueHaibing
YueHaibing <yuehaibing@huawei.com> wrote:
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
> warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>
> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
> TX performance of RTL8723BU on rtl8xxxu driver")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
4fcef8609132 rtl8xxxu: remove set but not used variable 'rate_mask'
--
https://patchwork.kernel.org/patch/11205849/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-24 5:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-23 7:53 [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask' YueHaibing
2019-10-23 10:10 ` Chris Chiu
2019-10-23 10:16 ` Kalle Valo
2019-10-24 5:49 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.