Re: [Cocci] [PATCH v2] coccicheck:support $COCCI being defined as adirectory

[<zhong.shiqi@zte.com.cn>]

[-- Attachment #1.1: Type: text/plain, Size: 1740 bytes --]

> On Thu, 24 Oct 2019, zhongshiqi wrote:
>
> > Put a modification in scripts/coccicheck which supports users in
> > configuring COCCI parameter as a directory to traverse files in
> > directory whose next level directory contains rule files with Suffix of
> > cocci.
>
> While I thought the original was fine, if we are going to strive for
> perfection, there are some things that could be changed.  First there
> should be a space in the subject line after the :
>
> Second the commit log could be more concise as:
>
> Allow defining COCCI as a directory that contains .cocci files.
>
> In general, at least in simple cases, it is not necessary to mention the
> name of the file you are modifying in the comit log, because one can see
> that just below from looking at the diffstat and the patch.
>
> thanks,
> julia
>

Thank you,it is very good for me

Best Regards,
zhong.shiqi

> >
> > Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
> > ---
> > Changes in v2:
> >         1.fix patch subject according to the reply by Markus
> >         <Markus.Elfring@web.de>
> >         2.change description in “imperative mood”
> >
> >  scripts/coccicheck | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index e04d328..a1c4197 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
> >      for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> >      coccinelle $f
> >      done
> > +elif [ -d "$COCCI" ] ; then
> > +    for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
> > +    coccinelle $f
> > +    done
> >  else
> >      coccinelle $COCCI
> >  fi
> > --
> > 2.9.5
> >
> >

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci