All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: Yi Wang <wang.yi59@zte.com.cn>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xue Zhihong <xue.zhihong@zte.com.cn>,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	Zhong Shiqi <zhong.shiqi@zte.com.cn>
Subject: Re: [Cocci] [PATCH v2] coccicheck: support $COCCI being defined as a directory
Date: Thu, 24 Oct 2019 09:55:34 +0200	[thread overview]
Message-ID: <37ad0bcd-941d-e02e-ae99-e89f2ce98ff0@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910240816040.2771@hadrien>

> Second the commit log could be more concise as:

I like your desire for choosing a more appropriate commit message.


> Allow defining COCCI as a directory that contains .cocci files.

I would prefer to concentrate the patch subject on other information.


> In general, at least in simple cases, it is not necessary to mention the
> name of the file you are modifying in the comit log, because one can see
> that just below from looking at the diffstat and the patch.

This view can be reasonable. - How does it fit to the usual requirement
for the specification of a “subsystem” (or “prefix”) according to the
canonical patch format?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=13b86bc4cd648eae69fdcf3d04b2750c76350053#n656

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: Yi Wang <wang.yi59@zte.com.cn>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xue Zhihong <xue.zhihong@zte.com.cn>,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	Zhong Shiqi <zhong.shiqi@zte.com.cn>
Subject: Re: [PATCH v2] coccicheck: support $COCCI being defined as a directory
Date: Thu, 24 Oct 2019 07:55:34 +0000	[thread overview]
Message-ID: <37ad0bcd-941d-e02e-ae99-e89f2ce98ff0@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910240816040.2771@hadrien>

> Second the commit log could be more concise as:

I like your desire for choosing a more appropriate commit message.


> Allow defining COCCI as a directory that contains .cocci files.

I would prefer to concentrate the patch subject on other information.


> In general, at least in simple cases, it is not necessary to mention the
> name of the file you are modifying in the comit log, because one can see
> that just below from looking at the diffstat and the patch.

This view can be reasonable. - How does it fit to the usual requirement
for the specification of a “subsystem” (or “prefix”) according to the
canonical patch format?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=13b86bc4cd648eae69fdcf3d04b2750c76350053#n656

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Yi Wang <wang.yi59@zte.com.cn>,
	Xue Zhihong <xue.zhihong@zte.com.cn>,
	Zhong Shiqi <zhong.shiqi@zte.com.cn>
Subject: Re: [PATCH v2] coccicheck: support $COCCI being defined as a directory
Date: Thu, 24 Oct 2019 09:55:34 +0200	[thread overview]
Message-ID: <37ad0bcd-941d-e02e-ae99-e89f2ce98ff0@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910240816040.2771@hadrien>

> Second the commit log could be more concise as:

I like your desire for choosing a more appropriate commit message.


> Allow defining COCCI as a directory that contains .cocci files.

I would prefer to concentrate the patch subject on other information.


> In general, at least in simple cases, it is not necessary to mention the
> name of the file you are modifying in the comit log, because one can see
> that just below from looking at the diffstat and the patch.

This view can be reasonable. - How does it fit to the usual requirement
for the specification of a “subsystem” (or “prefix”) according to the
canonical patch format?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=13b86bc4cd648eae69fdcf3d04b2750c76350053#n656

Regards,
Markus

  reply	other threads:[~2019-10-24  7:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  6:04 [Cocci] [PATCH v2] coccicheck:support $COCCI being defined as a directory zhongshiqi
2019-10-24  6:04 ` zhongshiqi
2019-10-24  6:19 ` [Cocci] " Julia Lawall
2019-10-24  6:19   ` Julia Lawall
2019-10-24  7:55   ` Markus Elfring [this message]
2019-10-24  7:55     ` [PATCH v2] coccicheck: support " Markus Elfring
2019-10-24  7:55     ` Markus Elfring
2019-10-24  7:58     ` [Cocci] " Julia Lawall
2019-10-24  7:58       ` Julia Lawall
2019-10-24  7:58       ` Julia Lawall
2019-10-24  9:11       ` [Cocci] [v2] " Markus Elfring
2019-10-24  9:11         ` Markus Elfring
2019-10-24  9:11         ` Markus Elfring
2019-10-24  8:02   ` [Cocci] [PATCH v2] coccicheck:support $COCCI being defined as adirectory zhong.shiqi
2019-10-24  7:06 ` [Cocci] [PATCH v2] coccicheck: support $COCCI being defined as a directory Markus Elfring
2019-10-24  7:06   ` Markus Elfring
2019-10-24  7:06   ` Markus Elfring
2019-10-24  8:03   ` [Cocci] [PATCH v2] coccicheck: support $COCCI being defined as adirectory zhong.shiqi
2019-10-24  9:23     ` [Cocci] [v2] " Markus Elfring
2019-10-24  9:23       ` Markus Elfring
2019-10-24  9:23       ` Markus Elfring
2019-10-24  9:58       ` [Cocci] " zhong.shiqi
2019-10-24 10:52         ` [Cocci] [v2] coccicheck: support $COCCI being defined as a directory Markus Elfring
2019-10-24 10:52           ` Markus Elfring
2019-10-24 10:52           ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37ad0bcd-941d-e02e-ae99-e89f2ce98ff0@web.de \
    --to=markus.elfring@web.de \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    --cc=zhong.shiqi@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.