Re: [PATCH v2 4/4] perf/x86/intel/pt: Opportunistically use single range output mode

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2811 bytes --]

Hi Alexander,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[cannot apply to v5.4-rc4 next-20191024]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Alexander-Shishkin/perf-Add-AUX-data-sampling/20191024-171433
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 27a0a90d6301dd883a748538e4db692a5fb923e1
config: x86_64-lkp (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/x86/events/intel/pt.c: In function 'pt_config':
>> arch/x86/events/intel/pt.c:495:7: error: 'buf' undeclared (first use in this function); did you mean 'btf'?
     if (!buf->single)
          ^~~
          btf
   arch/x86/events/intel/pt.c:495:7: note: each undeclared identifier is reported only once for each function it appears in

vim +495 arch/x86/events/intel/pt.c

   482	
   483	static void pt_config(struct perf_event *event)
   484	{
   485		u64 reg;
   486	
   487		/* First round: clear STATUS, in particular the PSB byte counter. */
   488		if (!event->hw.config) {
   489			perf_event_itrace_started(event);
   490			wrmsrl(MSR_IA32_RTIT_STATUS, 0);
   491		}
   492	
   493		reg = pt_config_filters(event);
   494		reg |= RTIT_CTL_TRACEEN;
 > 495		if (!buf->single)
   496			reg |= RTIT_CTL_TOPA;
   497	
   498		/*
   499		 * Previously, we had BRANCH_EN on by default, but now that PT has
   500		 * grown features outside of branch tracing, it is useful to allow
   501		 * the user to disable it. Setting bit 0 in the event's attr.config
   502		 * allows BRANCH_EN to pass through instead of being always on. See
   503		 * also the comment in pt_event_valid().
   504		 */
   505		if (event->attr.config & BIT(0)) {
   506			reg |= event->attr.config & RTIT_CTL_BRANCH_EN;
   507		} else {
   508			reg |= RTIT_CTL_BRANCH_EN;
   509		}
   510	
   511		if (!event->attr.exclude_kernel)
   512			reg |= RTIT_CTL_OS;
   513		if (!event->attr.exclude_user)
   514			reg |= RTIT_CTL_USR;
   515	
   516		reg |= (event->attr.config & PT_CONFIG_MASK);
   517	
   518		event->hw.config = reg;
   519		pt_config_start(event);
   520	}
   521	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28619 bytes --]