From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, jolsa@redhat.com,
adrian.hunter@intel.com, mathieu.poirier@linaro.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v2 4/4] perf/x86/intel/pt: Opportunistically use single range output mode
Date: Fri, 25 Oct 2019 15:19:38 +0300 [thread overview]
Message-ID: <87blu5ggpx.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20191024135632.GE4114@hirez.programming.kicks-ass.net>
Peter Zijlstra <peterz@infradead.org> writes:
> On Tue, Oct 22, 2019 at 12:58:12PM +0300, Alexander Shishkin wrote:
>> Most of PT implementations support Single Range Output mode, which is
>> an alternative to ToPA that can be used for a single contiguous buffer
>> and if we don't require an interrupt, that is, in AUX snapshot mode.
>>
>> Now that perf core will use high order allocations for the AUX buffer,
>> in many cases the first condition will also be satisfied.
>>
>> The two most obvious benefits of the Single Range Output mode over the
>> ToPA are:
>> * not having to allocate the ToPA table(s),
>> * not using the ToPA walk hardware.
>>
>> Make use of this functionality where available and appropriate.
>
> This seems independent of the snapshot stuff, right?
Yes, it depends on the previous PT driver patch for context,
though. I'll drop it from the set.
Regards,
--
Alex
next prev parent reply other threads:[~2019-10-25 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 9:58 [PATCH v2 0/4] perf: Add AUX data sampling Alexander Shishkin
2019-10-22 9:58 ` [PATCH v2 1/4] perf: Allow using AUX data in perf samples Alexander Shishkin
2019-10-24 13:52 ` Peter Zijlstra
2019-10-24 14:01 ` Peter Zijlstra
2019-10-25 12:52 ` Alexander Shishkin
2019-10-24 14:06 ` Peter Zijlstra
2019-10-25 12:21 ` Alexander Shishkin
2019-10-24 14:09 ` Peter Zijlstra
2019-10-24 14:12 ` Peter Zijlstra
2019-10-22 9:58 ` [PATCH v2 2/4] perf/x86/intel/pt: Factor out starting the trace Alexander Shishkin
2019-10-22 9:58 ` [PATCH v2 3/4] perf/x86/intel/pt: Add sampling support Alexander Shishkin
2019-10-22 9:58 ` [PATCH v2 4/4] perf/x86/intel/pt: Opportunistically use single range output mode Alexander Shishkin
2019-10-23 15:09 ` Alexander Shishkin
2019-10-24 13:56 ` Peter Zijlstra
2019-10-25 12:19 ` Alexander Shishkin [this message]
2019-10-24 17:02 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blu5ggpx.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.