From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrey Zhizhikin <andrey.z@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, lee.jones@linaro.org,
linux-kernel@vger.kernel.org,
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Subject: Re: [PATCH 2/2] mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC
Date: Fri, 25 Oct 2019 11:06:55 +0300 [thread overview]
Message-ID: <20191025080655.GF32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191024142939.25920-3-andrey.zhizhikin@leica-geosystems.com>
On Thu, Oct 24, 2019 at 02:29:39PM +0000, Andrey Zhizhikin wrote:
> Add a regulator mfd cell to Whiskey Cove PMIC driver, which is used to
> supply various voltage rails.
>
> In addition, make the initialization of this mfd driver early enough in
> order to provide regulator cell to mmc sub-system when it is initialized.
Doesn't deferred probe mechanism work for you?
MMC core returns that error till we have the driver initialized.
> + }, {
> + .name = "cht_wcove_regulator",
> + .id = CHT_WC_REGULATOR_VSDIO + 1,
> + .num_resources = 0,
> + .resources = NULL,
No need to put these.
> -static struct i2c_driver cht_wc_driver = {
> +static struct i2c_driver cht_wc_i2c_driver = {
Renaming is not explained in the commit message.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-25 8:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 14:29 [PATCH 0/2] add regulator driver and mfd cell for Intel Cherry Trail Whiskey Cove PMIC Andrey Zhizhikin
2019-10-24 14:29 ` [PATCH 1/2] regulator: add support for Intel Cherry Whiskey Cove regulator Andrey Zhizhikin
2019-10-25 8:01 ` Andy Shevchenko
2019-10-25 8:58 ` Andrey Zhizhikin
2019-10-25 9:14 ` Andy Shevchenko
2019-10-25 9:31 ` Andrey Zhizhikin
2019-10-25 10:47 ` Andy Shevchenko
2019-10-25 12:17 ` Mark Brown
2019-10-25 15:26 ` Andrey Zhizhikin
2019-10-25 16:02 ` Andy Shevchenko
2019-10-25 16:21 ` Andrey Zhizhikin
2019-10-24 14:29 ` [PATCH 2/2] mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC Andrey Zhizhikin
2019-10-25 8:06 ` Andy Shevchenko [this message]
2019-10-25 9:16 ` Andrey Zhizhikin
2019-10-25 10:49 ` Andy Shevchenko
2019-10-25 12:00 ` Andrey Zhizhikin
2019-10-25 7:53 ` [PATCH 0/2] add regulator driver and mfd cell for Intel " Andy Shevchenko
2019-10-25 7:55 ` Andy Shevchenko
2019-10-25 8:51 ` Andrey Zhizhikin
2019-10-28 12:41 ` Adrian Hunter
2019-10-28 12:45 ` Mark Brown
2019-10-28 13:26 ` Hans de Goede
2019-10-28 15:01 ` Andrey Zhizhikin
2019-10-29 12:03 ` Hans de Goede
2019-10-29 16:57 ` Andrey Zhizhikin
2019-10-29 17:14 ` Hans de Goede
2019-10-28 16:28 ` Andy Shevchenko
2019-10-28 14:40 ` Andrey Zhizhikin
2019-10-25 9:38 ` Hans de Goede
2019-10-25 10:11 ` Andrey Zhizhikin
2019-10-25 10:45 ` Hans de Goede
2019-10-25 11:54 ` Andrey Zhizhikin
2019-10-25 12:05 ` Mark Brown
2019-10-25 12:18 ` Hans de Goede
2019-10-25 10:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025080655.GF32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrey.z@gmail.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.