From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrey Zhizhikin <andrey.z@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
lgirdwood@gmail.com, broonie@kernel.org, lee.jones@linaro.org,
linux-kernel@vger.kernel.org,
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>
Subject: Re: [PATCH 1/2] regulator: add support for Intel Cherry Whiskey Cove regulator
Date: Fri, 25 Oct 2019 12:14:30 +0300 [thread overview]
Message-ID: <20191025091430.GJ32742@smile.fi.intel.com> (raw)
In-Reply-To: <CAHtQpK7e-W9cGyCan=yxM7sSN=L_SKaFy8DSNE4vQGrc_pFdQw@mail.gmail.com>
On Fri, Oct 25, 2019 at 10:58:05AM +0200, Andrey Zhizhikin wrote:
> On Fri, Oct 25, 2019 at 10:01 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Thu, Oct 24, 2019 at 02:29:38PM +0000, Andrey Zhizhikin wrote:
> > > Add regulator driver for Intel Cherry Trail Whiskey Cove PMIC, which
> > > supplies various voltage rails.
> > >
> > > This initial version supports only vsdio, which is required to source
> > > vqmmc for sd card interface.
> >
> > This patch has some style issues. I will wait for Adrian and Hans to comment on
> > the approach as a whole and then we will see how to improve the rest.
>
> Agreed, styling issues are coming from definition of CHT_WC_REGULATOR
> elements in regulators_info array, and they are mainly related to 80
> characters per line. I decided to leave it like this since it is more
> readable. But if the 80 characters rule is to be enforced here - I can
> go with something like this for every element:
> CHT_WC_REGULATOR(V3P3A, 3000, 3350, 0x00, 0x07,\
> 50, 0x01, 0x01, 0x0, true, NULL),
No, I'm not talking about these. Actually I hate this 80 limit in 21st century.
But let's not discuss it right now.
> Let's wait for other people's comments here and I can then come up
> with v2 of this patch.
Exactly!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-10-25 9:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 14:29 [PATCH 0/2] add regulator driver and mfd cell for Intel Cherry Trail Whiskey Cove PMIC Andrey Zhizhikin
2019-10-24 14:29 ` [PATCH 1/2] regulator: add support for Intel Cherry Whiskey Cove regulator Andrey Zhizhikin
2019-10-25 8:01 ` Andy Shevchenko
2019-10-25 8:58 ` Andrey Zhizhikin
2019-10-25 9:14 ` Andy Shevchenko [this message]
2019-10-25 9:31 ` Andrey Zhizhikin
2019-10-25 10:47 ` Andy Shevchenko
2019-10-25 12:17 ` Mark Brown
2019-10-25 15:26 ` Andrey Zhizhikin
2019-10-25 16:02 ` Andy Shevchenko
2019-10-25 16:21 ` Andrey Zhizhikin
2019-10-24 14:29 ` [PATCH 2/2] mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC Andrey Zhizhikin
2019-10-25 8:06 ` Andy Shevchenko
2019-10-25 9:16 ` Andrey Zhizhikin
2019-10-25 10:49 ` Andy Shevchenko
2019-10-25 12:00 ` Andrey Zhizhikin
2019-10-25 7:53 ` [PATCH 0/2] add regulator driver and mfd cell for Intel " Andy Shevchenko
2019-10-25 7:55 ` Andy Shevchenko
2019-10-25 8:51 ` Andrey Zhizhikin
2019-10-28 12:41 ` Adrian Hunter
2019-10-28 12:45 ` Mark Brown
2019-10-28 13:26 ` Hans de Goede
2019-10-28 15:01 ` Andrey Zhizhikin
2019-10-29 12:03 ` Hans de Goede
2019-10-29 16:57 ` Andrey Zhizhikin
2019-10-29 17:14 ` Hans de Goede
2019-10-28 16:28 ` Andy Shevchenko
2019-10-28 14:40 ` Andrey Zhizhikin
2019-10-25 9:38 ` Hans de Goede
2019-10-25 10:11 ` Andrey Zhizhikin
2019-10-25 10:45 ` Hans de Goede
2019-10-25 11:54 ` Andrey Zhizhikin
2019-10-25 12:05 ` Mark Brown
2019-10-25 12:18 ` Hans de Goede
2019-10-25 10:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025091430.GJ32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=andrey.z@gmail.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.