From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>,
Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
Iago Toral Quiroga <itoral@igalia.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/v3d: fix double free of bin
Date: Fri, 25 Oct 2019 11:58:20 +0000 [thread overview]
Message-ID: <20191025115819.GA7244@kadam> (raw)
In-Reply-To: <20191024123853.GH11828@phenom.ffwll.local>
On Thu, Oct 24, 2019 at 02:38:53PM +0200, Daniel Vetter wrote:
> On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Two different fixes have addressed the same memory leak of bin and
> > this now causes a double free of bin. While the individual memory
> > leak fixes are fine, both fixes together are problematic.
> >
> > Addresses-Coverity: ("Double free")
> > Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
> > Fixes: 0d352a3a8a1f (" rm/v3d: don't leak bin job if v3d_job_init fails.")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> That sounds like wrong merge resolution somewhere, and we don't have those
> patches merged together in any final tree yet anywhere. What's this based
> on?
> -Daniel
linux-next.
I sent this fix to you and Stephen Rothwell yesterday so this one is
sorted already. Stephen will apply my patch until you guys merge your
drm trees.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>,
Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
Iago Toral Quiroga <itoral@igalia.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/v3d: fix double free of bin
Date: Fri, 25 Oct 2019 14:58:20 +0300 [thread overview]
Message-ID: <20191025115819.GA7244@kadam> (raw)
In-Reply-To: <20191024123853.GH11828@phenom.ffwll.local>
On Thu, Oct 24, 2019 at 02:38:53PM +0200, Daniel Vetter wrote:
> On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Two different fixes have addressed the same memory leak of bin and
> > this now causes a double free of bin. While the individual memory
> > leak fixes are fine, both fixes together are problematic.
> >
> > Addresses-Coverity: ("Double free")
> > Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
> > Fixes: 0d352a3a8a1f (" rm/v3d: don't leak bin job if v3d_job_init fails.")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> That sounds like wrong merge resolution somewhere, and we don't have those
> patches merged together in any final tree yet anywhere. What's this based
> on?
> -Daniel
linux-next.
I sent this fix to you and Stephen Rothwell yesterday so this one is
sorted already. Stephen will apply my patch until you guys merge your
drm trees.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>,
Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
Navid Emamdoost <navid.emamdoost@gmail.com>,
Iago Toral Quiroga <itoral@igalia.com>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] drm/v3d: fix double free of bin
Date: Fri, 25 Oct 2019 14:58:20 +0300 [thread overview]
Message-ID: <20191025115819.GA7244@kadam> (raw)
In-Reply-To: <20191024123853.GH11828@phenom.ffwll.local>
On Thu, Oct 24, 2019 at 02:38:53PM +0200, Daniel Vetter wrote:
> On Thu, Oct 24, 2019 at 11:48:01AM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Two different fixes have addressed the same memory leak of bin and
> > this now causes a double free of bin. While the individual memory
> > leak fixes are fine, both fixes together are problematic.
> >
> > Addresses-Coverity: ("Double free")
> > Fixes: 29cd13cfd762 ("drm/v3d: Fix memory leak in v3d_submit_cl_ioctl")
> > Fixes: 0d352a3a8a1f (" rm/v3d: don't leak bin job if v3d_job_init fails.")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> That sounds like wrong merge resolution somewhere, and we don't have those
> patches merged together in any final tree yet anywhere. What's this based
> on?
> -Daniel
linux-next.
I sent this fix to you and Stephen Rothwell yesterday so this one is
sorted already. Stephen will apply my patch until you guys merge your
drm trees.
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-25 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 10:48 [PATCH][next] drm/v3d: fix double free of bin Colin King
2019-10-24 10:48 ` Colin King
2019-10-24 10:48 ` Colin King
2019-10-24 12:38 ` Daniel Vetter
2019-10-24 12:38 ` Daniel Vetter
2019-10-24 12:38 ` Daniel Vetter
2019-10-24 12:43 ` Colin Ian King
2019-10-24 12:43 ` Colin Ian King
2019-10-24 12:43 ` Colin Ian King
2019-10-24 12:49 ` Daniel Vetter
2019-10-24 12:49 ` Daniel Vetter
2019-10-24 12:49 ` Daniel Vetter
2019-10-24 19:51 ` Stephen Rothwell
2019-10-24 19:51 ` Stephen Rothwell
2019-10-24 19:51 ` Stephen Rothwell
2019-10-25 11:58 ` Dan Carpenter [this message]
2019-10-25 11:58 ` Dan Carpenter
2019-10-25 11:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025115819.GA7244@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=itoral@igalia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.