* [PATCH] ext2: don't set count in the case of failure
@ 2019-10-22 9:27 Chengguang Xu
2019-10-25 13:02 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2019-10-22 9:27 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, Chengguang Xu
In the case of failure, the num is still initialized value 0
so we should not set it to *count because it will bring
unexpected side effect to the caller.
Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
fs/ext2/balloc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index 18e75adcd2f6..cc516c7b7974 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -736,7 +736,6 @@ ext2_try_to_allocate(struct super_block *sb, int group,
*count = num;
return grp_goal - num;
fail_access:
- *count = num;
return -1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext2: don't set count in the case of failure
2019-10-22 9:27 [PATCH] ext2: don't set count in the case of failure Chengguang Xu
@ 2019-10-25 13:02 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2019-10-25 13:02 UTC (permalink / raw)
To: Chengguang Xu; +Cc: jack, linux-ext4
On Tue 22-10-19 17:27:20, Chengguang Xu wrote:
> In the case of failure, the num is still initialized value 0
> so we should not set it to *count because it will bring
> unexpected side effect to the caller.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Looks good to me but please ellaborate a bit in the changelog what are
visible effects of this bug. Thanks!
Honza
> ---
> fs/ext2/balloc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index 18e75adcd2f6..cc516c7b7974 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -736,7 +736,6 @@ ext2_try_to_allocate(struct super_block *sb, int group,
> *count = num;
> return grp_goal - num;
> fail_access:
> - *count = num;
> return -1;
> }
>
> --
> 2.20.1
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 13:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-22 9:27 [PATCH] ext2: don't set count in the case of failure Chengguang Xu
2019-10-25 13:02 ` Jan Kara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.