From: Borislav Petkov <bp@alien8.de>
To: "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] EDAC/amd64: Set grain per DIMM
Date: Fri, 25 Oct 2019 15:41:58 +0200 [thread overview]
Message-ID: <20191025134158.GB6483@zn.tnic> (raw)
In-Reply-To: <20191022203448.13962-7-Yazen.Ghannam@amd.com>
On Tue, Oct 22, 2019 at 08:35:14PM +0000, Ghannam, Yazen wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> The following commit introduced a warning on error reports without a
> non-zero grain value.
>
> 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
>
> The amd64_edac_mod module does not provide a value, so the warning will
> be given on the first reported memory error.
>
> Set the grain per DIMM to cacheline size (64 bytes). This is the current
> recommendation.
>
> Fixes: 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> Link:
> https://lkml.kernel.org/r/20191018153114.39378-7-Yazen.Ghannam@amd.com
>
> v1 -> v2:
> * No change.
>
> rfc -> v1:
> * New patch.
>
> drivers/edac/amd64_edac.c | 2 ++
> 1 file changed, 2 insertions(+)
This one I can take now. Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-10-25 13:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 20:35 [PATCH v2 0/6] AMD64 EDAC: Check for nodes without memory, etc Ghannam, Yazen
2019-10-22 20:35 ` [PATCH v2 1/6] EDAC/amd64: Make struct amd64_family_type global Ghannam, Yazen
2019-10-22 20:35 ` [PATCH v2 2/6] EDAC/amd64: Gather hardware information early Ghannam, Yazen
2019-10-22 20:35 ` [PATCH v2 3/6] EDAC/amd64: Save max number of controllers to family type Ghannam, Yazen
2019-10-22 20:35 ` [PATCH v2 4/6] EDAC/amd64: Use cached data when checking for ECC Ghannam, Yazen
2019-10-22 20:35 ` [PATCH v2 5/6] EDAC/amd64: Check for memory before fully initializing an instance Ghannam, Yazen
2019-10-22 20:35 ` [PATCH v2 6/6] EDAC/amd64: Set grain per DIMM Ghannam, Yazen
2019-10-25 13:41 ` Borislav Petkov [this message]
2019-10-25 13:34 ` [PATCH v2 0/6] AMD64 EDAC: Check for nodes without memory, etc Borislav Petkov
2019-11-01 15:19 ` Ghannam, Yazen
2019-11-01 15:54 ` Borislav Petkov
2019-11-05 13:38 ` Ghannam, Yazen
2019-11-05 13:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025134158.GB6483@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.