All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: hns@goldelico.com, alsa-devel@alsa-project.org,
	broonie@kernel.org, lgirdwood@gmail.com,
	jarkko.nikula@bitmer.com
Subject: Re: [alsa-devel] [PATCH v2] ASoC: ti: omap-mcpdm: Add support for pdmclk clock handling
Date: Fri, 25 Oct 2019 10:17:33 -0700	[thread overview]
Message-ID: <20191025171733.GW5607@atomide.com> (raw)
In-Reply-To: <20191025130528.3556-1-peter.ujfalusi@ti.com>

Hi,

* Peter Ujfalusi <peter.ujfalusi@ti.com> [191025 13:05]:
> McPDM module receives it's functional clock from external source. This
> clock is the pdmclk provided by the twl6040 audio IC. If the clock is not
> available all register accesses to McPDM fails and the module is not
> operational.
> 
> this has been lurking in my next-wip branch for some time...
> It might not needed anymore as I have not heard about issues with McPDM for a
> while.
> 
> It was dropped back then because some core parts were not picked in time and
> this caused some issues, but can not find the exact reason

Yes it's a strange solution to clock the internal mcpdm module
externally :)

AFAIK it's now already handled properly by ti-sysc. We have a common
omap4-mcpdm.dtsi configure mcpdm clock forthe module, then ti-sysc
driver defers probe until the mcpdm clock is available. And for omap5
we have omap5-board-common.dtsi configure it.

So probably the only thing omap-mcpdm.c driver needs to do is to
call PM runtime functions, maybe it's already doing that.

Regards,

Tony
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-10-25 17:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 13:05 [alsa-devel] [PATCH v2] ASoC: ti: omap-mcpdm: Add support for pdmclk clock handling Peter Ujfalusi
2019-10-25 17:17 ` Tony Lindgren [this message]
2019-10-25 18:55   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025171733.GW5607@atomide.com \
    --to=tony@atomide.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=hns@goldelico.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.