* [Intel-gfx] [PATCH 0/5] DP AUX updates
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
The first patch here has already been submitted and reviewed, but is
still waiting on CI results to be merged. The hope is that the final
patch in this series will solve the TGL forever-busy AUX transactions
described in https://bugs.freedesktop.org/show_bug.cgi?id=105128.
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Matt Roper (5):
drm/i915/tgl: Handle AUX interrupts for TC ports
drm/i915: Drop unused AUX register offsets
drm/i915: Add missing AUX channel H & I support
drm/i915: Provide more information on DP AUX failures
drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
drivers/gpu/drm/i915/display/intel_bios.c | 6 +++
drivers/gpu/drm/i915/display/intel_display.c | 36 ++++------------
drivers/gpu/drm/i915/display/intel_display.h | 2 +
.../drm/i915/display/intel_display_power.c | 2 +
drivers/gpu/drm/i915/display/intel_dp.c | 7 +++-
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +
drivers/gpu/drm/i915/i915_irq.c | 10 ++++-
drivers/gpu/drm/i915/i915_reg.h | 42 +++----------------
8 files changed, 40 insertions(+), 67 deletions(-)
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
We're currently only processing AUX interrupts on the combo ports; make
sure we handle the TC ports as well.
v2: Drop stale comment
Fixes: f663769a5eef ("drm/i915/tgl: initialize TC and TBT ports")
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 10 ++++++++--
drivers/gpu/drm/i915/i915_reg.h | 6 ++++++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 33020c8ca5f6..987b46d499fc 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2575,10 +2575,16 @@ static u32 gen8_de_port_aux_mask(struct drm_i915_private *dev_priv)
u32 mask;
if (INTEL_GEN(dev_priv) >= 12)
- /* TODO: Add AUX entries for USBC */
return TGL_DE_PORT_AUX_DDIA |
TGL_DE_PORT_AUX_DDIB |
- TGL_DE_PORT_AUX_DDIC;
+ TGL_DE_PORT_AUX_DDIC |
+ TGL_DE_PORT_AUX_USBC1 |
+ TGL_DE_PORT_AUX_USBC2 |
+ TGL_DE_PORT_AUX_USBC3 |
+ TGL_DE_PORT_AUX_USBC4 |
+ TGL_DE_PORT_AUX_USBC5 |
+ TGL_DE_PORT_AUX_USBC6;
+
mask = GEN8_AUX_CHANNEL_A;
if (INTEL_GEN(dev_priv) >= 9)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 746326784a4d..8cd40e7af618 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7439,6 +7439,12 @@ enum {
#define GEN8_PORT_DP_A_HOTPLUG (1 << 3)
#define BXT_DE_PORT_GMBUS (1 << 1)
#define GEN8_AUX_CHANNEL_A (1 << 0)
+#define TGL_DE_PORT_AUX_USBC6 (1 << 13)
+#define TGL_DE_PORT_AUX_USBC5 (1 << 12)
+#define TGL_DE_PORT_AUX_USBC4 (1 << 11)
+#define TGL_DE_PORT_AUX_USBC3 (1 << 10)
+#define TGL_DE_PORT_AUX_USBC2 (1 << 9)
+#define TGL_DE_PORT_AUX_USBC1 (1 << 8)
#define TGL_DE_PORT_AUX_DDIC (1 << 2)
#define TGL_DE_PORT_AUX_DDIB (1 << 1)
#define TGL_DE_PORT_AUX_DDIA (1 << 0)
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* [Intel-gfx] [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
We're currently only processing AUX interrupts on the combo ports; make
sure we handle the TC ports as well.
v2: Drop stale comment
Fixes: f663769a5eef ("drm/i915/tgl: initialize TC and TBT ports")
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 10 ++++++++--
drivers/gpu/drm/i915/i915_reg.h | 6 ++++++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 33020c8ca5f6..987b46d499fc 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2575,10 +2575,16 @@ static u32 gen8_de_port_aux_mask(struct drm_i915_private *dev_priv)
u32 mask;
if (INTEL_GEN(dev_priv) >= 12)
- /* TODO: Add AUX entries for USBC */
return TGL_DE_PORT_AUX_DDIA |
TGL_DE_PORT_AUX_DDIB |
- TGL_DE_PORT_AUX_DDIC;
+ TGL_DE_PORT_AUX_DDIC |
+ TGL_DE_PORT_AUX_USBC1 |
+ TGL_DE_PORT_AUX_USBC2 |
+ TGL_DE_PORT_AUX_USBC3 |
+ TGL_DE_PORT_AUX_USBC4 |
+ TGL_DE_PORT_AUX_USBC5 |
+ TGL_DE_PORT_AUX_USBC6;
+
mask = GEN8_AUX_CHANNEL_A;
if (INTEL_GEN(dev_priv) >= 9)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 746326784a4d..8cd40e7af618 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7439,6 +7439,12 @@ enum {
#define GEN8_PORT_DP_A_HOTPLUG (1 << 3)
#define BXT_DE_PORT_GMBUS (1 << 1)
#define GEN8_AUX_CHANNEL_A (1 << 0)
+#define TGL_DE_PORT_AUX_USBC6 (1 << 13)
+#define TGL_DE_PORT_AUX_USBC5 (1 << 12)
+#define TGL_DE_PORT_AUX_USBC4 (1 << 11)
+#define TGL_DE_PORT_AUX_USBC3 (1 << 10)
+#define TGL_DE_PORT_AUX_USBC2 (1 << 9)
+#define TGL_DE_PORT_AUX_USBC1 (1 << 8)
#define TGL_DE_PORT_AUX_DDIC (1 << 2)
#define TGL_DE_PORT_AUX_DDIB (1 << 1)
#define TGL_DE_PORT_AUX_DDIA (1 << 0)
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* Re: [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports
@ 2019-10-25 23:11 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:11 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:19PM -0700, Matt Roper wrote:
>We're currently only processing AUX interrupts on the combo ports; make
>sure we handle the TC ports as well.
>
>v2: Drop stale comment
>
>Fixes: f663769a5eef ("drm/i915/tgl: initialize TC and TBT ports")
>Cc: José Roberto de Souza <jose.souza@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/i915_irq.c | 10 ++++++++--
> drivers/gpu/drm/i915/i915_reg.h | 6 ++++++
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
>index 33020c8ca5f6..987b46d499fc 100644
>--- a/drivers/gpu/drm/i915/i915_irq.c
>+++ b/drivers/gpu/drm/i915/i915_irq.c
>@@ -2575,10 +2575,16 @@ static u32 gen8_de_port_aux_mask(struct drm_i915_private *dev_priv)
> u32 mask;
>
> if (INTEL_GEN(dev_priv) >= 12)
>- /* TODO: Add AUX entries for USBC */
> return TGL_DE_PORT_AUX_DDIA |
> TGL_DE_PORT_AUX_DDIB |
>- TGL_DE_PORT_AUX_DDIC;
>+ TGL_DE_PORT_AUX_DDIC |
>+ TGL_DE_PORT_AUX_USBC1 |
>+ TGL_DE_PORT_AUX_USBC2 |
>+ TGL_DE_PORT_AUX_USBC3 |
>+ TGL_DE_PORT_AUX_USBC4 |
>+ TGL_DE_PORT_AUX_USBC5 |
>+ TGL_DE_PORT_AUX_USBC6;
>+
>
> mask = GEN8_AUX_CHANNEL_A;
> if (INTEL_GEN(dev_priv) >= 9)
>diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>index 746326784a4d..8cd40e7af618 100644
>--- a/drivers/gpu/drm/i915/i915_reg.h
>+++ b/drivers/gpu/drm/i915/i915_reg.h
>@@ -7439,6 +7439,12 @@ enum {
> #define GEN8_PORT_DP_A_HOTPLUG (1 << 3)
> #define BXT_DE_PORT_GMBUS (1 << 1)
> #define GEN8_AUX_CHANNEL_A (1 << 0)
>+#define TGL_DE_PORT_AUX_USBC6 (1 << 13)
>+#define TGL_DE_PORT_AUX_USBC5 (1 << 12)
>+#define TGL_DE_PORT_AUX_USBC4 (1 << 11)
>+#define TGL_DE_PORT_AUX_USBC3 (1 << 10)
>+#define TGL_DE_PORT_AUX_USBC2 (1 << 9)
>+#define TGL_DE_PORT_AUX_USBC1 (1 << 8)
> #define TGL_DE_PORT_AUX_DDIC (1 << 2)
> #define TGL_DE_PORT_AUX_DDIB (1 << 1)
> #define TGL_DE_PORT_AUX_DDIA (1 << 0)
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 1/5] drm/i915/tgl: Handle AUX interrupts for TC ports
@ 2019-10-25 23:11 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:11 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:19PM -0700, Matt Roper wrote:
>We're currently only processing AUX interrupts on the combo ports; make
>sure we handle the TC ports as well.
>
>v2: Drop stale comment
>
>Fixes: f663769a5eef ("drm/i915/tgl: initialize TC and TBT ports")
>Cc: José Roberto de Souza <jose.souza@intel.com>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/i915_irq.c | 10 ++++++++--
> drivers/gpu/drm/i915/i915_reg.h | 6 ++++++
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
>index 33020c8ca5f6..987b46d499fc 100644
>--- a/drivers/gpu/drm/i915/i915_irq.c
>+++ b/drivers/gpu/drm/i915/i915_irq.c
>@@ -2575,10 +2575,16 @@ static u32 gen8_de_port_aux_mask(struct drm_i915_private *dev_priv)
> u32 mask;
>
> if (INTEL_GEN(dev_priv) >= 12)
>- /* TODO: Add AUX entries for USBC */
> return TGL_DE_PORT_AUX_DDIA |
> TGL_DE_PORT_AUX_DDIB |
>- TGL_DE_PORT_AUX_DDIC;
>+ TGL_DE_PORT_AUX_DDIC |
>+ TGL_DE_PORT_AUX_USBC1 |
>+ TGL_DE_PORT_AUX_USBC2 |
>+ TGL_DE_PORT_AUX_USBC3 |
>+ TGL_DE_PORT_AUX_USBC4 |
>+ TGL_DE_PORT_AUX_USBC5 |
>+ TGL_DE_PORT_AUX_USBC6;
>+
>
> mask = GEN8_AUX_CHANNEL_A;
> if (INTEL_GEN(dev_priv) >= 9)
>diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>index 746326784a4d..8cd40e7af618 100644
>--- a/drivers/gpu/drm/i915/i915_reg.h
>+++ b/drivers/gpu/drm/i915/i915_reg.h
>@@ -7439,6 +7439,12 @@ enum {
> #define GEN8_PORT_DP_A_HOTPLUG (1 << 3)
> #define BXT_DE_PORT_GMBUS (1 << 1)
> #define GEN8_AUX_CHANNEL_A (1 << 0)
>+#define TGL_DE_PORT_AUX_USBC6 (1 << 13)
>+#define TGL_DE_PORT_AUX_USBC5 (1 << 12)
>+#define TGL_DE_PORT_AUX_USBC4 (1 << 11)
>+#define TGL_DE_PORT_AUX_USBC3 (1 << 10)
>+#define TGL_DE_PORT_AUX_USBC2 (1 << 9)
>+#define TGL_DE_PORT_AUX_USBC1 (1 << 8)
> #define TGL_DE_PORT_AUX_DDIC (1 << 2)
> #define TGL_DE_PORT_AUX_DDIB (1 << 1)
> #define TGL_DE_PORT_AUX_DDIA (1 << 0)
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 2/5] drm/i915: Drop unused AUX register offsets
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
We reference DP AUX registers via the DP_AUX_CH_CTL() and
DP_AUX_CH_DATA() macros that calculate all the register offsets for us
automatically; there's no need to explicitly define every offset in
i915_reg.h if they're never going to be used by the driver code.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 36 ---------------------------------
1 file changed, 36 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8cd40e7af618..cbf6df002771 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -5538,45 +5538,9 @@ enum {
*/
#define _DPA_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64010)
#define _DPA_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64014)
-#define _DPA_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64018)
-#define _DPA_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6401c)
-#define _DPA_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64020)
-#define _DPA_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64024)
#define _DPB_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64110)
#define _DPB_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64114)
-#define _DPB_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64118)
-#define _DPB_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6411c)
-#define _DPB_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64120)
-#define _DPB_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64124)
-
-#define _DPC_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64210)
-#define _DPC_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64214)
-#define _DPC_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64218)
-#define _DPC_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6421c)
-#define _DPC_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64220)
-#define _DPC_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64224)
-
-#define _DPD_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64310)
-#define _DPD_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64314)
-#define _DPD_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64318)
-#define _DPD_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6431c)
-#define _DPD_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64320)
-#define _DPD_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64324)
-
-#define _DPE_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64410)
-#define _DPE_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64414)
-#define _DPE_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64418)
-#define _DPE_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6441c)
-#define _DPE_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64420)
-#define _DPE_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64424)
-
-#define _DPF_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64510)
-#define _DPF_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64514)
-#define _DPF_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64518)
-#define _DPF_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6451c)
-#define _DPF_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64520)
-#define _DPF_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64524)
#define DP_AUX_CH_CTL(aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)
#define DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4) /* 5 registers */
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* [Intel-gfx] [PATCH 2/5] drm/i915: Drop unused AUX register offsets
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
We reference DP AUX registers via the DP_AUX_CH_CTL() and
DP_AUX_CH_DATA() macros that calculate all the register offsets for us
automatically; there's no need to explicitly define every offset in
i915_reg.h if they're never going to be used by the driver code.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 36 ---------------------------------
1 file changed, 36 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8cd40e7af618..cbf6df002771 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -5538,45 +5538,9 @@ enum {
*/
#define _DPA_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64010)
#define _DPA_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64014)
-#define _DPA_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64018)
-#define _DPA_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6401c)
-#define _DPA_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64020)
-#define _DPA_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64024)
#define _DPB_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64110)
#define _DPB_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64114)
-#define _DPB_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64118)
-#define _DPB_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6411c)
-#define _DPB_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64120)
-#define _DPB_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64124)
-
-#define _DPC_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64210)
-#define _DPC_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64214)
-#define _DPC_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64218)
-#define _DPC_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6421c)
-#define _DPC_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64220)
-#define _DPC_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64224)
-
-#define _DPD_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64310)
-#define _DPD_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64314)
-#define _DPD_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64318)
-#define _DPD_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6431c)
-#define _DPD_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64320)
-#define _DPD_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64324)
-
-#define _DPE_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64410)
-#define _DPE_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64414)
-#define _DPE_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64418)
-#define _DPE_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6441c)
-#define _DPE_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64420)
-#define _DPE_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64424)
-
-#define _DPF_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64510)
-#define _DPF_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64514)
-#define _DPF_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64518)
-#define _DPF_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6451c)
-#define _DPF_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64520)
-#define _DPF_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64524)
#define DP_AUX_CH_CTL(aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)
#define DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4) /* 5 registers */
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* Re: [PATCH 2/5] drm/i915: Drop unused AUX register offsets
@ 2019-10-25 23:11 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:11 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:20PM -0700, Matt Roper wrote:
>We reference DP AUX registers via the DP_AUX_CH_CTL() and
>DP_AUX_CH_DATA() macros that calculate all the register offsets for us
>automatically; there's no need to explicitly define every offset in
>i915_reg.h if they're never going to be used by the driver code.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/i915_reg.h | 36 ---------------------------------
> 1 file changed, 36 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>index 8cd40e7af618..cbf6df002771 100644
>--- a/drivers/gpu/drm/i915/i915_reg.h
>+++ b/drivers/gpu/drm/i915/i915_reg.h
>@@ -5538,45 +5538,9 @@ enum {
> */
> #define _DPA_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64010)
> #define _DPA_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64014)
>-#define _DPA_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64018)
>-#define _DPA_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6401c)
>-#define _DPA_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64020)
>-#define _DPA_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64024)
>
> #define _DPB_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64110)
> #define _DPB_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64114)
>-#define _DPB_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64118)
>-#define _DPB_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6411c)
>-#define _DPB_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64120)
>-#define _DPB_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64124)
>-
>-#define _DPC_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64210)
>-#define _DPC_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64214)
>-#define _DPC_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64218)
>-#define _DPC_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6421c)
>-#define _DPC_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64220)
>-#define _DPC_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64224)
>-
>-#define _DPD_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64310)
>-#define _DPD_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64314)
>-#define _DPD_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64318)
>-#define _DPD_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6431c)
>-#define _DPD_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64320)
>-#define _DPD_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64324)
>-
>-#define _DPE_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64410)
>-#define _DPE_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64414)
>-#define _DPE_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64418)
>-#define _DPE_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6441c)
>-#define _DPE_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64420)
>-#define _DPE_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64424)
>-
>-#define _DPF_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64510)
>-#define _DPF_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64514)
>-#define _DPF_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64518)
>-#define _DPF_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6451c)
>-#define _DPF_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64520)
>-#define _DPF_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64524)
>
> #define DP_AUX_CH_CTL(aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)
> #define DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4) /* 5 registers */
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 2/5] drm/i915: Drop unused AUX register offsets
@ 2019-10-25 23:11 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:11 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:20PM -0700, Matt Roper wrote:
>We reference DP AUX registers via the DP_AUX_CH_CTL() and
>DP_AUX_CH_DATA() macros that calculate all the register offsets for us
>automatically; there's no need to explicitly define every offset in
>i915_reg.h if they're never going to be used by the driver code.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/i915_reg.h | 36 ---------------------------------
> 1 file changed, 36 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>index 8cd40e7af618..cbf6df002771 100644
>--- a/drivers/gpu/drm/i915/i915_reg.h
>+++ b/drivers/gpu/drm/i915/i915_reg.h
>@@ -5538,45 +5538,9 @@ enum {
> */
> #define _DPA_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64010)
> #define _DPA_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64014)
>-#define _DPA_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64018)
>-#define _DPA_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6401c)
>-#define _DPA_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64020)
>-#define _DPA_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64024)
>
> #define _DPB_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64110)
> #define _DPB_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64114)
>-#define _DPB_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64118)
>-#define _DPB_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6411c)
>-#define _DPB_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64120)
>-#define _DPB_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64124)
>-
>-#define _DPC_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64210)
>-#define _DPC_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64214)
>-#define _DPC_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64218)
>-#define _DPC_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6421c)
>-#define _DPC_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64220)
>-#define _DPC_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64224)
>-
>-#define _DPD_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64310)
>-#define _DPD_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64314)
>-#define _DPD_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64318)
>-#define _DPD_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6431c)
>-#define _DPD_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64320)
>-#define _DPD_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64324)
>-
>-#define _DPE_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64410)
>-#define _DPE_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64414)
>-#define _DPE_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64418)
>-#define _DPE_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6441c)
>-#define _DPE_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64420)
>-#define _DPE_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64424)
>-
>-#define _DPF_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64510)
>-#define _DPF_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64514)
>-#define _DPF_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64518)
>-#define _DPF_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6451c)
>-#define _DPF_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64520)
>-#define _DPF_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64524)
>
> #define DP_AUX_CH_CTL(aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)
> #define DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4) /* 5 registers */
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 2/5] drm/i915: Drop unused AUX register offsets
@ 2019-10-26 5:12 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-26 5:12 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
We reference DP AUX registers via the DP_AUX_CH_CTL() and
DP_AUX_CH_DATA() macros that calculate all the register offsets for us
automatically; there's no need to explicitly define every offset in
i915_reg.h if they're never going to be used by the driver code.
v2: Apparently GVT was directly using these raw definitions in a couple
places. Switch GVT code over to using our preferred macros.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> #v1
---
drivers/gpu/drm/i915/gvt/handlers.c | 17 ++++++++------
drivers/gpu/drm/i915/i915_reg.h | 36 -----------------------------
2 files changed, 10 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 45a9124e53b6..afd7f66bdc2d 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -819,13 +819,16 @@ static int trigger_aux_channel_interrupt(struct intel_vgpu *vgpu,
struct drm_i915_private *dev_priv = vgpu->gvt->dev_priv;
enum intel_gvt_event_type event;
- if (reg == _DPA_AUX_CH_CTL)
+ if (reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_A)))
event = AUX_CHANNEL_A;
- else if (reg == _PCH_DPB_AUX_CH_CTL || reg == _DPB_AUX_CH_CTL)
+ else if (reg == _PCH_DPB_AUX_CH_CTL ||
+ reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_B)))
event = AUX_CHANNEL_B;
- else if (reg == _PCH_DPC_AUX_CH_CTL || reg == _DPC_AUX_CH_CTL)
+ else if (reg == _PCH_DPC_AUX_CH_CTL ||
+ reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_C)))
event = AUX_CHANNEL_C;
- else if (reg == _PCH_DPD_AUX_CH_CTL || reg == _DPD_AUX_CH_CTL)
+ else if (reg == _PCH_DPD_AUX_CH_CTL ||
+ reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_D)))
event = AUX_CHANNEL_D;
else {
WARN_ON(true);
@@ -2872,11 +2875,11 @@ static int init_skl_mmio_info(struct intel_gvt *gvt)
MMIO_DH(FORCEWAKE_MEDIA_GEN9, D_SKL_PLUS, NULL, mul_force_wake_write);
MMIO_DH(FORCEWAKE_ACK_MEDIA_GEN9, D_SKL_PLUS, NULL, NULL);
- MMIO_F(_MMIO(_DPB_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
- MMIO_F(_MMIO(_DPC_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
- MMIO_F(_MMIO(_DPD_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
MMIO_D(HSW_PWR_WELL_CTL1, D_SKL_PLUS);
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8cd40e7af618..cbf6df002771 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -5538,45 +5538,9 @@ enum {
*/
#define _DPA_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64010)
#define _DPA_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64014)
-#define _DPA_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64018)
-#define _DPA_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6401c)
-#define _DPA_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64020)
-#define _DPA_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64024)
#define _DPB_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64110)
#define _DPB_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64114)
-#define _DPB_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64118)
-#define _DPB_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6411c)
-#define _DPB_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64120)
-#define _DPB_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64124)
-
-#define _DPC_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64210)
-#define _DPC_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64214)
-#define _DPC_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64218)
-#define _DPC_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6421c)
-#define _DPC_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64220)
-#define _DPC_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64224)
-
-#define _DPD_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64310)
-#define _DPD_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64314)
-#define _DPD_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64318)
-#define _DPD_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6431c)
-#define _DPD_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64320)
-#define _DPD_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64324)
-
-#define _DPE_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64410)
-#define _DPE_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64414)
-#define _DPE_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64418)
-#define _DPE_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6441c)
-#define _DPE_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64420)
-#define _DPE_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64424)
-
-#define _DPF_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64510)
-#define _DPF_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64514)
-#define _DPF_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64518)
-#define _DPF_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6451c)
-#define _DPF_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64520)
-#define _DPF_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64524)
#define DP_AUX_CH_CTL(aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)
#define DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4) /* 5 registers */
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* [Intel-gfx] [PATCH 2/5] drm/i915: Drop unused AUX register offsets
@ 2019-10-26 5:12 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-26 5:12 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
We reference DP AUX registers via the DP_AUX_CH_CTL() and
DP_AUX_CH_DATA() macros that calculate all the register offsets for us
automatically; there's no need to explicitly define every offset in
i915_reg.h if they're never going to be used by the driver code.
v2: Apparently GVT was directly using these raw definitions in a couple
places. Switch GVT code over to using our preferred macros.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> #v1
---
drivers/gpu/drm/i915/gvt/handlers.c | 17 ++++++++------
drivers/gpu/drm/i915/i915_reg.h | 36 -----------------------------
2 files changed, 10 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 45a9124e53b6..afd7f66bdc2d 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -819,13 +819,16 @@ static int trigger_aux_channel_interrupt(struct intel_vgpu *vgpu,
struct drm_i915_private *dev_priv = vgpu->gvt->dev_priv;
enum intel_gvt_event_type event;
- if (reg == _DPA_AUX_CH_CTL)
+ if (reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_A)))
event = AUX_CHANNEL_A;
- else if (reg == _PCH_DPB_AUX_CH_CTL || reg == _DPB_AUX_CH_CTL)
+ else if (reg == _PCH_DPB_AUX_CH_CTL ||
+ reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_B)))
event = AUX_CHANNEL_B;
- else if (reg == _PCH_DPC_AUX_CH_CTL || reg == _DPC_AUX_CH_CTL)
+ else if (reg == _PCH_DPC_AUX_CH_CTL ||
+ reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_C)))
event = AUX_CHANNEL_C;
- else if (reg == _PCH_DPD_AUX_CH_CTL || reg == _DPD_AUX_CH_CTL)
+ else if (reg == _PCH_DPD_AUX_CH_CTL ||
+ reg == i915_mmio_reg_offset(DP_AUX_CH_CTL(AUX_CH_D)))
event = AUX_CHANNEL_D;
else {
WARN_ON(true);
@@ -2872,11 +2875,11 @@ static int init_skl_mmio_info(struct intel_gvt *gvt)
MMIO_DH(FORCEWAKE_MEDIA_GEN9, D_SKL_PLUS, NULL, mul_force_wake_write);
MMIO_DH(FORCEWAKE_ACK_MEDIA_GEN9, D_SKL_PLUS, NULL, NULL);
- MMIO_F(_MMIO(_DPB_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
- MMIO_F(_MMIO(_DPC_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
- MMIO_F(_MMIO(_DPD_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
MMIO_D(HSW_PWR_WELL_CTL1, D_SKL_PLUS);
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 8cd40e7af618..cbf6df002771 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -5538,45 +5538,9 @@ enum {
*/
#define _DPA_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64010)
#define _DPA_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64014)
-#define _DPA_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64018)
-#define _DPA_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6401c)
-#define _DPA_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64020)
-#define _DPA_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64024)
#define _DPB_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64110)
#define _DPB_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64114)
-#define _DPB_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64118)
-#define _DPB_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6411c)
-#define _DPB_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64120)
-#define _DPB_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64124)
-
-#define _DPC_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64210)
-#define _DPC_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64214)
-#define _DPC_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64218)
-#define _DPC_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6421c)
-#define _DPC_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64220)
-#define _DPC_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64224)
-
-#define _DPD_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64310)
-#define _DPD_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64314)
-#define _DPD_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64318)
-#define _DPD_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6431c)
-#define _DPD_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64320)
-#define _DPD_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64324)
-
-#define _DPE_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64410)
-#define _DPE_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64414)
-#define _DPE_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64418)
-#define _DPE_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6441c)
-#define _DPE_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64420)
-#define _DPE_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64424)
-
-#define _DPF_AUX_CH_CTL (DISPLAY_MMIO_BASE(dev_priv) + 0x64510)
-#define _DPF_AUX_CH_DATA1 (DISPLAY_MMIO_BASE(dev_priv) + 0x64514)
-#define _DPF_AUX_CH_DATA2 (DISPLAY_MMIO_BASE(dev_priv) + 0x64518)
-#define _DPF_AUX_CH_DATA3 (DISPLAY_MMIO_BASE(dev_priv) + 0x6451c)
-#define _DPF_AUX_CH_DATA4 (DISPLAY_MMIO_BASE(dev_priv) + 0x64520)
-#define _DPF_AUX_CH_DATA5 (DISPLAY_MMIO_BASE(dev_priv) + 0x64524)
#define DP_AUX_CH_CTL(aux_ch) _MMIO_PORT(aux_ch, _DPA_AUX_CH_CTL, _DPB_AUX_CH_CTL)
#define DP_AUX_CH_DATA(aux_ch, i) _MMIO(_PORT(aux_ch, _DPA_AUX_CH_DATA1, _DPB_AUX_CH_DATA1) + (i) * 4) /* 5 registers */
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
TGL's extra ports also bring extra AUX channels.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
drivers/gpu/drm/i915/display/intel_display.h | 2 ++
drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
5 files changed, 22 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index fe302338b7fd..3867b41338a7 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
case DP_AUX_G:
aux_ch = AUX_CH_G;
break;
+ case DP_AUX_H:
+ aux_ch = AUX_CH_H;
+ break;
+ case DP_AUX_I:
+ aux_ch = AUX_CH_I;
+ break;
default:
MISSING_CASE(info->alternate_aux_channel);
aux_ch = AUX_CH_A;
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index cbf9cf30050c..e45ed0c07d0d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
if (intel_phy_is_tc(dev_priv, phy) &&
dig_port->tc_mode == TC_PORT_TBT_ALT) {
- switch (dig_port->aux_ch) {
- case AUX_CH_C:
- return POWER_DOMAIN_AUX_C_TBT;
- case AUX_CH_D:
- return POWER_DOMAIN_AUX_D_TBT;
- case AUX_CH_E:
- return POWER_DOMAIN_AUX_E_TBT;
- case AUX_CH_F:
- return POWER_DOMAIN_AUX_F_TBT;
- case AUX_CH_G:
- return POWER_DOMAIN_AUX_G_TBT;
- default:
+ if (dig_port->aux_ch >= AUX_CH_C &&
+ dig_port->aux_ch <= AUX_CH_I) {
+ return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
+ AUX_CH_C;
+ } else {
MISSING_CASE(dig_port->aux_ch);
return POWER_DOMAIN_AUX_C_TBT;
}
}
- switch (dig_port->aux_ch) {
- case AUX_CH_A:
- return POWER_DOMAIN_AUX_A;
- case AUX_CH_B:
- return POWER_DOMAIN_AUX_B;
- case AUX_CH_C:
- return POWER_DOMAIN_AUX_C;
- case AUX_CH_D:
- return POWER_DOMAIN_AUX_D;
- case AUX_CH_E:
- return POWER_DOMAIN_AUX_E;
- case AUX_CH_F:
- return POWER_DOMAIN_AUX_F;
- case AUX_CH_G:
- return POWER_DOMAIN_AUX_G;
- default:
+ if (dig_port->aux_ch <= AUX_CH_I) {
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
MISSING_CASE(dig_port->aux_ch);
return POWER_DOMAIN_AUX_A;
}
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index ca7ca2804d8b..9ccaae41a8ad 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -275,6 +275,8 @@ enum aux_ch {
AUX_CH_E, /* ICL+ */
AUX_CH_F,
AUX_CH_G,
+ AUX_CH_H,
+ AUX_CH_I,
};
#define aux_ch_name(a) ((a) + 'A')
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 86989ec25bc6..65bab46f7b43 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
case AUX_CH_E:
case AUX_CH_F:
case AUX_CH_G:
+ case AUX_CH_H:
+ case AUX_CH_I:
return DP_AUX_CH_CTL(aux_ch);
default:
MISSING_CASE(aux_ch);
@@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
case AUX_CH_E:
case AUX_CH_F:
case AUX_CH_G:
+ case AUX_CH_H:
+ case AUX_CH_I:
return DP_AUX_CH_DATA(aux_ch, index);
default:
MISSING_CASE(aux_ch);
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index e7057f53866a..49caa066061d 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
#define DP_AUX_E 0x50
#define DP_AUX_F 0x60
#define DP_AUX_G 0x70
+#define DP_AUX_H 0x80
+#define DP_AUX_I 0x90
#define VBT_DP_MAX_LINK_RATE_HBR3 0
#define VBT_DP_MAX_LINK_RATE_HBR2 1
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* [Intel-gfx] [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
TGL's extra ports also bring extra AUX channels.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
drivers/gpu/drm/i915/display/intel_display.h | 2 ++
drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
5 files changed, 22 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
index fe302338b7fd..3867b41338a7 100644
--- a/drivers/gpu/drm/i915/display/intel_bios.c
+++ b/drivers/gpu/drm/i915/display/intel_bios.c
@@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
case DP_AUX_G:
aux_ch = AUX_CH_G;
break;
+ case DP_AUX_H:
+ aux_ch = AUX_CH_H;
+ break;
+ case DP_AUX_I:
+ aux_ch = AUX_CH_I;
+ break;
default:
MISSING_CASE(info->alternate_aux_channel);
aux_ch = AUX_CH_A;
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index cbf9cf30050c..e45ed0c07d0d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
if (intel_phy_is_tc(dev_priv, phy) &&
dig_port->tc_mode == TC_PORT_TBT_ALT) {
- switch (dig_port->aux_ch) {
- case AUX_CH_C:
- return POWER_DOMAIN_AUX_C_TBT;
- case AUX_CH_D:
- return POWER_DOMAIN_AUX_D_TBT;
- case AUX_CH_E:
- return POWER_DOMAIN_AUX_E_TBT;
- case AUX_CH_F:
- return POWER_DOMAIN_AUX_F_TBT;
- case AUX_CH_G:
- return POWER_DOMAIN_AUX_G_TBT;
- default:
+ if (dig_port->aux_ch >= AUX_CH_C &&
+ dig_port->aux_ch <= AUX_CH_I) {
+ return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
+ AUX_CH_C;
+ } else {
MISSING_CASE(dig_port->aux_ch);
return POWER_DOMAIN_AUX_C_TBT;
}
}
- switch (dig_port->aux_ch) {
- case AUX_CH_A:
- return POWER_DOMAIN_AUX_A;
- case AUX_CH_B:
- return POWER_DOMAIN_AUX_B;
- case AUX_CH_C:
- return POWER_DOMAIN_AUX_C;
- case AUX_CH_D:
- return POWER_DOMAIN_AUX_D;
- case AUX_CH_E:
- return POWER_DOMAIN_AUX_E;
- case AUX_CH_F:
- return POWER_DOMAIN_AUX_F;
- case AUX_CH_G:
- return POWER_DOMAIN_AUX_G;
- default:
+ if (dig_port->aux_ch <= AUX_CH_I) {
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
MISSING_CASE(dig_port->aux_ch);
return POWER_DOMAIN_AUX_A;
}
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
index ca7ca2804d8b..9ccaae41a8ad 100644
--- a/drivers/gpu/drm/i915/display/intel_display.h
+++ b/drivers/gpu/drm/i915/display/intel_display.h
@@ -275,6 +275,8 @@ enum aux_ch {
AUX_CH_E, /* ICL+ */
AUX_CH_F,
AUX_CH_G,
+ AUX_CH_H,
+ AUX_CH_I,
};
#define aux_ch_name(a) ((a) + 'A')
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 86989ec25bc6..65bab46f7b43 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
case AUX_CH_E:
case AUX_CH_F:
case AUX_CH_G:
+ case AUX_CH_H:
+ case AUX_CH_I:
return DP_AUX_CH_CTL(aux_ch);
default:
MISSING_CASE(aux_ch);
@@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
case AUX_CH_E:
case AUX_CH_F:
case AUX_CH_G:
+ case AUX_CH_H:
+ case AUX_CH_I:
return DP_AUX_CH_DATA(aux_ch, index);
default:
MISSING_CASE(aux_ch);
diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
index e7057f53866a..49caa066061d 100644
--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
@@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
#define DP_AUX_E 0x50
#define DP_AUX_F 0x60
#define DP_AUX_G 0x70
+#define DP_AUX_H 0x80
+#define DP_AUX_I 0x90
#define VBT_DP_MAX_LINK_RATE_HBR3 0
#define VBT_DP_MAX_LINK_RATE_HBR2 1
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* Re: [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-25 23:13 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:13 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote:
>TGL's extra ports also bring extra AUX channels.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
> drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
> drivers/gpu/drm/i915/display/intel_display.h | 2 ++
> drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> 5 files changed, 22 insertions(+), 28 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>index fe302338b7fd..3867b41338a7 100644
>--- a/drivers/gpu/drm/i915/display/intel_bios.c
>+++ b/drivers/gpu/drm/i915/display/intel_bios.c
>@@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
> case DP_AUX_G:
> aux_ch = AUX_CH_G;
> break;
>+ case DP_AUX_H:
>+ aux_ch = AUX_CH_H;
>+ break;
>+ case DP_AUX_I:
>+ aux_ch = AUX_CH_I;
>+ break;
I'd rather drop H/I from all other places since we are not using them.
Lucas De Marchi
> default:
> MISSING_CASE(info->alternate_aux_channel);
> aux_ch = AUX_CH_A;
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>index cbf9cf30050c..e45ed0c07d0d 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
>
> if (intel_phy_is_tc(dev_priv, phy) &&
> dig_port->tc_mode == TC_PORT_TBT_ALT) {
>- switch (dig_port->aux_ch) {
>- case AUX_CH_C:
>- return POWER_DOMAIN_AUX_C_TBT;
>- case AUX_CH_D:
>- return POWER_DOMAIN_AUX_D_TBT;
>- case AUX_CH_E:
>- return POWER_DOMAIN_AUX_E_TBT;
>- case AUX_CH_F:
>- return POWER_DOMAIN_AUX_F_TBT;
>- case AUX_CH_G:
>- return POWER_DOMAIN_AUX_G_TBT;
>- default:
>+ if (dig_port->aux_ch >= AUX_CH_C &&
>+ dig_port->aux_ch <= AUX_CH_I) {
>+ return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
>+ AUX_CH_C;
>+ } else {
> MISSING_CASE(dig_port->aux_ch);
> return POWER_DOMAIN_AUX_C_TBT;
> }
> }
>
>- switch (dig_port->aux_ch) {
>- case AUX_CH_A:
>- return POWER_DOMAIN_AUX_A;
>- case AUX_CH_B:
>- return POWER_DOMAIN_AUX_B;
>- case AUX_CH_C:
>- return POWER_DOMAIN_AUX_C;
>- case AUX_CH_D:
>- return POWER_DOMAIN_AUX_D;
>- case AUX_CH_E:
>- return POWER_DOMAIN_AUX_E;
>- case AUX_CH_F:
>- return POWER_DOMAIN_AUX_F;
>- case AUX_CH_G:
>- return POWER_DOMAIN_AUX_G;
>- default:
>+ if (dig_port->aux_ch <= AUX_CH_I) {
>+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
>+ } else {
> MISSING_CASE(dig_port->aux_ch);
> return POWER_DOMAIN_AUX_A;
> }
>diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>index ca7ca2804d8b..9ccaae41a8ad 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.h
>+++ b/drivers/gpu/drm/i915/display/intel_display.h
>@@ -275,6 +275,8 @@ enum aux_ch {
> AUX_CH_E, /* ICL+ */
> AUX_CH_F,
> AUX_CH_G,
>+ AUX_CH_H,
>+ AUX_CH_I,
> };
>
> #define aux_ch_name(a) ((a) + 'A')
>diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>index 86989ec25bc6..65bab46f7b43 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp.c
>@@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
> case AUX_CH_E:
> case AUX_CH_F:
> case AUX_CH_G:
>+ case AUX_CH_H:
>+ case AUX_CH_I:
> return DP_AUX_CH_CTL(aux_ch);
> default:
> MISSING_CASE(aux_ch);
>@@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
> case AUX_CH_E:
> case AUX_CH_F:
> case AUX_CH_G:
>+ case AUX_CH_H:
>+ case AUX_CH_I:
> return DP_AUX_CH_DATA(aux_ch, index);
> default:
> MISSING_CASE(aux_ch);
>diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>index e7057f53866a..49caa066061d 100644
>--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>@@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
> #define DP_AUX_E 0x50
> #define DP_AUX_F 0x60
> #define DP_AUX_G 0x70
>+#define DP_AUX_H 0x80
>+#define DP_AUX_I 0x90
>
> #define VBT_DP_MAX_LINK_RATE_HBR3 0
> #define VBT_DP_MAX_LINK_RATE_HBR2 1
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-25 23:13 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:13 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote:
>TGL's extra ports also bring extra AUX channels.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
> drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
> drivers/gpu/drm/i915/display/intel_display.h | 2 ++
> drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> 5 files changed, 22 insertions(+), 28 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>index fe302338b7fd..3867b41338a7 100644
>--- a/drivers/gpu/drm/i915/display/intel_bios.c
>+++ b/drivers/gpu/drm/i915/display/intel_bios.c
>@@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
> case DP_AUX_G:
> aux_ch = AUX_CH_G;
> break;
>+ case DP_AUX_H:
>+ aux_ch = AUX_CH_H;
>+ break;
>+ case DP_AUX_I:
>+ aux_ch = AUX_CH_I;
>+ break;
I'd rather drop H/I from all other places since we are not using them.
Lucas De Marchi
> default:
> MISSING_CASE(info->alternate_aux_channel);
> aux_ch = AUX_CH_A;
>diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>index cbf9cf30050c..e45ed0c07d0d 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.c
>+++ b/drivers/gpu/drm/i915/display/intel_display.c
>@@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
>
> if (intel_phy_is_tc(dev_priv, phy) &&
> dig_port->tc_mode == TC_PORT_TBT_ALT) {
>- switch (dig_port->aux_ch) {
>- case AUX_CH_C:
>- return POWER_DOMAIN_AUX_C_TBT;
>- case AUX_CH_D:
>- return POWER_DOMAIN_AUX_D_TBT;
>- case AUX_CH_E:
>- return POWER_DOMAIN_AUX_E_TBT;
>- case AUX_CH_F:
>- return POWER_DOMAIN_AUX_F_TBT;
>- case AUX_CH_G:
>- return POWER_DOMAIN_AUX_G_TBT;
>- default:
>+ if (dig_port->aux_ch >= AUX_CH_C &&
>+ dig_port->aux_ch <= AUX_CH_I) {
>+ return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
>+ AUX_CH_C;
>+ } else {
> MISSING_CASE(dig_port->aux_ch);
> return POWER_DOMAIN_AUX_C_TBT;
> }
> }
>
>- switch (dig_port->aux_ch) {
>- case AUX_CH_A:
>- return POWER_DOMAIN_AUX_A;
>- case AUX_CH_B:
>- return POWER_DOMAIN_AUX_B;
>- case AUX_CH_C:
>- return POWER_DOMAIN_AUX_C;
>- case AUX_CH_D:
>- return POWER_DOMAIN_AUX_D;
>- case AUX_CH_E:
>- return POWER_DOMAIN_AUX_E;
>- case AUX_CH_F:
>- return POWER_DOMAIN_AUX_F;
>- case AUX_CH_G:
>- return POWER_DOMAIN_AUX_G;
>- default:
>+ if (dig_port->aux_ch <= AUX_CH_I) {
>+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
>+ } else {
> MISSING_CASE(dig_port->aux_ch);
> return POWER_DOMAIN_AUX_A;
> }
>diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>index ca7ca2804d8b..9ccaae41a8ad 100644
>--- a/drivers/gpu/drm/i915/display/intel_display.h
>+++ b/drivers/gpu/drm/i915/display/intel_display.h
>@@ -275,6 +275,8 @@ enum aux_ch {
> AUX_CH_E, /* ICL+ */
> AUX_CH_F,
> AUX_CH_G,
>+ AUX_CH_H,
>+ AUX_CH_I,
> };
>
> #define aux_ch_name(a) ((a) + 'A')
>diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>index 86989ec25bc6..65bab46f7b43 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp.c
>@@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
> case AUX_CH_E:
> case AUX_CH_F:
> case AUX_CH_G:
>+ case AUX_CH_H:
>+ case AUX_CH_I:
> return DP_AUX_CH_CTL(aux_ch);
> default:
> MISSING_CASE(aux_ch);
>@@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
> case AUX_CH_E:
> case AUX_CH_F:
> case AUX_CH_G:
>+ case AUX_CH_H:
>+ case AUX_CH_I:
> return DP_AUX_CH_DATA(aux_ch, index);
> default:
> MISSING_CASE(aux_ch);
>diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>index e7057f53866a..49caa066061d 100644
>--- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>+++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>@@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
> #define DP_AUX_E 0x50
> #define DP_AUX_F 0x60
> #define DP_AUX_G 0x70
>+#define DP_AUX_H 0x80
>+#define DP_AUX_I 0x90
>
> #define VBT_DP_MAX_LINK_RATE_HBR3 0
> #define VBT_DP_MAX_LINK_RATE_HBR2 1
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-28 14:57 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-28 14:57 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:13:40PM -0700, Lucas De Marchi wrote:
> On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote:
> > TGL's extra ports also bring extra AUX channels.
> >
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
> > drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
> > drivers/gpu/drm/i915/display/intel_display.h | 2 ++
> > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
> > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> > 5 files changed, 22 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> > index fe302338b7fd..3867b41338a7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> > @@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
> > case DP_AUX_G:
> > aux_ch = AUX_CH_G;
> > break;
> > + case DP_AUX_H:
> > + aux_ch = AUX_CH_H;
> > + break;
> > + case DP_AUX_I:
> > + aux_ch = AUX_CH_I;
> > + break;
>
> I'd rather drop H/I from all other places since we are not using them.
I'm not sure I understand what you mean here. My understanding was that
OEM's can use non-standard association of port<->aux that's dependent on
their board design. If we don't honor their desired AUX setting here in
the VBT (or handle it elsewhere in the driver) don't we risk having
display fail on some platforms?
Matt
>
> Lucas De Marchi
>
>
> > default:
> > MISSING_CASE(info->alternate_aux_channel);
> > aux_ch = AUX_CH_A;
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index cbf9cf30050c..e45ed0c07d0d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
> >
> > if (intel_phy_is_tc(dev_priv, phy) &&
> > dig_port->tc_mode == TC_PORT_TBT_ALT) {
> > - switch (dig_port->aux_ch) {
> > - case AUX_CH_C:
> > - return POWER_DOMAIN_AUX_C_TBT;
> > - case AUX_CH_D:
> > - return POWER_DOMAIN_AUX_D_TBT;
> > - case AUX_CH_E:
> > - return POWER_DOMAIN_AUX_E_TBT;
> > - case AUX_CH_F:
> > - return POWER_DOMAIN_AUX_F_TBT;
> > - case AUX_CH_G:
> > - return POWER_DOMAIN_AUX_G_TBT;
> > - default:
> > + if (dig_port->aux_ch >= AUX_CH_C &&
> > + dig_port->aux_ch <= AUX_CH_I) {
> > + return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
> > + AUX_CH_C;
> > + } else {
> > MISSING_CASE(dig_port->aux_ch);
> > return POWER_DOMAIN_AUX_C_TBT;
> > }
> > }
> >
> > - switch (dig_port->aux_ch) {
> > - case AUX_CH_A:
> > - return POWER_DOMAIN_AUX_A;
> > - case AUX_CH_B:
> > - return POWER_DOMAIN_AUX_B;
> > - case AUX_CH_C:
> > - return POWER_DOMAIN_AUX_C;
> > - case AUX_CH_D:
> > - return POWER_DOMAIN_AUX_D;
> > - case AUX_CH_E:
> > - return POWER_DOMAIN_AUX_E;
> > - case AUX_CH_F:
> > - return POWER_DOMAIN_AUX_F;
> > - case AUX_CH_G:
> > - return POWER_DOMAIN_AUX_G;
> > - default:
> > + if (dig_port->aux_ch <= AUX_CH_I) {
> > + return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
> > + } else {
> > MISSING_CASE(dig_port->aux_ch);
> > return POWER_DOMAIN_AUX_A;
> > }
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> > index ca7ca2804d8b..9ccaae41a8ad 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
> > @@ -275,6 +275,8 @@ enum aux_ch {
> > AUX_CH_E, /* ICL+ */
> > AUX_CH_F,
> > AUX_CH_G,
> > + AUX_CH_H,
> > + AUX_CH_I,
> > };
> >
> > #define aux_ch_name(a) ((a) + 'A')
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 86989ec25bc6..65bab46f7b43 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
> > case AUX_CH_E:
> > case AUX_CH_F:
> > case AUX_CH_G:
> > + case AUX_CH_H:
> > + case AUX_CH_I:
> > return DP_AUX_CH_CTL(aux_ch);
> > default:
> > MISSING_CASE(aux_ch);
> > @@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
> > case AUX_CH_E:
> > case AUX_CH_F:
> > case AUX_CH_G:
> > + case AUX_CH_H:
> > + case AUX_CH_I:
> > return DP_AUX_CH_DATA(aux_ch, index);
> > default:
> > MISSING_CASE(aux_ch);
> > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > index e7057f53866a..49caa066061d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > @@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
> > #define DP_AUX_E 0x50
> > #define DP_AUX_F 0x60
> > #define DP_AUX_G 0x70
> > +#define DP_AUX_H 0x80
> > +#define DP_AUX_I 0x90
> >
> > #define VBT_DP_MAX_LINK_RATE_HBR3 0
> > #define VBT_DP_MAX_LINK_RATE_HBR2 1
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-28 14:57 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-28 14:57 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:13:40PM -0700, Lucas De Marchi wrote:
> On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote:
> > TGL's extra ports also bring extra AUX channels.
> >
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
> > drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
> > drivers/gpu/drm/i915/display/intel_display.h | 2 ++
> > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
> > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
> > 5 files changed, 22 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> > index fe302338b7fd..3867b41338a7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bios.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> > @@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
> > case DP_AUX_G:
> > aux_ch = AUX_CH_G;
> > break;
> > + case DP_AUX_H:
> > + aux_ch = AUX_CH_H;
> > + break;
> > + case DP_AUX_I:
> > + aux_ch = AUX_CH_I;
> > + break;
>
> I'd rather drop H/I from all other places since we are not using them.
I'm not sure I understand what you mean here. My understanding was that
OEM's can use non-standard association of port<->aux that's dependent on
their board design. If we don't honor their desired AUX setting here in
the VBT (or handle it elsewhere in the driver) don't we risk having
display fail on some platforms?
Matt
>
> Lucas De Marchi
>
>
> > default:
> > MISSING_CASE(info->alternate_aux_channel);
> > aux_ch = AUX_CH_A;
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index cbf9cf30050c..e45ed0c07d0d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
> >
> > if (intel_phy_is_tc(dev_priv, phy) &&
> > dig_port->tc_mode == TC_PORT_TBT_ALT) {
> > - switch (dig_port->aux_ch) {
> > - case AUX_CH_C:
> > - return POWER_DOMAIN_AUX_C_TBT;
> > - case AUX_CH_D:
> > - return POWER_DOMAIN_AUX_D_TBT;
> > - case AUX_CH_E:
> > - return POWER_DOMAIN_AUX_E_TBT;
> > - case AUX_CH_F:
> > - return POWER_DOMAIN_AUX_F_TBT;
> > - case AUX_CH_G:
> > - return POWER_DOMAIN_AUX_G_TBT;
> > - default:
> > + if (dig_port->aux_ch >= AUX_CH_C &&
> > + dig_port->aux_ch <= AUX_CH_I) {
> > + return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
> > + AUX_CH_C;
> > + } else {
> > MISSING_CASE(dig_port->aux_ch);
> > return POWER_DOMAIN_AUX_C_TBT;
> > }
> > }
> >
> > - switch (dig_port->aux_ch) {
> > - case AUX_CH_A:
> > - return POWER_DOMAIN_AUX_A;
> > - case AUX_CH_B:
> > - return POWER_DOMAIN_AUX_B;
> > - case AUX_CH_C:
> > - return POWER_DOMAIN_AUX_C;
> > - case AUX_CH_D:
> > - return POWER_DOMAIN_AUX_D;
> > - case AUX_CH_E:
> > - return POWER_DOMAIN_AUX_E;
> > - case AUX_CH_F:
> > - return POWER_DOMAIN_AUX_F;
> > - case AUX_CH_G:
> > - return POWER_DOMAIN_AUX_G;
> > - default:
> > + if (dig_port->aux_ch <= AUX_CH_I) {
> > + return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
> > + } else {
> > MISSING_CASE(dig_port->aux_ch);
> > return POWER_DOMAIN_AUX_A;
> > }
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> > index ca7ca2804d8b..9ccaae41a8ad 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
> > @@ -275,6 +275,8 @@ enum aux_ch {
> > AUX_CH_E, /* ICL+ */
> > AUX_CH_F,
> > AUX_CH_G,
> > + AUX_CH_H,
> > + AUX_CH_I,
> > };
> >
> > #define aux_ch_name(a) ((a) + 'A')
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 86989ec25bc6..65bab46f7b43 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
> > case AUX_CH_E:
> > case AUX_CH_F:
> > case AUX_CH_G:
> > + case AUX_CH_H:
> > + case AUX_CH_I:
> > return DP_AUX_CH_CTL(aux_ch);
> > default:
> > MISSING_CASE(aux_ch);
> > @@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
> > case AUX_CH_E:
> > case AUX_CH_F:
> > case AUX_CH_G:
> > + case AUX_CH_H:
> > + case AUX_CH_I:
> > return DP_AUX_CH_DATA(aux_ch, index);
> > default:
> > MISSING_CASE(aux_ch);
> > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > index e7057f53866a..49caa066061d 100644
> > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> > @@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
> > #define DP_AUX_E 0x50
> > #define DP_AUX_F 0x60
> > #define DP_AUX_G 0x70
> > +#define DP_AUX_H 0x80
> > +#define DP_AUX_I 0x90
> >
> > #define VBT_DP_MAX_LINK_RATE_HBR3 0
> > #define VBT_DP_MAX_LINK_RATE_HBR2 1
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-29 17:59 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-29 17:59 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Mon, Oct 28, 2019 at 07:57:12AM -0700, Matt Roper wrote:
>On Fri, Oct 25, 2019 at 04:13:40PM -0700, Lucas De Marchi wrote:
>> On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote:
>> > TGL's extra ports also bring extra AUX channels.
>> >
>> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
>> > drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
>> > drivers/gpu/drm/i915/display/intel_display.h | 2 ++
>> > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
>> > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
>> > 5 files changed, 22 insertions(+), 28 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> > index fe302338b7fd..3867b41338a7 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> > @@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
>> > case DP_AUX_G:
>> > aux_ch = AUX_CH_G;
>> > break;
>> > + case DP_AUX_H:
>> > + aux_ch = AUX_CH_H;
>> > + break;
>> > + case DP_AUX_I:
>> > + aux_ch = AUX_CH_I;
>> > + break;
>>
>> I'd rather drop H/I from all other places since we are not using them.
>
>I'm not sure I understand what you mean here. My understanding was that
>OEM's can use non-standard association of port<->aux that's dependent on
>their board design. If we don't honor their desired AUX setting here in
>the VBT (or handle it elsewhere in the driver) don't we risk having
>display fail on some platforms?
the pins are not exposed on any soc that we can test... that's why I'd
rather drop them from the other places. We could then bring them back if
needed later.
No strong opinion though. If you decide to go with this patch, then it's
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>
>
>Matt
>
>>
>> Lucas De Marchi
>>
>>
>> > default:
>> > MISSING_CASE(info->alternate_aux_channel);
>> > aux_ch = AUX_CH_A;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> > index cbf9cf30050c..e45ed0c07d0d 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> > @@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
>> >
>> > if (intel_phy_is_tc(dev_priv, phy) &&
>> > dig_port->tc_mode == TC_PORT_TBT_ALT) {
>> > - switch (dig_port->aux_ch) {
>> > - case AUX_CH_C:
>> > - return POWER_DOMAIN_AUX_C_TBT;
>> > - case AUX_CH_D:
>> > - return POWER_DOMAIN_AUX_D_TBT;
>> > - case AUX_CH_E:
>> > - return POWER_DOMAIN_AUX_E_TBT;
>> > - case AUX_CH_F:
>> > - return POWER_DOMAIN_AUX_F_TBT;
>> > - case AUX_CH_G:
>> > - return POWER_DOMAIN_AUX_G_TBT;
>> > - default:
>> > + if (dig_port->aux_ch >= AUX_CH_C &&
>> > + dig_port->aux_ch <= AUX_CH_I) {
>> > + return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
>> > + AUX_CH_C;
>> > + } else {
>> > MISSING_CASE(dig_port->aux_ch);
>> > return POWER_DOMAIN_AUX_C_TBT;
>> > }
>> > }
>> >
>> > - switch (dig_port->aux_ch) {
>> > - case AUX_CH_A:
>> > - return POWER_DOMAIN_AUX_A;
>> > - case AUX_CH_B:
>> > - return POWER_DOMAIN_AUX_B;
>> > - case AUX_CH_C:
>> > - return POWER_DOMAIN_AUX_C;
>> > - case AUX_CH_D:
>> > - return POWER_DOMAIN_AUX_D;
>> > - case AUX_CH_E:
>> > - return POWER_DOMAIN_AUX_E;
>> > - case AUX_CH_F:
>> > - return POWER_DOMAIN_AUX_F;
>> > - case AUX_CH_G:
>> > - return POWER_DOMAIN_AUX_G;
>> > - default:
>> > + if (dig_port->aux_ch <= AUX_CH_I) {
>> > + return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
>> > + } else {
>> > MISSING_CASE(dig_port->aux_ch);
>> > return POWER_DOMAIN_AUX_A;
>> > }
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>> > index ca7ca2804d8b..9ccaae41a8ad 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> > @@ -275,6 +275,8 @@ enum aux_ch {
>> > AUX_CH_E, /* ICL+ */
>> > AUX_CH_F,
>> > AUX_CH_G,
>> > + AUX_CH_H,
>> > + AUX_CH_I,
>> > };
>> >
>> > #define aux_ch_name(a) ((a) + 'A')
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> > index 86989ec25bc6..65bab46f7b43 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> > @@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
>> > case AUX_CH_E:
>> > case AUX_CH_F:
>> > case AUX_CH_G:
>> > + case AUX_CH_H:
>> > + case AUX_CH_I:
>> > return DP_AUX_CH_CTL(aux_ch);
>> > default:
>> > MISSING_CASE(aux_ch);
>> > @@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
>> > case AUX_CH_E:
>> > case AUX_CH_F:
>> > case AUX_CH_G:
>> > + case AUX_CH_H:
>> > + case AUX_CH_I:
>> > return DP_AUX_CH_DATA(aux_ch, index);
>> > default:
>> > MISSING_CASE(aux_ch);
>> > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> > index e7057f53866a..49caa066061d 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> > @@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
>> > #define DP_AUX_E 0x50
>> > #define DP_AUX_F 0x60
>> > #define DP_AUX_G 0x70
>> > +#define DP_AUX_H 0x80
>> > +#define DP_AUX_I 0x90
>> >
>> > #define VBT_DP_MAX_LINK_RATE_HBR3 0
>> > #define VBT_DP_MAX_LINK_RATE_HBR2 1
>> > --
>> > 2.21.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add missing AUX channel H & I support
@ 2019-10-29 17:59 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-29 17:59 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Mon, Oct 28, 2019 at 07:57:12AM -0700, Matt Roper wrote:
>On Fri, Oct 25, 2019 at 04:13:40PM -0700, Lucas De Marchi wrote:
>> On Fri, Oct 25, 2019 at 04:06:21PM -0700, Matt Roper wrote:
>> > TGL's extra ports also bring extra AUX channels.
>> >
>> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_bios.c | 6 ++++
>> > drivers/gpu/drm/i915/display/intel_display.c | 36 +++++--------------
>> > drivers/gpu/drm/i915/display/intel_display.h | 2 ++
>> > drivers/gpu/drm/i915/display/intel_dp.c | 4 +++
>> > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 ++
>> > 5 files changed, 22 insertions(+), 28 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>> > index fe302338b7fd..3867b41338a7 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_bios.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_bios.c
>> > @@ -2339,6 +2339,12 @@ enum aux_ch intel_bios_port_aux_ch(struct drm_i915_private *dev_priv,
>> > case DP_AUX_G:
>> > aux_ch = AUX_CH_G;
>> > break;
>> > + case DP_AUX_H:
>> > + aux_ch = AUX_CH_H;
>> > + break;
>> > + case DP_AUX_I:
>> > + aux_ch = AUX_CH_I;
>> > + break;
>>
>> I'd rather drop H/I from all other places since we are not using them.
>
>I'm not sure I understand what you mean here. My understanding was that
>OEM's can use non-standard association of port<->aux that's dependent on
>their board design. If we don't honor their desired AUX setting here in
>the VBT (or handle it elsewhere in the driver) don't we risk having
>display fail on some platforms?
the pins are not exposed on any soc that we can test... that's why I'd
rather drop them from the other places. We could then bring them back if
needed later.
No strong opinion though. If you decide to go with this patch, then it's
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>
>
>Matt
>
>>
>> Lucas De Marchi
>>
>>
>> > default:
>> > MISSING_CASE(info->alternate_aux_channel);
>> > aux_ch = AUX_CH_A;
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> > index cbf9cf30050c..e45ed0c07d0d 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> > @@ -6847,39 +6847,19 @@ intel_aux_power_domain(struct intel_digital_port *dig_port)
>> >
>> > if (intel_phy_is_tc(dev_priv, phy) &&
>> > dig_port->tc_mode == TC_PORT_TBT_ALT) {
>> > - switch (dig_port->aux_ch) {
>> > - case AUX_CH_C:
>> > - return POWER_DOMAIN_AUX_C_TBT;
>> > - case AUX_CH_D:
>> > - return POWER_DOMAIN_AUX_D_TBT;
>> > - case AUX_CH_E:
>> > - return POWER_DOMAIN_AUX_E_TBT;
>> > - case AUX_CH_F:
>> > - return POWER_DOMAIN_AUX_F_TBT;
>> > - case AUX_CH_G:
>> > - return POWER_DOMAIN_AUX_G_TBT;
>> > - default:
>> > + if (dig_port->aux_ch >= AUX_CH_C &&
>> > + dig_port->aux_ch <= AUX_CH_I) {
>> > + return POWER_DOMAIN_AUX_C_TBT + dig_port->aux_ch -
>> > + AUX_CH_C;
>> > + } else {
>> > MISSING_CASE(dig_port->aux_ch);
>> > return POWER_DOMAIN_AUX_C_TBT;
>> > }
>> > }
>> >
>> > - switch (dig_port->aux_ch) {
>> > - case AUX_CH_A:
>> > - return POWER_DOMAIN_AUX_A;
>> > - case AUX_CH_B:
>> > - return POWER_DOMAIN_AUX_B;
>> > - case AUX_CH_C:
>> > - return POWER_DOMAIN_AUX_C;
>> > - case AUX_CH_D:
>> > - return POWER_DOMAIN_AUX_D;
>> > - case AUX_CH_E:
>> > - return POWER_DOMAIN_AUX_E;
>> > - case AUX_CH_F:
>> > - return POWER_DOMAIN_AUX_F;
>> > - case AUX_CH_G:
>> > - return POWER_DOMAIN_AUX_G;
>> > - default:
>> > + if (dig_port->aux_ch <= AUX_CH_I) {
>> > + return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
>> > + } else {
>> > MISSING_CASE(dig_port->aux_ch);
>> > return POWER_DOMAIN_AUX_A;
>> > }
>> > diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>> > index ca7ca2804d8b..9ccaae41a8ad 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_display.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> > @@ -275,6 +275,8 @@ enum aux_ch {
>> > AUX_CH_E, /* ICL+ */
>> > AUX_CH_F,
>> > AUX_CH_G,
>> > + AUX_CH_H,
>> > + AUX_CH_I,
>> > };
>> >
>> > #define aux_ch_name(a) ((a) + 'A')
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> > index 86989ec25bc6..65bab46f7b43 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> > @@ -1667,6 +1667,8 @@ static i915_reg_t skl_aux_ctl_reg(struct intel_dp *intel_dp)
>> > case AUX_CH_E:
>> > case AUX_CH_F:
>> > case AUX_CH_G:
>> > + case AUX_CH_H:
>> > + case AUX_CH_I:
>> > return DP_AUX_CH_CTL(aux_ch);
>> > default:
>> > MISSING_CASE(aux_ch);
>> > @@ -1688,6 +1690,8 @@ static i915_reg_t skl_aux_data_reg(struct intel_dp *intel_dp, int index)
>> > case AUX_CH_E:
>> > case AUX_CH_F:
>> > case AUX_CH_G:
>> > + case AUX_CH_H:
>> > + case AUX_CH_I:
>> > return DP_AUX_CH_DATA(aux_ch, index);
>> > default:
>> > MISSING_CASE(aux_ch);
>> > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> > index e7057f53866a..49caa066061d 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
>> > @@ -329,6 +329,8 @@ enum vbt_gmbus_ddi {
>> > #define DP_AUX_E 0x50
>> > #define DP_AUX_F 0x60
>> > #define DP_AUX_G 0x70
>> > +#define DP_AUX_H 0x80
>> > +#define DP_AUX_I 0x90
>> >
>> > #define VBT_DP_MAX_LINK_RATE_HBR3 0
>> > #define VBT_DP_MAX_LINK_RATE_HBR2 1
>> > --
>> > 2.21.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
We're seeing some failures where an aux transaction still shows as
'busy' well after the timeout limit that the hardware is supposed to
enforce. Improve the error message so that we can see exactly which aux
channel this error happened on and what the status bits were during this
case that isn't supposed to happen.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 65bab46f7b43..2b4915b5cf52 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
if (!done)
- DRM_ERROR("dp aux hw did not signal timeout!\n");
+ DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
+ intel_dp->aux.name ?: "AUX", status);
#undef C
return status;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
We're seeing some failures where an aux transaction still shows as
'busy' well after the timeout limit that the hardware is supposed to
enforce. Improve the error message so that we can see exactly which aux
channel this error happened on and what the status bits were during this
case that isn't supposed to happen.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 65bab46f7b43..2b4915b5cf52 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
if (!done)
- DRM_ERROR("dp aux hw did not signal timeout!\n");
+ DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
+ intel_dp->aux.name ?: "AUX", status);
#undef C
return status;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* Re: [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:19 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:19 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
>We're seeing some failures where an aux transaction still shows as
>'busy' well after the timeout limit that the hardware is supposed to
>enforce. Improve the error message so that we can see exactly which aux
>channel this error happened on and what the status bits were during this
>case that isn't supposed to happen.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>index 65bab46f7b43..2b4915b5cf52 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp.c
>@@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
>- DRM_ERROR("dp aux hw did not signal timeout!\n");
>+ DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
>+ intel_dp->aux.name ?: "AUX", status);
maybe a "const timeout_msec = 10" and use it both here and above to
avoid mismatch in future? However I'm not sure it's worth... up to you.
intel_dp_aux_init set aux.name to kasprintf() and we can't possibly
initiate aux transactions before that init.
intel_dp_connector_register() also doesn't handle aux.name == NULL, so
whay are we checking it heere?
Lucas De Marchi
> #undef C
>
> return status;
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:19 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:19 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
>We're seeing some failures where an aux transaction still shows as
>'busy' well after the timeout limit that the hardware is supposed to
>enforce. Improve the error message so that we can see exactly which aux
>channel this error happened on and what the status bits were during this
>case that isn't supposed to happen.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>index 65bab46f7b43..2b4915b5cf52 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp.c
>@@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
>- DRM_ERROR("dp aux hw did not signal timeout!\n");
>+ DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
>+ intel_dp->aux.name ?: "AUX", status);
maybe a "const timeout_msec = 10" and use it both here and above to
avoid mismatch in future? However I'm not sure it's worth... up to you.
intel_dp_aux_init set aux.name to kasprintf() and we can't possibly
initiate aux transactions before that init.
intel_dp_connector_register() also doesn't handle aux.name == NULL, so
whay are we checking it heere?
Lucas De Marchi
> #undef C
>
> return status;
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:25 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:25 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:19:33PM -0700, Lucas De Marchi wrote:
> On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
> > We're seeing some failures where an aux transaction still shows as
> > 'busy' well after the timeout limit that the hardware is supposed to
> > enforce. Improve the error message so that we can see exactly which aux
> > channel this error happened on and what the status bits were during this
> > case that isn't supposed to happen.
> >
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 65bab46f7b43..2b4915b5cf52 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> >
> > if (!done)
> > - DRM_ERROR("dp aux hw did not signal timeout!\n");
> > + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
> > + intel_dp->aux.name ?: "AUX", status);
>
> maybe a "const timeout_msec = 10" and use it both here and above to
> avoid mismatch in future? However I'm not sure it's worth... up to you.
>
> intel_dp_aux_init set aux.name to kasprintf() and we can't possibly
> initiate aux transactions before that init.
> intel_dp_connector_register() also doesn't handle aux.name == NULL, so
> whay are we checking it heere?
kasprintf() could technically fail to allocate the string and leave the
name as NULL. But I guess if that happens we've probably got bigger
problems anyway.
Matt
>
> Lucas De Marchi
>
> > #undef C
> >
> > return status;
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:25 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:25 UTC (permalink / raw)
To: Lucas De Marchi; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:19:33PM -0700, Lucas De Marchi wrote:
> On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
> > We're seeing some failures where an aux transaction still shows as
> > 'busy' well after the timeout limit that the hardware is supposed to
> > enforce. Improve the error message so that we can see exactly which aux
> > channel this error happened on and what the status bits were during this
> > case that isn't supposed to happen.
> >
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 65bab46f7b43..2b4915b5cf52 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
> >
> > if (!done)
> > - DRM_ERROR("dp aux hw did not signal timeout!\n");
> > + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
> > + intel_dp->aux.name ?: "AUX", status);
>
> maybe a "const timeout_msec = 10" and use it both here and above to
> avoid mismatch in future? However I'm not sure it's worth... up to you.
>
> intel_dp_aux_init set aux.name to kasprintf() and we can't possibly
> initiate aux transactions before that init.
> intel_dp_connector_register() also doesn't handle aux.name == NULL, so
> whay are we checking it heere?
kasprintf() could technically fail to allocate the string and leave the
name as NULL. But I guess if that happens we've probably got bigger
problems anyway.
Matt
>
> Lucas De Marchi
>
> > #undef C
> >
> > return status;
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:32 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:32 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:25:47PM -0700, Matt Roper wrote:
>On Fri, Oct 25, 2019 at 04:19:33PM -0700, Lucas De Marchi wrote:
>> On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
>> > We're seeing some failures where an aux transaction still shows as
>> > 'busy' well after the timeout limit that the hardware is supposed to
>> > enforce. Improve the error message so that we can see exactly which aux
>> > channel this error happened on and what the status bits were during this
>> > case that isn't supposed to happen.
>> >
>> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> > index 65bab46f7b43..2b4915b5cf52 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> > @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
>> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>> >
>> > if (!done)
>> > - DRM_ERROR("dp aux hw did not signal timeout!\n");
>> > + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
>> > + intel_dp->aux.name ?: "AUX", status);
>>
>> maybe a "const timeout_msec = 10" and use it both here and above to
>> avoid mismatch in future? However I'm not sure it's worth... up to you.
>>
>> intel_dp_aux_init set aux.name to kasprintf() and we can't possibly
>> initiate aux transactions before that init.
>> intel_dp_connector_register() also doesn't handle aux.name == NULL, so
>> whay are we checking it heere?
>
>kasprintf() could technically fail to allocate the string and leave the
>name as NULL. But I guess if that happens we've probably got bigger
>problems anyway.
and if we are going to check then we should check it there rather than
in each place making use of it... we have bigger problems if kasprintf()
failed there.
Lucas De Marchi
>
>
>Matt
>
>
>>
>> Lucas De Marchi
>>
>> > #undef C
>> >
>> > return status;
>> > --
>> > 2.21.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-25 23:32 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:32 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:25:47PM -0700, Matt Roper wrote:
>On Fri, Oct 25, 2019 at 04:19:33PM -0700, Lucas De Marchi wrote:
>> On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
>> > We're seeing some failures where an aux transaction still shows as
>> > 'busy' well after the timeout limit that the hardware is supposed to
>> > enforce. Improve the error message so that we can see exactly which aux
>> > channel this error happened on and what the status bits were during this
>> > case that isn't supposed to happen.
>> >
>> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>> > index 65bab46f7b43..2b4915b5cf52 100644
>> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> > @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
>> > trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>> >
>> > if (!done)
>> > - DRM_ERROR("dp aux hw did not signal timeout!\n");
>> > + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
>> > + intel_dp->aux.name ?: "AUX", status);
>>
>> maybe a "const timeout_msec = 10" and use it both here and above to
>> avoid mismatch in future? However I'm not sure it's worth... up to you.
>>
>> intel_dp_aux_init set aux.name to kasprintf() and we can't possibly
>> initiate aux transactions before that init.
>> intel_dp_connector_register() also doesn't handle aux.name == NULL, so
>> whay are we checking it heere?
>
>kasprintf() could technically fail to allocate the string and leave the
>name as NULL. But I guess if that happens we've probably got bigger
>problems anyway.
and if we are going to check then we should check it there rather than
in each place making use of it... we have bigger problems if kasprintf()
failed there.
Lucas De Marchi
>
>
>Matt
>
>
>>
>> Lucas De Marchi
>>
>> > #undef C
>> >
>> > return status;
>> > --
>> > 2.21.0
>> >
>> > _______________________________________________
>> > Intel-gfx mailing list
>> > Intel-gfx@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>--
>Matt Roper
>Graphics Software Engineer
>VTT-OSGC Platform Enablement
>Intel Corporation
>(916) 356-2795
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH v2 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-29 17:31 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-29 17:31 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
We're seeing some failures where an aux transaction still shows as
'busy' well after the timeout limit that the hardware is supposed to
enforce. Improve the error message so that we can see exactly which aux
channel this error happened on and what the status bits were during this
case that isn't supposed to happen.
v2:
- Make timeout a const variable so that the timeout & message will
match if we decide to change it in the future. (Lucas)
- Don't bother testing intel_dp->aux.name for NULL. (Lucas)
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 65bab46f7b43..a66f8c39b201 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1179,18 +1179,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
{
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
+ const unsigned int timeout_ms = 10;
u32 status;
bool done;
#define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
done = wait_event_timeout(i915->gmbus_wait_queue, C,
- msecs_to_jiffies_timeout(10));
+ msecs_to_jiffies_timeout(timeout_ms));
/* just trace the final value */
trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
if (!done)
- DRM_ERROR("dp aux hw did not signal timeout!\n");
+ DRM_ERROR("%s did not complete or timeout within %ums (status 0x%08x)\n",
+ intel_dp->aux.name, timeout_ms, status);
#undef C
return status;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* [Intel-gfx] [PATCH v2 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-29 17:31 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-29 17:31 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi
We're seeing some failures where an aux transaction still shows as
'busy' well after the timeout limit that the hardware is supposed to
enforce. Improve the error message so that we can see exactly which aux
channel this error happened on and what the status bits were during this
case that isn't supposed to happen.
v2:
- Make timeout a const variable so that the timeout & message will
match if we decide to change it in the future. (Lucas)
- Don't bother testing intel_dp->aux.name for NULL. (Lucas)
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 65bab46f7b43..a66f8c39b201 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1179,18 +1179,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
{
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
+ const unsigned int timeout_ms = 10;
u32 status;
bool done;
#define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
done = wait_event_timeout(i915->gmbus_wait_queue, C,
- msecs_to_jiffies_timeout(10));
+ msecs_to_jiffies_timeout(timeout_ms));
/* just trace the final value */
trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
if (!done)
- DRM_ERROR("dp aux hw did not signal timeout!\n");
+ DRM_ERROR("%s did not complete or timeout within %ums (status 0x%08x)\n",
+ intel_dp->aux.name, timeout_ms, status);
#undef C
return status;
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread* Re: [PATCH v2 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-29 19:33 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-29 19:33 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Tue, Oct 29, 2019 at 10:31:02AM -0700, Matt Roper wrote:
>We're seeing some failures where an aux transaction still shows as
>'busy' well after the timeout limit that the hardware is supposed to
>enforce. Improve the error message so that we can see exactly which aux
>channel this error happened on and what the status bits were during this
>case that isn't supposed to happen.
>
>v2:
> - Make timeout a const variable so that the timeout & message will
> match if we decide to change it in the future. (Lucas)
> - Don't bother testing intel_dp->aux.name for NULL. (Lucas)
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>index 65bab46f7b43..a66f8c39b201 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp.c
>@@ -1179,18 +1179,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> {
> struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
>+ const unsigned int timeout_ms = 10;
> u32 status;
> bool done;
>
> #define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> done = wait_event_timeout(i915->gmbus_wait_queue, C,
>- msecs_to_jiffies_timeout(10));
>+ msecs_to_jiffies_timeout(timeout_ms));
>
> /* just trace the final value */
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
>- DRM_ERROR("dp aux hw did not signal timeout!\n");
>+ DRM_ERROR("%s did not complete or timeout within %ums (status 0x%08x)\n",
>+ intel_dp->aux.name, timeout_ms, status);
> #undef C
>
> return status;
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH v2 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-29 19:33 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-29 19:33 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Tue, Oct 29, 2019 at 10:31:02AM -0700, Matt Roper wrote:
>We're seeing some failures where an aux transaction still shows as
>'busy' well after the timeout limit that the hardware is supposed to
>enforce. Improve the error message so that we can see exactly which aux
>channel this error happened on and what the status bits were during this
>case that isn't supposed to happen.
>
>v2:
> - Make timeout a const variable so that the timeout & message will
> match if we decide to change it in the future. (Lucas)
> - Don't bother testing intel_dp->aux.name for NULL. (Lucas)
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>index 65bab46f7b43..a66f8c39b201 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp.c
>@@ -1179,18 +1179,20 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> {
> struct drm_i915_private *i915 = dp_to_i915(intel_dp);
> i915_reg_t ch_ctl = intel_dp->aux_ch_ctl_reg(intel_dp);
>+ const unsigned int timeout_ms = 10;
> u32 status;
> bool done;
>
> #define C (((status = intel_uncore_read_notrace(&i915->uncore, ch_ctl)) & DP_AUX_CH_CTL_SEND_BUSY) == 0)
> done = wait_event_timeout(i915->gmbus_wait_queue, C,
>- msecs_to_jiffies_timeout(10));
>+ msecs_to_jiffies_timeout(timeout_ms));
>
> /* just trace the final value */
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
>- DRM_ERROR("dp aux hw did not signal timeout!\n");
>+ DRM_ERROR("%s did not complete or timeout within %ums (status 0x%08x)\n",
>+ intel_dp->aux.name, timeout_ms, status);
> #undef C
>
> return status;
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-28 16:43 ` Ville Syrjälä
0 siblings, 0 replies; 56+ messages in thread
From: Ville Syrjälä @ 2019-10-28 16:43 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
> We're seeing some failures where an aux transaction still shows as
> 'busy' well after the timeout limit that the hardware is supposed to
> enforce. Improve the error message so that we can see exactly which aux
> channel this error happened on and what the status bits were during this
> case that isn't supposed to happen.
Pretty sure I have a patch somewhere that adds the aux name
to all the messages. I should probably dig that up and post it.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65bab46f7b43..2b4915b5cf52 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
> - DRM_ERROR("dp aux hw did not signal timeout!\n");
> + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
> + intel_dp->aux.name ?: "AUX", status);
> #undef C
>
> return status;
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] [PATCH 4/5] drm/i915: Provide more information on DP AUX failures
@ 2019-10-28 16:43 ` Ville Syrjälä
0 siblings, 0 replies; 56+ messages in thread
From: Ville Syrjälä @ 2019-10-28 16:43 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:22PM -0700, Matt Roper wrote:
> We're seeing some failures where an aux transaction still shows as
> 'busy' well after the timeout limit that the hardware is supposed to
> enforce. Improve the error message so that we can see exactly which aux
> channel this error happened on and what the status bits were during this
> case that isn't supposed to happen.
Pretty sure I have a patch somewhere that adds the aux name
to all the messages. I should probably dig that up and post it.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 65bab46f7b43..2b4915b5cf52 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1190,7 +1190,8 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
> trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);
>
> if (!done)
> - DRM_ERROR("dp aux hw did not signal timeout!\n");
> + DRM_ERROR("%s did not complete or timeout within 10ms (status 0x%08x)\n",
> + intel_dp->aux.name ?: "AUX", status);
> #undef C
>
> return status;
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
Our TGL CI platforms are running into cases where aux transactions have
failed to complete or declare a timeout well after the timeout limit
that the hardware is supposed to enforce. From the logs it appears that
these failures arise when aux transactions happen after we've entered
DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather
than PG3 as they were on ICL.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 6f9e7927e248..707ac110e271 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
TGL_PW_2_POWER_DOMAINS | \
BIT_ULL(POWER_DOMAIN_MODESET) | \
BIT_ULL(POWER_DOMAIN_AUX_A) | \
+ BIT_ULL(POWER_DOMAIN_AUX_B) | \
+ BIT_ULL(POWER_DOMAIN_AUX_C) | \
BIT_ULL(POWER_DOMAIN_INIT))
#define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread
* [Intel-gfx] [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
@ 2019-10-25 23:06 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-25 23:06 UTC (permalink / raw)
To: intel-gfx
Our TGL CI platforms are running into cases where aux transactions have
failed to complete or declare a timeout well after the timeout limit
that the hardware is supposed to enforce. From the logs it appears that
these failures arise when aux transactions happen after we've entered
DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather
than PG3 as they were on ICL.
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 6f9e7927e248..707ac110e271 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
TGL_PW_2_POWER_DOMAINS | \
BIT_ULL(POWER_DOMAIN_MODESET) | \
BIT_ULL(POWER_DOMAIN_AUX_A) | \
+ BIT_ULL(POWER_DOMAIN_AUX_B) | \
+ BIT_ULL(POWER_DOMAIN_AUX_C) | \
BIT_ULL(POWER_DOMAIN_INIT))
#define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 56+ messages in thread
* Re: [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
@ 2019-10-25 23:24 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:24 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:23PM -0700, Matt Roper wrote:
>Our TGL CI platforms are running into cases where aux transactions have
>failed to complete or declare a timeout well after the timeout limit
>that the hardware is supposed to enforce. From the logs it appears that
it's a good idea to copy the relevant part of the log here so the commit
message is self-sufficient
>these failures arise when aux transactions happen after we've entered
>DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather
>than PG3 as they were on ICL.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
>index 6f9e7927e248..707ac110e271 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_power.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
>@@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
> TGL_PW_2_POWER_DOMAINS | \
> BIT_ULL(POWER_DOMAIN_MODESET) | \
> BIT_ULL(POWER_DOMAIN_AUX_A) | \
>+ BIT_ULL(POWER_DOMAIN_AUX_B) | \
>+ BIT_ULL(POWER_DOMAIN_AUX_C) | \
> BIT_ULL(POWER_DOMAIN_INIT))
>
> #define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [Intel-gfx] [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
@ 2019-10-25 23:24 ` Lucas De Marchi
0 siblings, 0 replies; 56+ messages in thread
From: Lucas De Marchi @ 2019-10-25 23:24 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:23PM -0700, Matt Roper wrote:
>Our TGL CI platforms are running into cases where aux transactions have
>failed to complete or declare a timeout well after the timeout limit
>that the hardware is supposed to enforce. From the logs it appears that
it's a good idea to copy the relevant part of the log here so the commit
message is self-sufficient
>these failures arise when aux transactions happen after we've entered
>DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather
>than PG3 as they were on ICL.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
>index 6f9e7927e248..707ac110e271 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_power.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
>@@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
> TGL_PW_2_POWER_DOMAINS | \
> BIT_ULL(POWER_DOMAIN_MODESET) | \
> BIT_ULL(POWER_DOMAIN_AUX_A) | \
>+ BIT_ULL(POWER_DOMAIN_AUX_B) | \
>+ BIT_ULL(POWER_DOMAIN_AUX_C) | \
> BIT_ULL(POWER_DOMAIN_INIT))
>
> #define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \
>--
>2.21.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
@ 2019-10-26 8:57 ` Imre Deak
0 siblings, 0 replies; 56+ messages in thread
From: Imre Deak @ 2019-10-26 8:57 UTC (permalink / raw)
To: Matt Roper, Arthur J Runyan; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:23PM -0700, Matt Roper wrote:
> Our TGL CI platforms are running into cases where aux transactions have
> failed to complete or declare a timeout well after the timeout limit
> that the hardware is supposed to enforce. From the logs it appears that
> these failures arise when aux transactions happen after we've entered
> DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather
> than PG3 as they were on ICL.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
It's not specified that we have to disable DC5/6 for AUX transfers on
ports B/C, but it makes sense to me:
Reviewed-by: Imre Deak <imre.deak@intel.com>
The Combo PHY HW context needs to be restored after DC5/6 exit too, so
I think DMC doesn't restore the AUX HW context either. Adding Art to
confirm that.
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 6f9e7927e248..707ac110e271 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
> TGL_PW_2_POWER_DOMAINS | \
> BIT_ULL(POWER_DOMAIN_MODESET) | \
> BIT_ULL(POWER_DOMAIN_AUX_A) | \
> + BIT_ULL(POWER_DOMAIN_AUX_B) | \
> + BIT_ULL(POWER_DOMAIN_AUX_C) | \
> BIT_ULL(POWER_DOMAIN_INIT))
>
> #define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* Re: [Intel-gfx] [PATCH 5/5] drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
@ 2019-10-26 8:57 ` Imre Deak
0 siblings, 0 replies; 56+ messages in thread
From: Imre Deak @ 2019-10-26 8:57 UTC (permalink / raw)
To: Matt Roper, Arthur J Runyan; +Cc: intel-gfx
On Fri, Oct 25, 2019 at 04:06:23PM -0700, Matt Roper wrote:
> Our TGL CI platforms are running into cases where aux transactions have
> failed to complete or declare a timeout well after the timeout limit
> that the hardware is supposed to enforce. From the logs it appears that
> these failures arise when aux transactions happen after we've entered
> DC6. On TGL AUX B & C are in PG1 (managed by the DMC firmware) rather
> than PG3 as they were on ICL.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
It's not specified that we have to disable DC5/6 for AUX transfers on
ports B/C, but it makes sense to me:
Reviewed-by: Imre Deak <imre.deak@intel.com>
The Combo PHY HW context needs to be restored after DC5/6 exit too, so
I think DMC doesn't restore the AUX HW context either. Adding Art to
confirm that.
> ---
> drivers/gpu/drm/i915/display/intel_display_power.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 6f9e7927e248..707ac110e271 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -2682,6 +2682,8 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
> TGL_PW_2_POWER_DOMAINS | \
> BIT_ULL(POWER_DOMAIN_MODESET) | \
> BIT_ULL(POWER_DOMAIN_AUX_A) | \
> + BIT_ULL(POWER_DOMAIN_AUX_B) | \
> + BIT_ULL(POWER_DOMAIN_AUX_C) | \
> BIT_ULL(POWER_DOMAIN_INIT))
>
> #define TGL_DDI_IO_D_TC1_POWER_DOMAINS ( \
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* ✗ Fi.CI.BUILD: failure for DP AUX updates
@ 2019-10-26 1:09 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 1:09 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates
URL : https://patchwork.freedesktop.org/series/68590/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/gvt/handlers.o
drivers/gpu/drm/i915/gvt/handlers.c: In function ‘trigger_aux_channel_interrupt’:
drivers/gpu/drm/i915/gvt/handlers.c:826:48: error: ‘_DPC_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPA_AUX_CH_CTL’?
else if (reg == _PCH_DPC_AUX_CH_CTL || reg == _DPC_AUX_CH_CTL)
^~~~~~~~~~~~~~~
_DPA_AUX_CH_CTL
drivers/gpu/drm/i915/gvt/handlers.c:826:48: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/i915/gvt/handlers.c:828:48: error: ‘_DPD_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPC_AUX_CH_CTL’?
else if (reg == _PCH_DPD_AUX_CH_CTL || reg == _DPD_AUX_CH_CTL)
^~~~~~~~~~~~~~~
_DPC_AUX_CH_CTL
drivers/gpu/drm/i915/gvt/handlers.c: In function ‘init_skl_mmio_info’:
drivers/gpu/drm/i915/gvt/handlers.c:2877:15: error: ‘_DPC_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPA_AUX_CH_CTL’?
MMIO_F(_MMIO(_DPC_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^
drivers/gpu/drm/i915/gvt/handlers.c:1811:48: note: in definition of macro ‘MMIO_F’
ret = new_mmio_info(gvt, i915_mmio_reg_offset(reg), \
^~~
drivers/gpu/drm/i915/gvt/handlers.c:2877:9: note: in expansion of macro ‘_MMIO’
MMIO_F(_MMIO(_DPC_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^~~~~
drivers/gpu/drm/i915/gvt/handlers.c:2879:15: error: ‘_DPD_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPC_AUX_CH_CTL’?
MMIO_F(_MMIO(_DPD_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^
drivers/gpu/drm/i915/gvt/handlers.c:1811:48: note: in definition of macro ‘MMIO_F’
ret = new_mmio_info(gvt, i915_mmio_reg_offset(reg), \
^~~
drivers/gpu/drm/i915/gvt/handlers.c:2879:9: note: in expansion of macro ‘_MMIO’
MMIO_F(_MMIO(_DPD_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^~~~~
scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/i915/gvt/handlers.o' failed
make[4]: *** [drivers/gpu/drm/i915/gvt/handlers.o] Error 1
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1649: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* [Intel-gfx] ✗ Fi.CI.BUILD: failure for DP AUX updates
@ 2019-10-26 1:09 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 1:09 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates
URL : https://patchwork.freedesktop.org/series/68590/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/gvt/handlers.o
drivers/gpu/drm/i915/gvt/handlers.c: In function ‘trigger_aux_channel_interrupt’:
drivers/gpu/drm/i915/gvt/handlers.c:826:48: error: ‘_DPC_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPA_AUX_CH_CTL’?
else if (reg == _PCH_DPC_AUX_CH_CTL || reg == _DPC_AUX_CH_CTL)
^~~~~~~~~~~~~~~
_DPA_AUX_CH_CTL
drivers/gpu/drm/i915/gvt/handlers.c:826:48: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/i915/gvt/handlers.c:828:48: error: ‘_DPD_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPC_AUX_CH_CTL’?
else if (reg == _PCH_DPD_AUX_CH_CTL || reg == _DPD_AUX_CH_CTL)
^~~~~~~~~~~~~~~
_DPC_AUX_CH_CTL
drivers/gpu/drm/i915/gvt/handlers.c: In function ‘init_skl_mmio_info’:
drivers/gpu/drm/i915/gvt/handlers.c:2877:15: error: ‘_DPC_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPA_AUX_CH_CTL’?
MMIO_F(_MMIO(_DPC_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^
drivers/gpu/drm/i915/gvt/handlers.c:1811:48: note: in definition of macro ‘MMIO_F’
ret = new_mmio_info(gvt, i915_mmio_reg_offset(reg), \
^~~
drivers/gpu/drm/i915/gvt/handlers.c:2877:9: note: in expansion of macro ‘_MMIO’
MMIO_F(_MMIO(_DPC_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^~~~~
drivers/gpu/drm/i915/gvt/handlers.c:2879:15: error: ‘_DPD_AUX_CH_CTL’ undeclared (first use in this function); did you mean ‘_DPC_AUX_CH_CTL’?
MMIO_F(_MMIO(_DPD_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^
drivers/gpu/drm/i915/gvt/handlers.c:1811:48: note: in definition of macro ‘MMIO_F’
ret = new_mmio_info(gvt, i915_mmio_reg_offset(reg), \
^~~
drivers/gpu/drm/i915/gvt/handlers.c:2879:9: note: in expansion of macro ‘_MMIO’
MMIO_F(_MMIO(_DPD_AUX_CH_CTL), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
^~~~~
scripts/Makefile.build:265: recipe for target 'drivers/gpu/drm/i915/gvt/handlers.o' failed
make[4]: *** [drivers/gpu/drm/i915/gvt/handlers.o] Error 1
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:509: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1649: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev2)
@ 2019-10-26 5:37 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 5:37 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev2)
URL : https://patchwork.freedesktop.org/series/68590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1fb885c67a37 drm/i915/tgl: Handle AUX interrupts for TC ports
81a9ba208d76 drm/i915: Drop unused AUX register offsets
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2879:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2881:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2883:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
total: 0 errors, 0 warnings, 3 checks, 79 lines checked
5ab53ab777ff drm/i915: Add missing AUX channel H & I support
-:75: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#75: FILE: drivers/gpu/drm/i915/display/intel_display.c:6862:
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
cc05f7b3dee9 drm/i915: Provide more information on DP AUX failures
a7aae46d1913 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev2)
@ 2019-10-26 5:37 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 5:37 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev2)
URL : https://patchwork.freedesktop.org/series/68590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1fb885c67a37 drm/i915/tgl: Handle AUX interrupts for TC ports
81a9ba208d76 drm/i915: Drop unused AUX register offsets
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2879:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2881:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2883:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
total: 0 errors, 0 warnings, 3 checks, 79 lines checked
5ab53ab777ff drm/i915: Add missing AUX channel H & I support
-:75: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#75: FILE: drivers/gpu/drm/i915/display/intel_display.c:6862:
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
cc05f7b3dee9 drm/i915: Provide more information on DP AUX failures
a7aae46d1913 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* ✗ Fi.CI.BAT: failure for DP AUX updates (rev2)
@ 2019-10-26 5:57 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 5:57 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev2)
URL : https://patchwork.freedesktop.org/series/68590/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7191 -> Patchwork_14997
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14997 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14997, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14997:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-n3050: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
Known issues
------------
Here are the changes found in Patchwork_14997 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][2] -> [FAIL][3] ([fdo#111407])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_flip@basic-flip-vs-dpms:
- fi-skl-6770hq: [PASS][4] -> [SKIP][5] ([fdo#109271]) +26 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-skl-6770hq/igt@kms_flip@basic-flip-vs-dpms.html
#### Possible fixes ####
* igt@gem_close_race@basic-process:
- fi-icl-u3: [INCOMPLETE][6] ([fdo#107713]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-icl-u3/igt@gem_close_race@basic-process.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-icl-u3/igt@gem_close_race@basic-process.html
* igt@gem_ctx_switch@rcs0:
- fi-icl-u2: [INCOMPLETE][8] ([fdo#107713]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-kefka: [INCOMPLETE][10] -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-bsw-kefka/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_hangcheck:
- {fi-tgl-u2}: [INCOMPLETE][12] ([fdo#111747]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-tgl-u2/igt@i915_selftest@live_hangcheck.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-tgl-u2/igt@i915_selftest@live_hangcheck.html
- {fi-icl-guc}: [INCOMPLETE][14] ([fdo#107713] / [fdo#108569]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
Participating hosts (50 -> 43)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7191 -> Patchwork_14997
CI-20190529: 20190529
CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14997: a7aae46d19130db6bd27527ea2bc848935b0a853 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a7aae46d1913 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
cc05f7b3dee9 drm/i915: Provide more information on DP AUX failures
5ab53ab777ff drm/i915: Add missing AUX channel H & I support
81a9ba208d76 drm/i915: Drop unused AUX register offsets
1fb885c67a37 drm/i915/tgl: Handle AUX interrupts for TC ports
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14997/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3)
@ 2019-10-26 6:26 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 6:26 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e8d35bb35f25 drm/i915/tgl: Handle AUX interrupts for TC ports
8902f9c59666 drm/i915: Drop unused AUX register offsets
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2879:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2881:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2883:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
total: 0 errors, 0 warnings, 3 checks, 79 lines checked
ec5b0b7e9f53 drm/i915: Add missing AUX channel H & I support
-:75: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#75: FILE: drivers/gpu/drm/i915/display/intel_display.c:6862:
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
cd4efc30f3a8 drm/i915: Provide more information on DP AUX failures
4eb074ab8c76 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP AUX updates (rev3)
@ 2019-10-26 6:26 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 6:26 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e8d35bb35f25 drm/i915/tgl: Handle AUX interrupts for TC ports
8902f9c59666 drm/i915: Drop unused AUX register offsets
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2879:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_B), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:51: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#51: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2881:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_C), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
-:54: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#54: FILE: drivers/gpu/drm/i915/gvt/handlers.c:2883:
+ MMIO_F(DP_AUX_CH_CTL(AUX_CH_D), 6 * 4, 0, 0, 0, D_SKL_PLUS, NULL,
dp_aux_ch_ctl_mmio_write);
total: 0 errors, 0 warnings, 3 checks, 79 lines checked
ec5b0b7e9f53 drm/i915: Add missing AUX channel H & I support
-:75: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#75: FILE: drivers/gpu/drm/i915/display/intel_display.c:6862:
+ return POWER_DOMAIN_AUX_A + dig_port->aux_ch;
+ } else {
total: 0 errors, 1 warnings, 0 checks, 91 lines checked
cd4efc30f3a8 drm/i915: Provide more information on DP AUX failures
4eb074ab8c76 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread
* ✓ Fi.CI.BAT: success for DP AUX updates (rev3)
@ 2019-10-26 6:47 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-26 6:47 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7191 -> Patchwork_14998
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
Known issues
------------
Here are the changes found in Patchwork_14998 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@gem_close_race@basic-process:
- fi-icl-u3: [INCOMPLETE][1] ([fdo#107713]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-icl-u3/igt@gem_close_race@basic-process.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/fi-icl-u3/igt@gem_close_race@basic-process.html
* igt@gem_ctx_switch@rcs0:
- fi-icl-u2: [INCOMPLETE][3] ([fdo#107713]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
* igt@i915_selftest@live_hangcheck:
- {fi-icl-guc}: [INCOMPLETE][5] ([fdo#107713] / [fdo#108569]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/fi-icl-guc/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (50 -> 43)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7191 -> Patchwork_14998
CI-20190529: 20190529
CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4eb074ab8c76 drm/i915/tgl: Add AUX B & C to DC_OFF_POWER_DOMAINS
cd4efc30f3a8 drm/i915: Provide more information on DP AUX failures
ec5b0b7e9f53 drm/i915: Add missing AUX channel H & I support
8902f9c59666 drm/i915: Drop unused AUX register offsets
e8d35bb35f25 drm/i915/tgl: Handle AUX interrupts for TC ports
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* ✓ Fi.CI.IGT: success for DP AUX updates (rev3)
@ 2019-10-28 1:02 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-28 1:02 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14998_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14998_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +15 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [PASS][9] -> [INCOMPLETE][10] ([fdo#105411])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb2/igt@gem_mmap_gtt@hang.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_mmap_gtt@hang.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk8/igt@i915_selftest@mock_requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk8/igt@i915_selftest@mock_requests.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103232])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +6 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][21] -> [FAIL][22] ([fdo#104873])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-glk: [PASS][23] -> [FAIL][24] ([fdo#111609])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_isolation@vcs1-dirty-create.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_shared@q-smoketest-all:
- {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_ctx_shared@q-smoketest-render:
- {shard-tglb}: [INCOMPLETE][41] ([fdo# 111852 ]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@gem_ctx_shared@q-smoketest-render.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +11 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_switch@vcs1-heavy.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@reset-stress:
- shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl2/igt@gem_eio@reset-stress.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +17 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_rpm@cursor:
- shard-skl: [DMESG-WARN][53] ([fdo#105541]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl1/igt@i915_pm_rpm@cursor.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- {shard-tglb}: [FAIL][55] ([fdo#102670]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend:
- shard-kbl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl3/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-skl: [FAIL][61] ([fdo#108134]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip_tiling@flip-to-x-tiled.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl5/igt@kms_flip_tiling@flip-to-x-tiled.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- {shard-tglb}: [INCOMPLETE][63] ([fdo#111884]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-skl: [FAIL][71] ([fdo#110038]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
[fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 12)
------------------------------
Additional (1): pig-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7191 -> Patchwork_14998
CI-20190529: 20190529
CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* [Intel-gfx] ✓ Fi.CI.IGT: success for DP AUX updates (rev3)
@ 2019-10-28 1:02 ` Patchwork
0 siblings, 0 replies; 56+ messages in thread
From: Patchwork @ 2019-10-28 1:02 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: DP AUX updates (rev3)
URL : https://patchwork.freedesktop.org/series/68590/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14998_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14998_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +15 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [PASS][9] -> [INCOMPLETE][10] ([fdo#105411])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb2/igt@gem_mmap_gtt@hang.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_mmap_gtt@hang.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_userptr_blits@sync-unmap:
- shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk8/igt@i915_selftest@mock_requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk8/igt@i915_selftest@mock_requests.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103232])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +6 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][21] -> [FAIL][22] ([fdo#104873])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-glk: [PASS][23] -> [FAIL][24] ([fdo#111609])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_isolation@vcs1-dirty-create.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_ctx_shared@q-smoketest-all:
- {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_ctx_shared@q-smoketest-render:
- {shard-tglb}: [INCOMPLETE][41] ([fdo# 111852 ]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@gem_ctx_shared@q-smoketest-render.html
* igt@gem_ctx_switch@vcs1-heavy:
- shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +11 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_switch@vcs1-heavy.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
* igt@gem_eio@reset-stress:
- shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl2/igt@gem_eio@reset-stress.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +17 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_rpm@cursor:
- shard-skl: [DMESG-WARN][53] ([fdo#105541]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl1/igt@i915_pm_rpm@cursor.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- {shard-tglb}: [FAIL][55] ([fdo#102670]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_fbcon_fbt@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-suspend:
- shard-kbl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl3/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-skl: [FAIL][61] ([fdo#108134]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip_tiling@flip-to-x-tiled.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl5/igt@kms_flip_tiling@flip-to-x-tiled.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- {shard-tglb}: [INCOMPLETE][63] ([fdo#111884]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-skl: [FAIL][71] ([fdo#110038]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852
[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
[fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
[fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 12)
------------------------------
Additional (1): pig-snb-2600
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7191 -> Patchwork_14998
CI-20190529: 20190529
CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: ✓ Fi.CI.IGT: success for DP AUX updates (rev3)
@ 2019-10-29 17:58 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-29 17:58 UTC (permalink / raw)
To: intel-gfx
On Mon, Oct 28, 2019 at 01:02:09AM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: DP AUX updates (rev3)
> URL : https://patchwork.freedesktop.org/series/68590/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14998_full
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
Pushed patches #2 and #5 to dinq. Patch #1 had already landed and based
on Lucas' feedback we probably don't need to bother with patch #3. It
might be nice to add #4 eventually (or Ville's series) for extra
debugging output, but that's non-critical.
Matt
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_14998_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_ctx_isolation@vcs0-s3:
> - shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108])
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
>
> * igt@gem_exec_parallel@vcs1-fds:
> - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
>
> * igt@gem_exec_schedule@promotion-bsd1:
> - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +15 similar issues
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
>
> * igt@gem_exec_schedule@reorder-wide-bsd:
> - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
>
> * igt@gem_mmap_gtt@hang:
> - shard-snb: [PASS][9] -> [INCOMPLETE][10] ([fdo#105411])
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb2/igt@gem_mmap_gtt@hang.html
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_mmap_gtt@hang.html
>
> * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
> - shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
>
> * igt@gem_userptr_blits@sync-unmap:
> - shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
>
> * igt@i915_selftest@mock_requests:
> - shard-glk: [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133])
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk8/igt@i915_selftest@mock_requests.html
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk8/igt@i915_selftest@mock_requests.html
>
> * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
> - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103232])
> [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
>
> * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +6 similar issues
> [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>
> * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
> - shard-glk: [PASS][21] -> [FAIL][22] ([fdo#104873])
> [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
>
> * igt@kms_flip@dpms-vs-vblank-race-interruptible:
> - shard-glk: [PASS][23] -> [FAIL][24] ([fdo#111609])
> [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
> [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
>
> * igt@kms_flip@flip-vs-expired-vblank:
> - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
> [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
> [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
>
> * igt@kms_flip@flip-vs-suspend:
> - shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
> [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
> [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
>
> * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
> - shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
> [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
>
> * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
> - shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
> [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>
> * igt@kms_plane_lowres@pipe-a-tiling-x:
> - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166]) +1 similar issue
> [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
> [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
>
> * igt@kms_psr@psr2_sprite_render:
> - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
> [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
> [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
>
>
> #### Possible fixes ####
>
> * igt@gem_ctx_isolation@vcs1-dirty-create:
> - shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38]
> [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_isolation@vcs1-dirty-create.html
> [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
>
> * igt@gem_ctx_shared@q-smoketest-all:
> - {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
> [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
> [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@gem_ctx_shared@q-smoketest-all.html
>
> * igt@gem_ctx_shared@q-smoketest-render:
> - {shard-tglb}: [INCOMPLETE][41] ([fdo# 111852 ]) -> [PASS][42] +1 similar issue
> [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
> [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@gem_ctx_shared@q-smoketest-render.html
>
> * igt@gem_ctx_switch@vcs1-heavy:
> - shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +11 similar issues
> [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_switch@vcs1-heavy.html
> [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
>
> * igt@gem_eio@reset-stress:
> - shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46]
> [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
> [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl2/igt@gem_eio@reset-stress.html
>
> * igt@gem_exec_schedule@preempt-other-chain-bsd:
> - shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
> [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
>
> * igt@gem_exec_schedule@preempt-queue-bsd1:
> - shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +17 similar issues
> [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
> [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
>
> * igt@gem_userptr_blits@sync-unmap-cycles:
> - shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
> [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
> [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
>
> * igt@i915_pm_rpm@cursor:
> - shard-skl: [DMESG-WARN][53] ([fdo#105541]) -> [PASS][54]
> [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
> [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl1/igt@i915_pm_rpm@cursor.html
>
> * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
> - {shard-tglb}: [FAIL][55] ([fdo#102670]) -> [PASS][56]
> [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
>
> * igt@kms_fbcon_fbt@fbc-suspend:
> - {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
> [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
> [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
>
> * igt@kms_flip@flip-vs-suspend:
> - shard-kbl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +1 similar issue
> [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
> [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl3/igt@kms_flip@flip-vs-suspend.html
>
> * igt@kms_flip_tiling@flip-to-x-tiled:
> - shard-skl: [FAIL][61] ([fdo#108134]) -> [PASS][62]
> [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip_tiling@flip-to-x-tiled.html
> [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl5/igt@kms_flip_tiling@flip-to-x-tiled.html
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
> - {shard-tglb}: [INCOMPLETE][63] ([fdo#111884]) -> [PASS][64]
> [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
> [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
>
> * igt@kms_frontbuffer_tracking@fbc-stridechange:
> - {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +2 similar issues
> [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
> [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
>
> * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> - shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +2 similar issues
> [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
>
> * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
> - shard-skl: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
> [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
> [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
>
> * igt@kms_plane@plane-position-covered-pipe-a-planes:
> - shard-skl: [FAIL][71] ([fdo#110038]) -> [PASS][72]
> [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
> [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
>
> * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> - shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74]
> [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>
> * igt@kms_psr@psr2_no_drrs:
> - shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
> [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
> [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852
> [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
> [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
> [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
> [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
> [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
> [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
> [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
> [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
> [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
> [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
> [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
> [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> [fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
> [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
> [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
> [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
> [fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
> [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
> [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
> [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
> [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (11 -> 12)
> ------------------------------
>
> Additional (1): pig-snb-2600
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * Linux: CI_DRM_7191 -> Patchwork_14998
>
> CI-20190529: 20190529
> CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] ✓ Fi.CI.IGT: success for DP AUX updates (rev3)
@ 2019-10-29 17:58 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-29 17:58 UTC (permalink / raw)
To: intel-gfx
On Mon, Oct 28, 2019 at 01:02:09AM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: DP AUX updates (rev3)
> URL : https://patchwork.freedesktop.org/series/68590/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14998_full
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
Pushed patches #2 and #5 to dinq. Patch #1 had already landed and based
on Lucas' feedback we probably don't need to bother with patch #3. It
might be nice to add #4 eventually (or Ville's series) for extra
debugging output, but that's non-critical.
Matt
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_14998_full that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_ctx_isolation@vcs0-s3:
> - shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108])
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
>
> * igt@gem_exec_parallel@vcs1-fds:
> - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
>
> * igt@gem_exec_schedule@promotion-bsd1:
> - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +15 similar issues
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
>
> * igt@gem_exec_schedule@reorder-wide-bsd:
> - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
>
> * igt@gem_mmap_gtt@hang:
> - shard-snb: [PASS][9] -> [INCOMPLETE][10] ([fdo#105411])
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb2/igt@gem_mmap_gtt@hang.html
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_mmap_gtt@hang.html
>
> * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
> - shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
>
> * igt@gem_userptr_blits@sync-unmap:
> - shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
>
> * igt@i915_selftest@mock_requests:
> - shard-glk: [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133])
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk8/igt@i915_selftest@mock_requests.html
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk8/igt@i915_selftest@mock_requests.html
>
> * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
> - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103232])
> [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
>
> * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +6 similar issues
> [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>
> * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
> - shard-glk: [PASS][21] -> [FAIL][22] ([fdo#104873])
> [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
>
> * igt@kms_flip@dpms-vs-vblank-race-interruptible:
> - shard-glk: [PASS][23] -> [FAIL][24] ([fdo#111609])
> [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
> [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
>
> * igt@kms_flip@flip-vs-expired-vblank:
> - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
> [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
> [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
>
> * igt@kms_flip@flip-vs-suspend:
> - shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
> [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
> [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
>
> * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
> - shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
> [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
>
> * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
> - shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
> [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
>
> * igt@kms_plane_lowres@pipe-a-tiling-x:
> - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166]) +1 similar issue
> [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
> [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
>
> * igt@kms_psr@psr2_sprite_render:
> - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
> [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
> [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
>
>
> #### Possible fixes ####
>
> * igt@gem_ctx_isolation@vcs1-dirty-create:
> - shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38]
> [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_isolation@vcs1-dirty-create.html
> [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
>
> * igt@gem_ctx_shared@q-smoketest-all:
> - {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
> [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
> [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@gem_ctx_shared@q-smoketest-all.html
>
> * igt@gem_ctx_shared@q-smoketest-render:
> - {shard-tglb}: [INCOMPLETE][41] ([fdo# 111852 ]) -> [PASS][42] +1 similar issue
> [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
> [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@gem_ctx_shared@q-smoketest-render.html
>
> * igt@gem_ctx_switch@vcs1-heavy:
> - shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +11 similar issues
> [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_switch@vcs1-heavy.html
> [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
>
> * igt@gem_eio@reset-stress:
> - shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46]
> [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
> [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl2/igt@gem_eio@reset-stress.html
>
> * igt@gem_exec_schedule@preempt-other-chain-bsd:
> - shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
> [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
>
> * igt@gem_exec_schedule@preempt-queue-bsd1:
> - shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +17 similar issues
> [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
> [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
>
> * igt@gem_userptr_blits@sync-unmap-cycles:
> - shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
> [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
> [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
>
> * igt@i915_pm_rpm@cursor:
> - shard-skl: [DMESG-WARN][53] ([fdo#105541]) -> [PASS][54]
> [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
> [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl1/igt@i915_pm_rpm@cursor.html
>
> * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
> - {shard-tglb}: [FAIL][55] ([fdo#102670]) -> [PASS][56]
> [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
>
> * igt@kms_fbcon_fbt@fbc-suspend:
> - {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
> [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
> [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
>
> * igt@kms_flip@flip-vs-suspend:
> - shard-kbl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +1 similar issue
> [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
> [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl3/igt@kms_flip@flip-vs-suspend.html
>
> * igt@kms_flip_tiling@flip-to-x-tiled:
> - shard-skl: [FAIL][61] ([fdo#108134]) -> [PASS][62]
> [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip_tiling@flip-to-x-tiled.html
> [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl5/igt@kms_flip_tiling@flip-to-x-tiled.html
>
> * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
> - {shard-tglb}: [INCOMPLETE][63] ([fdo#111884]) -> [PASS][64]
> [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
> [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
>
> * igt@kms_frontbuffer_tracking@fbc-stridechange:
> - {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +2 similar issues
> [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
> [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
>
> * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> - shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +2 similar issues
> [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
>
> * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
> - shard-skl: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
> [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
> [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
>
> * igt@kms_plane@plane-position-covered-pipe-a-planes:
> - shard-skl: [FAIL][71] ([fdo#110038]) -> [PASS][72]
> [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
> [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
>
> * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> - shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74]
> [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>
> * igt@kms_psr@psr2_no_drrs:
> - shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
> [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
> [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852
> [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
> [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
> [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
> [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
> [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
> [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
> [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
> [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
> [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
> [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
> [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
> [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
> [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> [fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
> [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
> [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
> [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
> [fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
> [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
> [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
> [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
> [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> Participating hosts (11 -> 12)
> ------------------------------
>
> Additional (1): pig-snb-2600
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * Linux: CI_DRM_7191 -> Patchwork_14998
>
> CI-20190529: 20190529
> CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: ✓ Fi.CI.IGT: success for DP AUX updates (rev3)
@ 2019-10-29 19:56 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-29 19:56 UTC (permalink / raw)
To: intel-gfx
On Tue, Oct 29, 2019 at 10:58:52AM -0700, Matt Roper wrote:
> On Mon, Oct 28, 2019 at 01:02:09AM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: DP AUX updates (rev3)
> > URL : https://patchwork.freedesktop.org/series/68590/
> > State : success
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14998_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **SUCCESS**
> >
> > No regressions found.
> >
>
> Pushed patches #2 and #5 to dinq. Patch #1 had already landed and based
> on Lucas' feedback we probably don't need to bother with patch #3. It
> might be nice to add #4 eventually (or Ville's series) for extra
> debugging output, but that's non-critical.
>
Patch #4 is also now pushed with Lucas' r-b.
>
> Matt
>
> >
> >
> > Known issues
> > ------------
> >
> > Here are the changes found in Patchwork_14998_full that come from known issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> > * igt@gem_ctx_isolation@vcs0-s3:
> > - shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108])
> > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
> > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
> >
> > * igt@gem_exec_parallel@vcs1-fds:
> > - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
> > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
> > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
> >
> > * igt@gem_exec_schedule@promotion-bsd1:
> > - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +15 similar issues
> > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
> > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
> >
> > * igt@gem_exec_schedule@reorder-wide-bsd:
> > - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
> > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
> > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
> >
> > * igt@gem_mmap_gtt@hang:
> > - shard-snb: [PASS][9] -> [INCOMPLETE][10] ([fdo#105411])
> > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb2/igt@gem_mmap_gtt@hang.html
> > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_mmap_gtt@hang.html
> >
> > * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
> > - shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
> > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> >
> > * igt@gem_userptr_blits@sync-unmap:
> > - shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
> > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
> > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
> >
> > * igt@i915_selftest@mock_requests:
> > - shard-glk: [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133])
> > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk8/igt@i915_selftest@mock_requests.html
> > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk8/igt@i915_selftest@mock_requests.html
> >
> > * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
> > - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103232])
> > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> >
> > * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> > - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +6 similar issues
> > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> >
> > * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
> > - shard-glk: [PASS][21] -> [FAIL][22] ([fdo#104873])
> > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> >
> > * igt@kms_flip@dpms-vs-vblank-race-interruptible:
> > - shard-glk: [PASS][23] -> [FAIL][24] ([fdo#111609])
> > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
> > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
> >
> > * igt@kms_flip@flip-vs-expired-vblank:
> > - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
> > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
> > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
> >
> > * igt@kms_flip@flip-vs-suspend:
> > - shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
> > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
> > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
> > - shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
> > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> >
> > * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
> > - shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
> > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> >
> > * igt@kms_plane_lowres@pipe-a-tiling-x:
> > - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166]) +1 similar issue
> > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
> >
> > * igt@kms_psr@psr2_sprite_render:
> > - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
> > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
> > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
> >
> >
> > #### Possible fixes ####
> >
> > * igt@gem_ctx_isolation@vcs1-dirty-create:
> > - shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38]
> > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_isolation@vcs1-dirty-create.html
> > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
> >
> > * igt@gem_ctx_shared@q-smoketest-all:
> > - {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
> > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
> > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@gem_ctx_shared@q-smoketest-all.html
> >
> > * igt@gem_ctx_shared@q-smoketest-render:
> > - {shard-tglb}: [INCOMPLETE][41] ([fdo# 111852 ]) -> [PASS][42] +1 similar issue
> > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
> > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@gem_ctx_shared@q-smoketest-render.html
> >
> > * igt@gem_ctx_switch@vcs1-heavy:
> > - shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +11 similar issues
> > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_switch@vcs1-heavy.html
> > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
> >
> > * igt@gem_eio@reset-stress:
> > - shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46]
> > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
> > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl2/igt@gem_eio@reset-stress.html
> >
> > * igt@gem_exec_schedule@preempt-other-chain-bsd:
> > - shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
> > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> >
> > * igt@gem_exec_schedule@preempt-queue-bsd1:
> > - shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +17 similar issues
> > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
> >
> > * igt@gem_userptr_blits@sync-unmap-cycles:
> > - shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
> > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
> > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
> >
> > * igt@i915_pm_rpm@cursor:
> > - shard-skl: [DMESG-WARN][53] ([fdo#105541]) -> [PASS][54]
> > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
> > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl1/igt@i915_pm_rpm@cursor.html
> >
> > * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
> > - {shard-tglb}: [FAIL][55] ([fdo#102670]) -> [PASS][56]
> > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> >
> > * igt@kms_fbcon_fbt@fbc-suspend:
> > - {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
> > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
> > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
> >
> > * igt@kms_flip@flip-vs-suspend:
> > - shard-kbl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +1 similar issue
> > [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
> > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl3/igt@kms_flip@flip-vs-suspend.html
> >
> > * igt@kms_flip_tiling@flip-to-x-tiled:
> > - shard-skl: [FAIL][61] ([fdo#108134]) -> [PASS][62]
> > [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip_tiling@flip-to-x-tiled.html
> > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl5/igt@kms_flip_tiling@flip-to-x-tiled.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
> > - {shard-tglb}: [INCOMPLETE][63] ([fdo#111884]) -> [PASS][64]
> > [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
> > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-stridechange:
> > - {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +2 similar issues
> > [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
> > [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
> >
> > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> > - shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +2 similar issues
> > [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> > [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> >
> > * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
> > - shard-skl: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
> > [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
> > [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
> >
> > * igt@kms_plane@plane-position-covered-pipe-a-planes:
> > - shard-skl: [FAIL][71] ([fdo#110038]) -> [PASS][72]
> > [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
> > [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
> >
> > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> > - shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74]
> > [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> > [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> >
> > * igt@kms_psr@psr2_no_drrs:
> > - shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
> > [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
> > [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
> >
> >
> > {name}: This element is suppressed. This means it is ignored when computing
> > the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> > [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852
> > [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
> > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> > [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
> > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> > [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
> > [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
> > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
> > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
> > [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
> > [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
> > [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
> > [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
> > [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
> > [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
> > [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> > [fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
> > [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
> > [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
> > [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
> > [fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
> > [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
> > [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
> > [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
> > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> >
> >
> > Participating hosts (11 -> 12)
> > ------------------------------
> >
> > Additional (1): pig-snb-2600
> >
> >
> > Build changes
> > -------------
> >
> > * CI: CI-20190529 -> None
> > * Linux: CI_DRM_7191 -> Patchwork_14998
> >
> > CI-20190529: 20190529
> > CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
> > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
>
> --
> Matt Roper
> Graphics Software Engineer
> VTT-OSGC Platform Enablement
> Intel Corporation
> (916) 356-2795
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread* Re: [Intel-gfx] ✓ Fi.CI.IGT: success for DP AUX updates (rev3)
@ 2019-10-29 19:56 ` Matt Roper
0 siblings, 0 replies; 56+ messages in thread
From: Matt Roper @ 2019-10-29 19:56 UTC (permalink / raw)
To: intel-gfx
On Tue, Oct 29, 2019 at 10:58:52AM -0700, Matt Roper wrote:
> On Mon, Oct 28, 2019 at 01:02:09AM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: DP AUX updates (rev3)
> > URL : https://patchwork.freedesktop.org/series/68590/
> > State : success
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_7191_full -> Patchwork_14998_full
> > ====================================================
> >
> > Summary
> > -------
> >
> > **SUCCESS**
> >
> > No regressions found.
> >
>
> Pushed patches #2 and #5 to dinq. Patch #1 had already landed and based
> on Lucas' feedback we probably don't need to bother with patch #3. It
> might be nice to add #4 eventually (or Ville's series) for extra
> debugging output, but that's non-critical.
>
Patch #4 is also now pushed with Lucas' r-b.
>
> Matt
>
> >
> >
> > Known issues
> > ------------
> >
> > Here are the changes found in Patchwork_14998_full that come from known issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> > * igt@gem_ctx_isolation@vcs0-s3:
> > - shard-skl: [PASS][1] -> [INCOMPLETE][2] ([fdo#104108])
> > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
> > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@gem_ctx_isolation@vcs0-s3.html
> >
> > * igt@gem_exec_parallel@vcs1-fds:
> > - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +9 similar issues
> > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_parallel@vcs1-fds.html
> > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@gem_exec_parallel@vcs1-fds.html
> >
> > * igt@gem_exec_schedule@promotion-bsd1:
> > - shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#109276]) +15 similar issues
> > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@gem_exec_schedule@promotion-bsd1.html
> > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@promotion-bsd1.html
> >
> > * igt@gem_exec_schedule@reorder-wide-bsd:
> > - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#111325]) +6 similar issues
> > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@reorder-wide-bsd.html
> > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
> >
> > * igt@gem_mmap_gtt@hang:
> > - shard-snb: [PASS][9] -> [INCOMPLETE][10] ([fdo#105411])
> > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb2/igt@gem_mmap_gtt@hang.html
> > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_mmap_gtt@hang.html
> >
> > * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
> > - shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870])
> > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
> >
> > * igt@gem_userptr_blits@sync-unmap:
> > - shard-hsw: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870])
> > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw5/igt@gem_userptr_blits@sync-unmap.html
> > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@gem_userptr_blits@sync-unmap.html
> >
> > * igt@i915_selftest@mock_requests:
> > - shard-glk: [PASS][15] -> [INCOMPLETE][16] ([fdo#103359] / [k.org#198133])
> > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk8/igt@i915_selftest@mock_requests.html
> > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk8/igt@i915_selftest@mock_requests.html
> >
> > * igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
> > - shard-skl: [PASS][17] -> [FAIL][18] ([fdo#103232])
> > [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> > [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen.html
> >
> > * igt@kms_cursor_crc@pipe-a-cursor-suspend:
> > - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([fdo#108566]) +6 similar issues
> > [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> > [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> >
> > * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
> > - shard-glk: [PASS][21] -> [FAIL][22] ([fdo#104873])
> > [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> > [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
> >
> > * igt@kms_flip@dpms-vs-vblank-race-interruptible:
> > - shard-glk: [PASS][23] -> [FAIL][24] ([fdo#111609])
> > [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-glk7/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
> > [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-glk3/igt@kms_flip@dpms-vs-vblank-race-interruptible.html
> >
> > * igt@kms_flip@flip-vs-expired-vblank:
> > - shard-skl: [PASS][25] -> [FAIL][26] ([fdo#105363])
> > [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
> > [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html
> >
> > * igt@kms_flip@flip-vs-suspend:
> > - shard-hsw: [PASS][27] -> [INCOMPLETE][28] ([fdo#103540])
> > [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-hsw6/igt@kms_flip@flip-vs-suspend.html
> > [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
> > - shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +1 similar issue
> > [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> > [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
> >
> > * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
> > - shard-apl: [PASS][31] -> [DMESG-WARN][32] ([fdo#108566]) +1 similar issue
> > [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> > [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
> >
> > * igt@kms_plane_lowres@pipe-a-tiling-x:
> > - shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166]) +1 similar issue
> > [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-x.html
> > [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_plane_lowres@pipe-a-tiling-x.html
> >
> > * igt@kms_psr@psr2_sprite_render:
> > - shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441])
> > [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
> > [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
> >
> >
> > #### Possible fixes ####
> >
> > * igt@gem_ctx_isolation@vcs1-dirty-create:
> > - shard-iclb: [SKIP][37] ([fdo#109276] / [fdo#112080]) -> [PASS][38]
> > [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_isolation@vcs1-dirty-create.html
> > [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
> >
> > * igt@gem_ctx_shared@q-smoketest-all:
> > - {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
> > [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
> > [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@gem_ctx_shared@q-smoketest-all.html
> >
> > * igt@gem_ctx_shared@q-smoketest-render:
> > - {shard-tglb}: [INCOMPLETE][41] ([fdo# 111852 ]) -> [PASS][42] +1 similar issue
> > [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@gem_ctx_shared@q-smoketest-render.html
> > [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@gem_ctx_shared@q-smoketest-render.html
> >
> > * igt@gem_ctx_switch@vcs1-heavy:
> > - shard-iclb: [SKIP][43] ([fdo#112080]) -> [PASS][44] +11 similar issues
> > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb7/igt@gem_ctx_switch@vcs1-heavy.html
> > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy.html
> >
> > * igt@gem_eio@reset-stress:
> > - shard-apl: [INCOMPLETE][45] ([fdo#103927]) -> [PASS][46]
> > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-apl3/igt@gem_eio@reset-stress.html
> > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-apl2/igt@gem_eio@reset-stress.html
> >
> > * igt@gem_exec_schedule@preempt-other-chain-bsd:
> > - shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
> > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> >
> > * igt@gem_exec_schedule@preempt-queue-bsd1:
> > - shard-iclb: [SKIP][49] ([fdo#109276]) -> [PASS][50] +17 similar issues
> > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@gem_exec_schedule@preempt-queue-bsd1.html
> > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
> >
> > * igt@gem_userptr_blits@sync-unmap-cycles:
> > - shard-snb: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
> > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
> > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-snb6/igt@gem_userptr_blits@sync-unmap-cycles.html
> >
> > * igt@i915_pm_rpm@cursor:
> > - shard-skl: [DMESG-WARN][53] ([fdo#105541]) -> [PASS][54]
> > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl10/igt@i915_pm_rpm@cursor.html
> > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl1/igt@i915_pm_rpm@cursor.html
> >
> > * igt@kms_cursor_legacy@flip-vs-cursor-legacy:
> > - {shard-tglb}: [FAIL][55] ([fdo#102670]) -> [PASS][56]
> > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
> >
> > * igt@kms_fbcon_fbt@fbc-suspend:
> > - {shard-tglb}: [INCOMPLETE][57] ([fdo#111747] / [fdo#111832] / [fdo#111850]) -> [PASS][58]
> > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb8/igt@kms_fbcon_fbt@fbc-suspend.html
> > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
> >
> > * igt@kms_flip@flip-vs-suspend:
> > - shard-kbl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60] +1 similar issue
> > [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-kbl4/igt@kms_flip@flip-vs-suspend.html
> > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-kbl3/igt@kms_flip@flip-vs-suspend.html
> >
> > * igt@kms_flip_tiling@flip-to-x-tiled:
> > - shard-skl: [FAIL][61] ([fdo#108134]) -> [PASS][62]
> > [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl1/igt@kms_flip_tiling@flip-to-x-tiled.html
> > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl5/igt@kms_flip_tiling@flip-to-x-tiled.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
> > - {shard-tglb}: [INCOMPLETE][63] ([fdo#111884]) -> [PASS][64]
> > [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
> > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
> >
> > * igt@kms_frontbuffer_tracking@fbc-stridechange:
> > - {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +2 similar issues
> > [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-stridechange.html
> > [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-stridechange.html
> >
> > * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
> > - shard-iclb: [FAIL][67] ([fdo#103167]) -> [PASS][68] +2 similar issues
> > [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> > [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
> >
> > * igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
> > - shard-skl: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
> > [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
> > [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu.html
> >
> > * igt@kms_plane@plane-position-covered-pipe-a-planes:
> > - shard-skl: [FAIL][71] ([fdo#110038]) -> [PASS][72]
> > [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane@plane-position-covered-pipe-a-planes.html
> > [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane@plane-position-covered-pipe-a-planes.html
> >
> > * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
> > - shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74]
> > [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> > [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> >
> > * igt@kms_psr@psr2_no_drrs:
> > - shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +3 similar issues
> > [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7191/shard-iclb3/igt@kms_psr@psr2_no_drrs.html
> > [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
> >
> >
> > {name}: This element is suppressed. This means it is ignored when computing
> > the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> > [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852
> > [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
> > [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
> > [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
> > [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
> > [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
> > [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
> > [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> > [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
> > [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
> > [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
> > [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
> > [fdo#105541]: https://bugs.freedesktop.org/show_bug.cgi?id=105541
> > [fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
> > [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
> > [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
> > [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
> > [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
> > [fdo#110038]: https://bugs.freedesktop.org/show_bug.cgi?id=110038
> > [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
> > [fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
> > [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
> > [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
> > [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
> > [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
> > [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
> > [fdo#111795 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111795
> > [fdo#111830 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111830
> > [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
> > [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
> > [fdo#111865]: https://bugs.freedesktop.org/show_bug.cgi?id=111865
> > [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
> > [fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
> > [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
> > [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> >
> >
> > Participating hosts (11 -> 12)
> > ------------------------------
> >
> > Additional (1): pig-snb-2600
> >
> >
> > Build changes
> > -------------
> >
> > * CI: CI-20190529 -> None
> > * Linux: CI_DRM_7191 -> Patchwork_14998
> >
> > CI-20190529: 20190529
> > CI_DRM_7191: 59c58784011dbec9a742d33b3d8d673393b95112 @ git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_5242: 15c11e2df77f769b5fa9ca5b40a94f266370a479 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> > Patchwork_14998: 4eb074ab8c760157e8dd96c919ad7a08792cd80f @ git://anongit.freedesktop.org/gfx-ci/linux
> > piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14998/index.html
>
> --
> Matt Roper
> Graphics Software Engineer
> VTT-OSGC Platform Enablement
> Intel Corporation
> (916) 356-2795
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 56+ messages in thread