From: Shawn Guo <shawnguo@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Li Yang <leoyang.li@nxp.com>,
linux-devel@linux.nxdi.nxp.com, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v3] arm64: dts: ls1028a: Update the property of the DT node dpclk
Date: Sat, 26 Oct 2019 17:49:49 +0800 [thread overview]
Message-ID: <20191026094948.GF14401@dragon> (raw)
In-Reply-To: <20191014071327.28961-1-wen.he_1@nxp.com>
On Mon, Oct 14, 2019 at 03:13:27PM +0800, Wen He wrote:
> Update the property #clock-cells = <1> to #clock-cells = <0> of the
> dpclk, since the Display output pixel clock driver provides single
> clock output.
>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
The patch subject can be more specific like:
arm64: dts: ls1028a: Update #clock-cells of dpclk node
I updated it and applied patch.
Shawn
> ---
> change in v3:
> - according the maintainer correction node name
> - update the commit message
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 51fa8f57fdac..616b150a15aa 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -82,7 +82,7 @@
> dpclk: clock-controller@f1f0000 {
> compatible = "fsl,ls1028a-plldig";
> reg = <0x0 0xf1f0000 0x0 0xffff>;
> - #clock-cells = <1>;
> + #clock-cells = <0>;
> clocks = <&osc_27m>;
> };
>
> @@ -665,7 +665,7 @@
> interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> <0 223 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "DE", "SE";
> - clocks = <&dpclk 0>, <&clockgen 2 2>, <&clockgen 2 2>,
> + clocks = <&dpclk>, <&clockgen 2 2>, <&clockgen 2 2>,
> <&clockgen 2 2>;
> clock-names = "pxlclk", "mclk", "aclk", "pclk";
> arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Wen He <wen.he_1@nxp.com>
Cc: linux-devel@linux.nxdi.nxp.com, Li Yang <leoyang.li@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v3] arm64: dts: ls1028a: Update the property of the DT node dpclk
Date: Sat, 26 Oct 2019 17:49:49 +0800 [thread overview]
Message-ID: <20191026094948.GF14401@dragon> (raw)
In-Reply-To: <20191014071327.28961-1-wen.he_1@nxp.com>
On Mon, Oct 14, 2019 at 03:13:27PM +0800, Wen He wrote:
> Update the property #clock-cells = <1> to #clock-cells = <0> of the
> dpclk, since the Display output pixel clock driver provides single
> clock output.
>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
The patch subject can be more specific like:
arm64: dts: ls1028a: Update #clock-cells of dpclk node
I updated it and applied patch.
Shawn
> ---
> change in v3:
> - according the maintainer correction node name
> - update the commit message
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 51fa8f57fdac..616b150a15aa 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -82,7 +82,7 @@
> dpclk: clock-controller@f1f0000 {
> compatible = "fsl,ls1028a-plldig";
> reg = <0x0 0xf1f0000 0x0 0xffff>;
> - #clock-cells = <1>;
> + #clock-cells = <0>;
> clocks = <&osc_27m>;
> };
>
> @@ -665,7 +665,7 @@
> interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
> <0 223 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "DE", "SE";
> - clocks = <&dpclk 0>, <&clockgen 2 2>, <&clockgen 2 2>,
> + clocks = <&dpclk>, <&clockgen 2 2>, <&clockgen 2 2>,
> <&clockgen 2 2>;
> clock-names = "pxlclk", "mclk", "aclk", "pclk";
> arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-26 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 7:13 [v3] arm64: dts: ls1028a: Update the property of the DT node dpclk Wen He
2019-10-14 7:13 ` Wen He
2019-10-26 9:49 ` Shawn Guo [this message]
2019-10-26 9:49 ` Shawn Guo
2019-10-28 2:13 ` [EXT] " Wen He
2019-10-28 2:13 ` Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026094948.GF14401@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-devel@linux.nxdi.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.