From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org, virtio-fs@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>,
vgoyal@redhat.com
Subject: Re: [Virtio-fs] [RFC 1/3] WIP virtiofsd: import Linux <fuse.h> header file
Date: Sat, 26 Oct 2019 17:49:11 -0400 [thread overview]
Message-ID: <20191026174745-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191025100152.6638-2-stefanha@redhat.com>
On Fri, Oct 25, 2019 at 12:01:50PM +0200, Stefan Hajnoczi wrote:
> tests/vhost-user-fs-test.c needs fuse.h. The private copy that
> virtiofsd has can be replaced with a properly imported file using
> update-linux-headers.sh.
>
> TODO rerun update-linux-headers.sh with upstream kernel tree!
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
OK I would just add this with the virtiofsd patchset.
> ---
> contrib/virtiofsd/fuse_lowlevel.h | 2 +-
> .../fuse_kernel.h => include/standard-headers/linux/fuse.h | 0
> contrib/virtiofsd/fuse_loop_mt.c | 2 +-
> contrib/virtiofsd/fuse_lowlevel.c | 2 +-
> contrib/virtiofsd/fuse_virtio.c | 2 +-
> scripts/update-linux-headers.sh | 3 ++-
> 6 files changed, 6 insertions(+), 5 deletions(-)
> rename contrib/virtiofsd/fuse_kernel.h => include/standard-headers/linux/fuse.h (100%)
>
> diff --git a/contrib/virtiofsd/fuse_lowlevel.h b/contrib/virtiofsd/fuse_lowlevel.h
> index 79fb30a1c2..a8c92ff7e0 100644
> --- a/contrib/virtiofsd/fuse_lowlevel.h
> +++ b/contrib/virtiofsd/fuse_lowlevel.h
> @@ -23,7 +23,7 @@
> #endif
>
> #include "fuse_common.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
>
> #include <utime.h>
> #include <fcntl.h>
> diff --git a/contrib/virtiofsd/fuse_kernel.h b/include/standard-headers/linux/fuse.h
> similarity index 100%
> rename from contrib/virtiofsd/fuse_kernel.h
> rename to include/standard-headers/linux/fuse.h
> diff --git a/contrib/virtiofsd/fuse_loop_mt.c b/contrib/virtiofsd/fuse_loop_mt.c
> index 2000a8902a..af7b501fac 100644
> --- a/contrib/virtiofsd/fuse_loop_mt.c
> +++ b/contrib/virtiofsd/fuse_loop_mt.c
> @@ -11,7 +11,7 @@
> #include "fuse_i.h"
> #include "fuse_lowlevel.h"
> #include "fuse_misc.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
> #include "fuse_virtio.h"
>
> #include <stdio.h>
> diff --git a/contrib/virtiofsd/fuse_lowlevel.c b/contrib/virtiofsd/fuse_lowlevel.c
> index 78ccfe3a27..c1a901cb4d 100644
> --- a/contrib/virtiofsd/fuse_lowlevel.c
> +++ b/contrib/virtiofsd/fuse_lowlevel.c
> @@ -10,7 +10,7 @@
> */
>
> #include "fuse_i.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
> #include "fuse_opt.h"
> #include "fuse_misc.h"
> #include "fuse_virtio.h"
> diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> index 533ef24bb7..7a0d0b2603 100644
> --- a/contrib/virtiofsd/fuse_virtio.c
> +++ b/contrib/virtiofsd/fuse_virtio.c
> @@ -15,7 +15,7 @@
> #include "qapi/error.h"
>
> #include "fuse_i.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
> #include "fuse_misc.h"
> #include "fuse_opt.h"
> #include "fuse_virtio.h"
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index f76d77363b..1a627ccd73 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -184,7 +184,8 @@ EOF
>
> rm -rf "$output/include/standard-headers/linux"
> mkdir -p "$output/include/standard-headers/linux"
> -for i in "$tmpdir"/include/linux/*virtio*.h \
> +for i in "$tmpdir/include/linux/fuse.h" \
> + "$tmpdir"/include/linux/*virtio*.h \
> "$tmpdir/include/linux/qemu_fw_cfg.h" \
> "$tmpdir/include/linux/input.h" \
> "$tmpdir/include/linux/input-event-codes.h" \
> --
> 2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
virtio-fs@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
vgoyal@redhat.com
Subject: Re: [RFC 1/3] WIP virtiofsd: import Linux <fuse.h> header file
Date: Sat, 26 Oct 2019 17:49:11 -0400 [thread overview]
Message-ID: <20191026174745-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191025100152.6638-2-stefanha@redhat.com>
On Fri, Oct 25, 2019 at 12:01:50PM +0200, Stefan Hajnoczi wrote:
> tests/vhost-user-fs-test.c needs fuse.h. The private copy that
> virtiofsd has can be replaced with a properly imported file using
> update-linux-headers.sh.
>
> TODO rerun update-linux-headers.sh with upstream kernel tree!
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
OK I would just add this with the virtiofsd patchset.
> ---
> contrib/virtiofsd/fuse_lowlevel.h | 2 +-
> .../fuse_kernel.h => include/standard-headers/linux/fuse.h | 0
> contrib/virtiofsd/fuse_loop_mt.c | 2 +-
> contrib/virtiofsd/fuse_lowlevel.c | 2 +-
> contrib/virtiofsd/fuse_virtio.c | 2 +-
> scripts/update-linux-headers.sh | 3 ++-
> 6 files changed, 6 insertions(+), 5 deletions(-)
> rename contrib/virtiofsd/fuse_kernel.h => include/standard-headers/linux/fuse.h (100%)
>
> diff --git a/contrib/virtiofsd/fuse_lowlevel.h b/contrib/virtiofsd/fuse_lowlevel.h
> index 79fb30a1c2..a8c92ff7e0 100644
> --- a/contrib/virtiofsd/fuse_lowlevel.h
> +++ b/contrib/virtiofsd/fuse_lowlevel.h
> @@ -23,7 +23,7 @@
> #endif
>
> #include "fuse_common.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
>
> #include <utime.h>
> #include <fcntl.h>
> diff --git a/contrib/virtiofsd/fuse_kernel.h b/include/standard-headers/linux/fuse.h
> similarity index 100%
> rename from contrib/virtiofsd/fuse_kernel.h
> rename to include/standard-headers/linux/fuse.h
> diff --git a/contrib/virtiofsd/fuse_loop_mt.c b/contrib/virtiofsd/fuse_loop_mt.c
> index 2000a8902a..af7b501fac 100644
> --- a/contrib/virtiofsd/fuse_loop_mt.c
> +++ b/contrib/virtiofsd/fuse_loop_mt.c
> @@ -11,7 +11,7 @@
> #include "fuse_i.h"
> #include "fuse_lowlevel.h"
> #include "fuse_misc.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
> #include "fuse_virtio.h"
>
> #include <stdio.h>
> diff --git a/contrib/virtiofsd/fuse_lowlevel.c b/contrib/virtiofsd/fuse_lowlevel.c
> index 78ccfe3a27..c1a901cb4d 100644
> --- a/contrib/virtiofsd/fuse_lowlevel.c
> +++ b/contrib/virtiofsd/fuse_lowlevel.c
> @@ -10,7 +10,7 @@
> */
>
> #include "fuse_i.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
> #include "fuse_opt.h"
> #include "fuse_misc.h"
> #include "fuse_virtio.h"
> diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> index 533ef24bb7..7a0d0b2603 100644
> --- a/contrib/virtiofsd/fuse_virtio.c
> +++ b/contrib/virtiofsd/fuse_virtio.c
> @@ -15,7 +15,7 @@
> #include "qapi/error.h"
>
> #include "fuse_i.h"
> -#include "fuse_kernel.h"
> +#include "standard-headers/linux/fuse.h"
> #include "fuse_misc.h"
> #include "fuse_opt.h"
> #include "fuse_virtio.h"
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index f76d77363b..1a627ccd73 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -184,7 +184,8 @@ EOF
>
> rm -rf "$output/include/standard-headers/linux"
> mkdir -p "$output/include/standard-headers/linux"
> -for i in "$tmpdir"/include/linux/*virtio*.h \
> +for i in "$tmpdir/include/linux/fuse.h" \
> + "$tmpdir"/include/linux/*virtio*.h \
> "$tmpdir/include/linux/qemu_fw_cfg.h" \
> "$tmpdir/include/linux/input.h" \
> "$tmpdir/include/linux/input-event-codes.h" \
> --
> 2.21.0
next prev parent reply other threads:[~2019-10-26 21:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 10:01 [Virtio-fs] [RFC 0/3] tests/vhost-user-fs-test: add vhost-user-fs test case Stefan Hajnoczi
2019-10-25 10:01 ` Stefan Hajnoczi
2019-10-25 10:01 ` [Virtio-fs] [RFC 1/3] WIP virtiofsd: import Linux <fuse.h> header file Stefan Hajnoczi
2019-10-25 10:01 ` Stefan Hajnoczi
2019-10-26 21:49 ` Michael S. Tsirkin [this message]
2019-10-26 21:49 ` Michael S. Tsirkin
2019-10-27 12:36 ` [Virtio-fs] " Stefan Hajnoczi
2019-10-27 12:36 ` Stefan Hajnoczi
2020-06-01 10:28 ` [Virtio-fs] " Alex Bennée
2020-06-01 10:28 ` Alex Bennée
2020-06-01 15:55 ` [Virtio-fs] " Stefan Hajnoczi
2020-06-01 15:55 ` Stefan Hajnoczi
2019-10-25 10:01 ` [Virtio-fs] [RFC 2/3] qgraph: add an "after" test callback function Stefan Hajnoczi
2019-10-25 10:01 ` Stefan Hajnoczi
2019-10-25 10:01 ` [Virtio-fs] [RFC 3/3] tests/vhost-user-fs-test: add vhost-user-fs test case Stefan Hajnoczi
2019-10-25 10:01 ` Stefan Hajnoczi
2019-10-29 0:36 ` [Virtio-fs] " Dr. David Alan Gilbert
2019-10-29 0:36 ` Dr. David Alan Gilbert
2019-11-05 16:02 ` [Virtio-fs] " Stefan Hajnoczi
2019-11-05 16:02 ` Stefan Hajnoczi
2019-11-07 12:26 ` [Virtio-fs] " Dr. David Alan Gilbert
2019-11-07 12:26 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191026174745-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.