From: Greg KH <gregkh@linuxfoundation.org>
To: "Frank A. Cancio Bello" <frank@generalsoftwareinc.com>
Cc: outreachy-kernel@googlegroups.com,
saiprakash.ranjan@codeaurora.org, joel@joelfernandes.org
Subject: Re: [PATCH] staging: ks7010: Fix line ending with a '('
Date: Sun, 27 Oct 2019 08:12:19 +0100 [thread overview]
Message-ID: <20191027071219.GA1704509@kroah.com> (raw)
In-Reply-To: <20191027060237.GA26854@linux-kernel-dev>
On Sun, Oct 27, 2019 at 06:02:37AM +0000, Frank A. Cancio Bello wrote:
> checkpatch.pl message:
> "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
> drivers/staging/ks7010/ks_hostif.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 2666f9e30c15..ab731a2f7bb3 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)
>
> if (ps_status == PS_SNOOZE) {
> ks_wlan_hw_wakeup_request(priv);
> - time_left = wait_for_completion_interruptible_timeout(
> - &priv->psstatus.wakeup_wait,
> - msecs_to_jiffies(20));
> + time_left = wait_for_completion_interruptible_timeout(&priv->psstatus.wakeup_wait,
> + msecs_to_jiffies(20));
And now you have created a line over 80 characters, so you can send a
patch fixing that, and around you go :(
Just leave this as-is, it's fine now.
thanks,
greg k-h
next prev parent reply other threads:[~2019-10-27 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 6:02 [PATCH] staging: ks7010: Fix line ending with a '(' Frank A. Cancio Bello
2019-10-27 7:12 ` Greg KH [this message]
2019-10-27 7:28 ` [Outreachy kernel] " Julia Lawall
2019-10-28 1:44 ` Frank A. Cancio Bello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027071219.GA1704509@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=frank@generalsoftwareinc.com \
--cc=joel@joelfernandes.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.