[PATCH] staging: ks7010: Fix line ending with a '('

[PATCH] staging: ks7010: Fix line ending with a '('

[Frank A. Cancio Bello]

checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"

Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
---
 drivers/staging/ks7010/ks_hostif.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 2666f9e30c15..ab731a2f7bb3 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)
 
 	if (ps_status == PS_SNOOZE) {
 		ks_wlan_hw_wakeup_request(priv);
-		time_left = wait_for_completion_interruptible_timeout(
-				&priv->psstatus.wakeup_wait,
-				msecs_to_jiffies(20));
+		time_left = wait_for_completion_interruptible_timeout(&priv->psstatus.wakeup_wait,
+								      msecs_to_jiffies(20));
 		if (time_left <= 0) {
 			netdev_dbg(priv->net_dev, "wake up timeout or interrupted !!!\n");
 			schedule_work(&priv->wakeup_work);
-- 
2.17.1

Re: [PATCH] staging: ks7010: Fix line ending with a '('

[Greg KH]

On Sun, Oct 27, 2019 at 06:02:37AM +0000, Frank A. Cancio Bello wrote:
> checkpatch.pl message:
> "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
> 
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 2666f9e30c15..ab731a2f7bb3 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)
>  
>  	if (ps_status == PS_SNOOZE) {
>  		ks_wlan_hw_wakeup_request(priv);
> -		time_left = wait_for_completion_interruptible_timeout(
> -				&priv->psstatus.wakeup_wait,
> -				msecs_to_jiffies(20));
> +		time_left = wait_for_completion_interruptible_timeout(&priv->psstatus.wakeup_wait,
> +								      msecs_to_jiffies(20));

And now you have created a line over 80 characters, so you can send a
patch fixing that, and around you go :(

Just leave this as-is, it's fine now.

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: ks7010: Fix line ending with a '('

[Julia Lawall]

On Sun, 27 Oct 2019, Frank A. Cancio Bello wrote:

> checkpatch.pl message:
> "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 2666f9e30c15..ab731a2f7bb3 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)
>
>  	if (ps_status == PS_SNOOZE) {
>  		ks_wlan_hw_wakeup_request(priv);
> -		time_left = wait_for_completion_interruptible_timeout(
> -				&priv->psstatus.wakeup_wait,
> -				msecs_to_jiffies(20));
> +		time_left = wait_for_completion_interruptible_timeout(&priv->psstatus.wakeup_wait,
> +								      msecs_to_jiffies(20));

This doesn't seem like a good solution, since it massively violates the 80
character boundary.  I don't think there is a good solution in this case.

julia

>  		if (time_left <= 0) {
>  			netdev_dbg(priv->net_dev, "wake up timeout or interrupted !!!\n");
>  			schedule_work(&priv->wakeup_work);
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191027060237.GA26854%40linux-kernel-dev.
>

Re: [Outreachy kernel] [PATCH] staging: ks7010: Fix line ending with a '('

[Frank A. Cancio Bello]

On Sun, Oct 27, 2019 at 08:28:14AM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 27 Oct 2019, Frank A. Cancio Bello wrote:
> 
> > checkpatch.pl message:
> > "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
> >
> > Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> > ---
> >  drivers/staging/ks7010/ks_hostif.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> > index 2666f9e30c15..ab731a2f7bb3 100644
> > --- a/drivers/staging/ks7010/ks_hostif.c
> > +++ b/drivers/staging/ks7010/ks_hostif.c
> > @@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)
> >
> >  	if (ps_status == PS_SNOOZE) {
> >  		ks_wlan_hw_wakeup_request(priv);
> > -		time_left = wait_for_completion_interruptible_timeout(
> > -				&priv->psstatus.wakeup_wait,
> > -				msecs_to_jiffies(20));
> > +		time_left = wait_for_completion_interruptible_timeout(&priv->psstatus.wakeup_wait,
> > +								      msecs_to_jiffies(20));
> 
> This doesn't seem like a good solution, since it massively violates the 80
> character boundary.  I don't think there is a good solution in this case.
> 
> julia
>

Thanks, both Greg and Julia for the quick response.

frank a.

> >  		if (time_left <= 0) {
> >  			netdev_dbg(priv->net_dev, "wake up timeout or interrupted !!!\n");
> >  			schedule_work(&priv->wakeup_work);
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191027060237.GA26854%40linux-kernel-dev.
> >