All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Frank A. Cancio Bello" <frank@generalsoftwareinc.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com,
	saiprakash.ranjan@codeaurora.org, joel@joelfernandes.org,
	Vaibhav Agarwal <vaibhav.sr@gmail.com>,
	Mark Greer <mgreer@animalcreek.com>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>
Subject: Re: [PATCH] staging: greybus: Fix line ending with a '('
Date: Mon, 28 Oct 2019 02:14:11 +0000	[thread overview]
Message-ID: <20191028021411.zh22v3dvanbtynaz@linux-kernel-dev> (raw)
In-Reply-To: <20191027071240.GB1704509@kroah.com>

On Sun, Oct 27, 2019 at 08:12:40AM +0100, Greg KH wrote:
> On Sun, Oct 27, 2019 at 06:33:38AM +0000, Frank A. Cancio Bello wrote:
> > checkpatch.pl message:
> > "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
> > 
> > Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> > ---
> >  .../staging/greybus/audio_manager_module.c    | 32 ++++++++-----------
> >  .../staging/greybus/audio_manager_private.h   |  7 ++--
> >  2 files changed, 16 insertions(+), 23 deletions(-)
> > 
> > diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> > index 2bfd804183c4..1b52dd116e38 100644
> > --- a/drivers/staging/greybus/audio_manager_module.c
> > +++ b/drivers/staging/greybus/audio_manager_module.c
> > @@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)
> >  	kfree(module);
> >  }
> >  
> > -static ssize_t gb_audio_module_name_show(
> > -	struct gb_audio_manager_module *module,
> > -	struct gb_audio_manager_module_attribute *attr, char *buf)
> > +static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
> > +		struct gb_audio_manager_module_attribute *attr, char *buf)
> 
> Same thing here, your line is too long now, it's fine as-is.
>

Thank you one more time for your quick response.

frank a.

> thanks,
> 
> greg k-h


      reply	other threads:[~2019-10-28  2:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-27  6:33 [PATCH] staging: greybus: Fix line ending with a '(' Frank A. Cancio Bello
2019-10-27  7:12 ` Greg KH
2019-10-28  2:14   ` Frank A. Cancio Bello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028021411.zh22v3dvanbtynaz@linux-kernel-dev \
    --to=frank@generalsoftwareinc.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel@joelfernandes.org \
    --cc=johan@kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=vaibhav.sr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.