* [PATCH] staging: greybus: Fix line ending with a '('
@ 2019-10-27 6:33 Frank A. Cancio Bello
2019-10-27 7:12 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Frank A. Cancio Bello @ 2019-10-27 6:33 UTC (permalink / raw)
To: gregkh
Cc: outreachy-kernel, saiprakash.ranjan, joel, Vaibhav Agarwal,
Mark Greer, Johan Hovold, Alex Elder
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
---
.../staging/greybus/audio_manager_module.c | 32 ++++++++-----------
.../staging/greybus/audio_manager_private.h | 7 ++--
2 files changed, 16 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index 2bfd804183c4..1b52dd116e38 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)
kfree(module);
}
-static ssize_t gb_audio_module_name_show(
- struct gb_audio_manager_module *module,
- struct gb_audio_manager_module_attribute *attr, char *buf)
+static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
+ struct gb_audio_manager_module_attribute *attr, char *buf)
{
return sprintf(buf, "%s", module->desc.name);
}
@@ -80,9 +79,8 @@ static ssize_t gb_audio_module_name_show(
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
__ATTR(name, 0664, gb_audio_module_name_show, NULL);
-static ssize_t gb_audio_module_vid_show(
- struct gb_audio_manager_module *module,
- struct gb_audio_manager_module_attribute *attr, char *buf)
+static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
+ struct gb_audio_manager_module_attribute *attr, char *buf)
{
return sprintf(buf, "%d", module->desc.vid);
}
@@ -90,9 +88,8 @@ static ssize_t gb_audio_module_vid_show(
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
__ATTR(vid, 0664, gb_audio_module_vid_show, NULL);
-static ssize_t gb_audio_module_pid_show(
- struct gb_audio_manager_module *module,
- struct gb_audio_manager_module_attribute *attr, char *buf)
+static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
+ struct gb_audio_manager_module_attribute *attr, char *buf)
{
return sprintf(buf, "%d", module->desc.pid);
}
@@ -111,9 +108,8 @@ static struct gb_audio_manager_module_attribute
gb_audio_module_intf_id_attribute =
__ATTR(intf_id, 0664, gb_audio_module_intf_id_show, NULL);
-static ssize_t gb_audio_module_ip_devices_show(
- struct gb_audio_manager_module *module,
- struct gb_audio_manager_module_attribute *attr, char *buf)
+static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *module,
+ struct gb_audio_manager_module_attribute *attr, char *buf)
{
return sprintf(buf, "0x%X", module->desc.ip_devices);
}
@@ -122,9 +118,8 @@ static struct gb_audio_manager_module_attribute
gb_audio_module_ip_devices_attribute =
__ATTR(ip_devices, 0664, gb_audio_module_ip_devices_show, NULL);
-static ssize_t gb_audio_module_op_devices_show(
- struct gb_audio_manager_module *module,
- struct gb_audio_manager_module_attribute *attr, char *buf)
+static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *module,
+ struct gb_audio_manager_module_attribute *attr, char *buf)
{
return sprintf(buf, "0x%X", module->desc.op_devices);
}
@@ -180,10 +175,9 @@ static void send_add_uevent(struct gb_audio_manager_module *module)
kobject_uevent_env(&module->kobj, KOBJ_ADD, envp);
}
-int gb_audio_manager_module_create(
- struct gb_audio_manager_module **module,
- struct kset *manager_kset,
- int id, struct gb_audio_manager_module_descriptor *desc)
+int gb_audio_manager_module_create(struct gb_audio_manager_module **module,
+ struct kset *manager_kset,
+ int id, struct gb_audio_manager_module_descriptor *desc)
{
int err;
struct gb_audio_manager_module *m;
diff --git a/drivers/staging/greybus/audio_manager_private.h b/drivers/staging/greybus/audio_manager_private.h
index 2b3a766c7de7..f42b42ecb264 100644
--- a/drivers/staging/greybus/audio_manager_private.h
+++ b/drivers/staging/greybus/audio_manager_private.h
@@ -12,10 +12,9 @@
#include "audio_manager.h"
-int gb_audio_manager_module_create(
- struct gb_audio_manager_module **module,
- struct kset *manager_kset,
- int id, struct gb_audio_manager_module_descriptor *desc);
+int gb_audio_manager_module_create(struct gb_audio_manager_module **module,
+ struct kset *manager_kset,
+ int id, struct gb_audio_manager_module_descriptor *desc);
/* module destroyed via kobject_put */
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: Fix line ending with a '('
2019-10-27 6:33 [PATCH] staging: greybus: Fix line ending with a '(' Frank A. Cancio Bello
@ 2019-10-27 7:12 ` Greg KH
2019-10-28 2:14 ` Frank A. Cancio Bello
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-10-27 7:12 UTC (permalink / raw)
To: Frank A. Cancio Bello
Cc: outreachy-kernel, saiprakash.ranjan, joel, Vaibhav Agarwal,
Mark Greer, Johan Hovold, Alex Elder
On Sun, Oct 27, 2019 at 06:33:38AM +0000, Frank A. Cancio Bello wrote:
> checkpatch.pl message:
> "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
> .../staging/greybus/audio_manager_module.c | 32 ++++++++-----------
> .../staging/greybus/audio_manager_private.h | 7 ++--
> 2 files changed, 16 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index 2bfd804183c4..1b52dd116e38 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)
> kfree(module);
> }
>
> -static ssize_t gb_audio_module_name_show(
> - struct gb_audio_manager_module *module,
> - struct gb_audio_manager_module_attribute *attr, char *buf)
> +static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
> + struct gb_audio_manager_module_attribute *attr, char *buf)
Same thing here, your line is too long now, it's fine as-is.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: Fix line ending with a '('
2019-10-27 7:12 ` Greg KH
@ 2019-10-28 2:14 ` Frank A. Cancio Bello
0 siblings, 0 replies; 3+ messages in thread
From: Frank A. Cancio Bello @ 2019-10-28 2:14 UTC (permalink / raw)
To: Greg KH
Cc: outreachy-kernel, saiprakash.ranjan, joel, Vaibhav Agarwal,
Mark Greer, Johan Hovold, Alex Elder
On Sun, Oct 27, 2019 at 08:12:40AM +0100, Greg KH wrote:
> On Sun, Oct 27, 2019 at 06:33:38AM +0000, Frank A. Cancio Bello wrote:
> > checkpatch.pl message:
> > "CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
> >
> > Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> > ---
> > .../staging/greybus/audio_manager_module.c | 32 ++++++++-----------
> > .../staging/greybus/audio_manager_private.h | 7 ++--
> > 2 files changed, 16 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> > index 2bfd804183c4..1b52dd116e38 100644
> > --- a/drivers/staging/greybus/audio_manager_module.c
> > +++ b/drivers/staging/greybus/audio_manager_module.c
> > @@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)
> > kfree(module);
> > }
> >
> > -static ssize_t gb_audio_module_name_show(
> > - struct gb_audio_manager_module *module,
> > - struct gb_audio_manager_module_attribute *attr, char *buf)
> > +static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
> > + struct gb_audio_manager_module_attribute *attr, char *buf)
>
> Same thing here, your line is too long now, it's fine as-is.
>
Thank you one more time for your quick response.
frank a.
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-28 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-27 6:33 [PATCH] staging: greybus: Fix line ending with a '(' Frank A. Cancio Bello
2019-10-27 7:12 ` Greg KH
2019-10-28 2:14 ` Frank A. Cancio Bello
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.