[RESEND PATCH] staging: gasket: Fix lines ending with a '('

[RESEND PATCH] staging: gasket: Fix lines ending with a '('

[Cristiane Naves]

Fix lines ending with a '('. Issue found by checkpatch.

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/gasket/gasket_ioctl.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
index d1b3e9a..e3047d3 100644
--- a/drivers/staging/gasket/gasket_ioctl.c
+++ b/drivers/staging/gasket/gasket_ioctl.c
@@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
 	ibuf.size = gasket_page_table_num_entries(
 		gasket_dev->page_table[ibuf.page_table_index]);
 
-	trace_gasket_ioctl_page_table_data(
-		ibuf.page_table_index, ibuf.size, ibuf.host_address,
-		ibuf.device_address);
+	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
+					   ibuf.host_address,
+					   ibuf.device_address);
 
 	if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
 		return -EFAULT;
@@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
 	if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
 		return -EFAULT;
 
-	trace_gasket_ioctl_page_table_data(
-		ibuf.page_table_index, ibuf.size, ibuf.host_address,
-		ibuf.device_address);
+	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
+					   ibuf.host_address,
+					   ibuf.device_address);
 
 	if (ibuf.page_table_index >= gasket_dev->num_page_tables)
 		return -EFAULT;
-- 
2.7.4

Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines ending with a '('

[Julia Lawall]

On Fri, 25 Oct 2019, Cristiane Naves wrote:

> Fix lines ending with a '('. Issue found by checkpatch.

You sent another patch on this file (the one I acked) and they are notin a
series, so Greg won't know how to apply them.  Please collect the whole
thing again, and either put both changes in the same patch, or send a
series with the different changes on this file.  You could put v2, so that
Greg knows to ignore your other changes on the file.

julia

>
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/staging/gasket/gasket_ioctl.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index d1b3e9a..e3047d3 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
>  	ibuf.size = gasket_page_table_num_entries(
>  		gasket_dev->page_table[ibuf.page_table_index]);
>
> -	trace_gasket_ioctl_page_table_data(
> -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> -		ibuf.device_address);
> +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> +					   ibuf.host_address,
> +					   ibuf.device_address);
>
>  	if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
>  		return -EFAULT;
> @@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
>  	if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
>  		return -EFAULT;
>
> -	trace_gasket_ioctl_page_table_data(
> -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> -		ibuf.device_address);
> +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> +					   ibuf.host_address,
> +					   ibuf.device_address);
>
>  	if (ibuf.page_table_index >= gasket_dev->num_page_tables)
>  		return -EFAULT;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025232935.GA813%40cristiane-Inspiron-5420.
>

Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix lines ending with a '('

[Cristiane Naves]

On Sat, Oct 26, 2019 at 06:43:46AM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 25 Oct 2019, Cristiane Naves wrote:
> 
> > Fix lines ending with a '('. Issue found by checkpatch.
> 
> You sent another patch on this file (the one I acked) and they are notin a
> series, so Greg won't know how to apply them.  Please collect the whole
> thing again, and either put both changes in the same patch, or send a
> series with the different changes on this file.  You could put v2, so that
> Greg knows to ignore your other changes on the file.
> 
> julia
>
I will join the two patches in just 1 and I will resend as v2.
Thanks!
> >
> > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > ---
> >  drivers/staging/gasket/gasket_ioctl.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> > index d1b3e9a..e3047d3 100644
> > --- a/drivers/staging/gasket/gasket_ioctl.c
> > +++ b/drivers/staging/gasket/gasket_ioctl.c
> > @@ -54,9 +54,9 @@ static int gasket_read_page_table_size(struct gasket_dev *gasket_dev,
> >  	ibuf.size = gasket_page_table_num_entries(
> >  		gasket_dev->page_table[ibuf.page_table_index]);
> >
> > -	trace_gasket_ioctl_page_table_data(
> > -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> > -		ibuf.device_address);
> > +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> > +					   ibuf.host_address,
> > +					   ibuf.device_address);
> >
> >  	if (copy_to_user(argp, &ibuf, sizeof(ibuf)))
> >  		return -EFAULT;
> > @@ -101,9 +101,9 @@ static int gasket_partition_page_table(struct gasket_dev *gasket_dev,
> >  	if (copy_from_user(&ibuf, argp, sizeof(struct gasket_page_table_ioctl)))
> >  		return -EFAULT;
> >
> > -	trace_gasket_ioctl_page_table_data(
> > -		ibuf.page_table_index, ibuf.size, ibuf.host_address,
> > -		ibuf.device_address);
> > +	trace_gasket_ioctl_page_table_data(ibuf.page_table_index, ibuf.size,
> > +					   ibuf.host_address,
> > +					   ibuf.device_address);
> >
> >  	if (ibuf.page_table_index >= gasket_dev->num_page_tables)
> >  		return -EFAULT;
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025232935.GA813%40cristiane-Inspiron-5420.
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910260642250.2559%40hadrien.

Re: [RESEND PATCH] staging: gasket: Fix lines ending with a '('

[Dan Carpenter]

When I see a RESEND in the subject, that means you are tell us we messed
up and accidentally ignored your patch.  So then we have to figure out
what went wrong with the process and so we don't mess up again.

It would help us if you put a note under the --- cut off like "I sent
this a month ago and never received a response.  Here is a link to the
email archive so I know that it made it to the list."

I recently had an issue like this where I complained that my patch
wasn't applied and the maintainer said "Oh.  That's odd.  I have it
written down in patchword that I emailed you to ask you do fix the bug
in a different way."  So these sorts of mistakes happen.

regards,
dan carpenter

Re: [RESEND PATCH] staging: gasket: Fix lines ending with a '('

[Cristiane Naves]

On Mon, Oct 28, 2019 at 10:57:38AM +0300, Dan Carpenter wrote:
> When I see a RESEND in the subject, that means you are tell us we messed
> up and accidentally ignored your patch.  So then we have to figure out
> what went wrong with the process and so we don't mess up again.
> 
> It would help us if you put a note under the --- cut off like "I sent
> this a month ago and never received a response.  Here is a link to the
> email archive so I know that it made it to the list."
> 
> I recently had an issue like this where I complained that my patch
> wasn't applied and the maintainer said "Oh.  That's odd.  I have it
> written down in patchword that I emailed you to ask you do fix the bug
> in a different way."  So these sorts of mistakes happen.
> 
> regards,
> dan carpenter
> 
>
I sent the RESEND in a wrong way. The correct one in my case would be to
have sent a new version. After observing this, I submitted PATCH v3.

I did not know that you had to send the note in case of RESEND. Thanks
for the feedback!