* [PATCH] ath11k: Fixing TLV length issue in peer pktlog WMI command
@ 2019-10-29 2:57 Vikas Patel
2019-11-07 9:02 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Vikas Patel @ 2019-10-29 2:57 UTC (permalink / raw)
To: ath11k; +Cc: Vikas Patel
TLV length was 0 for TLV tag 'WMI_TAG_ARRAY_STRUCT' causing
Q6 to crash when trying to configure pktlog filter via debugfs.
Signed-off-by: Vikas Patel <vikpatel@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index ccebf7ce420a..aae6e76330da 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -2329,7 +2329,7 @@ int ath11k_wmi_pdev_peer_pktlog_filter(struct ath11k *ar, u8 *addr, u8 enable)
tlv = ptr;
tlv->header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_ARRAY_STRUCT) |
- FIELD_PREP(WMI_TLV_LEN, 0);
+ FIELD_PREP(WMI_TLV_LEN, sizeof(*info));
ptr += TLV_HDR_SIZE;
info = ptr;
--
2.23.0
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: Fixing TLV length issue in peer pktlog WMI command
2019-10-29 2:57 [PATCH] ath11k: Fixing TLV length issue in peer pktlog WMI command Vikas Patel
@ 2019-11-07 9:02 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-11-07 9:02 UTC (permalink / raw)
To: Vikas Patel; +Cc: ath11k
Vikas Patel <vikpatel@codeaurora.org> wrote:
> TLV length was 0 for TLV tag 'WMI_TAG_ARRAY_STRUCT' causing
> Q6 to crash when trying to configure pktlog filter via debugfs.
>
> Signed-off-by: Vikas Patel <vikpatel@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath11k-post-bringup branch of ath.git, thanks.
86a3e1b38dcb ath11k: Fixing TLV length issue in peer pktlog WMI command
--
https://patchwork.kernel.org/patch/11216897/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-07 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 2:57 [PATCH] ath11k: Fixing TLV length issue in peer pktlog WMI command Vikas Patel
2019-11-07 9:02 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.