All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: vigneshr@ti.com, richard@nod.at, joern@lazybastard.org,
	linux-kernel@vger.kernel.org, marek.vasut@gmail.com,
	linux-mtd@lists.infradead.org, saurav.girepunje@hotmail.com,
	computersforpeace@gmail.com, dwmw2@infradead.org
Subject: Re: [PATCH] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup
Date: Tue, 29 Oct 2019 12:22:47 +0100	[thread overview]
Message-ID: <20191029122247.73e1c573@xps13> (raw)
In-Reply-To: <20191028181300.GA26250@saurav>

Hi Saurav,

Saurav Girepunje <saurav.girepunje@gmail.com> wrote on Mon, 28 Oct 2019
23:43:01 +0530:

> Remove multiple kfree statement from phram_setup() in phram.c
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---

Here you should add a changelog with the changes you have done since
the last version.

Also when formatting the patch use -v <x> to add a version prefix
into the title, like [PATCH v<x>].

>  drivers/mtd/devices/phram.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index c467286ca007..38f95a1517ac 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -243,22 +243,22 @@ static int phram_setup(const char *val)
>  
>  	ret = parse_num64(&start, token[1]);
>  	if (ret) {
> -		kfree(name);
>  		parse_err("illegal start address\n");
> +		goto free_nam;

s/nam/name

>  	}
>  
>  	ret = parse_num64(&len, token[2]);
>  	if (ret) {
> -		kfree(name);
>  		parse_err("illegal device length\n");
> +		goto free_nam;
>  	}
>  
>  	ret = register_device(name, start, len);
>  	if (!ret)
>  		pr_info("%s device: %#llx at %#llx\n", name, len, start);
> -	else
> -		kfree(name);
>  
> +free_nam:
> +	kfree(name);
>  	return ret;
>  }
>  

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: joern@lazybastard.org, dwmw2@infradead.org,
	computersforpeace@gmail.com, marek.vasut@gmail.com,
	richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup
Date: Tue, 29 Oct 2019 12:22:47 +0100	[thread overview]
Message-ID: <20191029122247.73e1c573@xps13> (raw)
In-Reply-To: <20191028181300.GA26250@saurav>

Hi Saurav,

Saurav Girepunje <saurav.girepunje@gmail.com> wrote on Mon, 28 Oct 2019
23:43:01 +0530:

> Remove multiple kfree statement from phram_setup() in phram.c
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---

Here you should add a changelog with the changes you have done since
the last version.

Also when formatting the patch use -v <x> to add a version prefix
into the title, like [PATCH v<x>].

>  drivers/mtd/devices/phram.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index c467286ca007..38f95a1517ac 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -243,22 +243,22 @@ static int phram_setup(const char *val)
>  
>  	ret = parse_num64(&start, token[1]);
>  	if (ret) {
> -		kfree(name);
>  		parse_err("illegal start address\n");
> +		goto free_nam;

s/nam/name

>  	}
>  
>  	ret = parse_num64(&len, token[2]);
>  	if (ret) {
> -		kfree(name);
>  		parse_err("illegal device length\n");
> +		goto free_nam;
>  	}
>  
>  	ret = register_device(name, start, len);
>  	if (!ret)
>  		pr_info("%s device: %#llx at %#llx\n", name, len, start);
> -	else
> -		kfree(name);
>  
> +free_nam:
> +	kfree(name);
>  	return ret;
>  }
>  

Thanks,
Miquèl

  reply	other threads:[~2019-10-29 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 18:13 [PATCH] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup Saurav Girepunje
2019-10-28 18:13 ` Saurav Girepunje
2019-10-29 11:22 ` Miquel Raynal [this message]
2019-10-29 11:22   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029122247.73e1c573@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=joern@lazybastard.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=saurav.girepunje@gmail.com \
    --cc=saurav.girepunje@hotmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.