* [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
@ 2019-10-29 9:33 ` zhengbin
0 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-10-29 9:33 UTC (permalink / raw)
To: dhowells, jmorris, serge, sumit.garg, jarkko.sakkinen, keyrings,
linux-security-module
Cc: yi.zhang, zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
It is introduced by commit 00aa975bd031 ("KEYS: trusted:
Create trusted keys subsystem"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
security/keys/trusted-keys/trusted_tpm1.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c
index eb5074e..d2c5ec1 100644
--- a/security/keys/trusted-keys/trusted_tpm1.c
+++ b/security/keys/trusted-keys/trusted_tpm1.c
@@ -585,7 +585,6 @@ static int tpm_unseal(struct tpm_buf *tb,
uint32_t authhandle2 = 0;
unsigned char cont = 0;
uint32_t ordinal;
- uint32_t keyhndl;
int ret;
/* sessions for unsealing key and data */
@@ -601,7 +600,6 @@ static int tpm_unseal(struct tpm_buf *tb,
}
ordinal = htonl(TPM_ORD_UNSEAL);
- keyhndl = htonl(SRKHANDLE);
ret = tpm_get_random(chip, nonceodd, TPM_NONCE_SIZE);
if (ret != TPM_NONCE_SIZE) {
pr_info("trusted_key: tpm_get_random failed (%d)\n", ret);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
@ 2019-10-29 9:33 ` zhengbin
0 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-10-29 9:33 UTC (permalink / raw)
To: dhowells, jmorris, serge, sumit.garg, jarkko.sakkinen, keyrings,
linux-security-module
Cc: yi.zhang, zhengbin13
Fixes gcc '-Wunused-but-set-variable' warning:
security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
It is introduced by commit 00aa975bd031 ("KEYS: trusted:
Create trusted keys subsystem"), but never used, so remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
security/keys/trusted-keys/trusted_tpm1.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_tpm1.c b/security/keys/trusted-keys/trusted_tpm1.c
index eb5074e..d2c5ec1 100644
--- a/security/keys/trusted-keys/trusted_tpm1.c
+++ b/security/keys/trusted-keys/trusted_tpm1.c
@@ -585,7 +585,6 @@ static int tpm_unseal(struct tpm_buf *tb,
uint32_t authhandle2 = 0;
unsigned char cont = 0;
uint32_t ordinal;
- uint32_t keyhndl;
int ret;
/* sessions for unsealing key and data */
@@ -601,7 +600,6 @@ static int tpm_unseal(struct tpm_buf *tb,
}
ordinal = htonl(TPM_ORD_UNSEAL);
- keyhndl = htonl(SRKHANDLE);
ret = tpm_get_random(chip, nonceodd, TPM_NONCE_SIZE);
if (ret != TPM_NONCE_SIZE) {
pr_info("trusted_key: tpm_get_random failed (%d)\n", ret);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
2019-10-29 9:33 ` zhengbin
@ 2019-10-29 14:16 ` Jarkko Sakkinen
-1 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2019-10-29 14:16 UTC (permalink / raw)
To: zhengbin
Cc: dhowells, jmorris, serge, sumit.garg, keyrings,
linux-security-module, yi.zhang
On Tue, Oct 29, 2019 at 05:33:32PM +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
> security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 00aa975bd031 ("KEYS: trusted:
> Create trusted keys subsystem"), but never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
I'll pick this to my tree.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
@ 2019-10-29 14:16 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2019-10-29 14:16 UTC (permalink / raw)
To: zhengbin
Cc: dhowells, jmorris, serge, sumit.garg, keyrings,
linux-security-module, yi.zhang
On Tue, Oct 29, 2019 at 05:33:32PM +0800, zhengbin wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
> security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
>
> It is introduced by commit 00aa975bd031 ("KEYS: trusted:
> Create trusted keys subsystem"), but never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
I'll pick this to my tree.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
2019-10-29 14:16 ` Jarkko Sakkinen
@ 2019-10-29 14:18 ` Jarkko Sakkinen
-1 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2019-10-29 14:18 UTC (permalink / raw)
To: zhengbin
Cc: dhowells, jmorris, serge, sumit.garg, keyrings,
linux-security-module, yi.zhang
On Tue, Oct 29, 2019 at 04:16:37PM +0200, Jarkko Sakkinen wrote:
> On Tue, Oct 29, 2019 at 05:33:32PM +0800, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
> > security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
> >
> > It is introduced by commit 00aa975bd031 ("KEYS: trusted:
> > Create trusted keys subsystem"), but never used, so remove it.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: zhengbin <zhengbin13@huawei.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> I'll pick this to my tree.
Please use fixes tag next time instead of ad hoc.
Anyway, applied, thanks.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
@ 2019-10-29 14:18 ` Jarkko Sakkinen
0 siblings, 0 replies; 6+ messages in thread
From: Jarkko Sakkinen @ 2019-10-29 14:18 UTC (permalink / raw)
To: zhengbin
Cc: dhowells, jmorris, serge, sumit.garg, keyrings,
linux-security-module, yi.zhang
On Tue, Oct 29, 2019 at 04:16:37PM +0200, Jarkko Sakkinen wrote:
> On Tue, Oct 29, 2019 at 05:33:32PM +0800, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
> > security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
> >
> > It is introduced by commit 00aa975bd031 ("KEYS: trusted:
> > Create trusted keys subsystem"), but never used, so remove it.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: zhengbin <zhengbin13@huawei.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> I'll pick this to my tree.
Please use fixes tag next time instead of ad hoc.
Anyway, applied, thanks.
/Jarkko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-29 14:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-29 9:33 [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl' zhengbin
2019-10-29 9:33 ` zhengbin
2019-10-29 14:16 ` Jarkko Sakkinen
2019-10-29 14:16 ` Jarkko Sakkinen
2019-10-29 14:18 ` Jarkko Sakkinen
2019-10-29 14:18 ` Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.